[PATCH] Disable caml-stubdom by default

[PATCH] Disable caml-stubdom by default

[Matthew Fioravante]

Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
---
 stubdom/configure.ac |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stubdom/configure.ac b/stubdom/configure.ac
index db44d4a..384a94a 100644
--- a/stubdom/configure.ac
+++ b/stubdom/configure.ac
@@ -18,7 +18,7 @@ m4_include([../m4/depends.m4])
 # Enable/disable stub domains
 AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
 AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
-AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
+AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
 AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
 AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
 AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
-- 
1.7.10.4

Re: [PATCH] Disable caml-stubdom by default

[George Dunlap]

[-- Attachment #1.1: Type: text/plain, Size: 1106 bytes --]

Is there a rationale for this?  If so, it should probably be in the commit
message.

 -George


On Thu, Dec 13, 2012 at 3:31 PM, Matthew Fioravante <
matthew.fioravante@jhuapl.edu> wrote:

> Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> ---
>  stubdom/configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubdom/configure.ac b/stubdom/configure.ac
> index db44d4a..384a94a 100644
> --- a/stubdom/configure.ac
> +++ b/stubdom/configure.ac
> @@ -18,7 +18,7 @@ m4_include([../m4/depends.m4])
>  # Enable/disable stub domains
>  AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
>  AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
> -AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
> +AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
>  AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
>  AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
>  AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
> --
> 1.7.10.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>

[-- Attachment #1.2: Type: text/html, Size: 1954 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Disable caml-stubdom by default

[Fioravante, Matthew E.]

Caml was disabled in the original stubdom default build targets. I should not have enabled it in my original stubdom autoconf patch.

________________________________________
From: dunlapg@gmail.com [dunlapg@gmail.com] On Behalf Of George Dunlap [dunlapg@umich.edu]
Sent: Thursday, December 13, 2012 12:47 PM
To: Fioravante, Matthew E.
Cc: Ian Campbell; xen-devel@lists.xen.org
Subject: Re: [Xen-devel] [PATCH] Disable caml-stubdom by default

Is there a rationale for this?  If so, it should probably be in the commit message.

 -George


On Thu, Dec 13, 2012 at 3:31 PM, Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>> wrote:
Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>>
---
 stubdom/configure.ac<http://configure.ac> |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stubdom/configure.ac<http://configure.ac> b/stubdom/configure.ac<http://configure.ac>
index db44d4a..384a94a 100644
--- a/stubdom/configure.ac<http://configure.ac>
+++ b/stubdom/configure.ac<http://configure.ac>
@@ -18,7 +18,7 @@ m4_include([../m4/depends.m4])
 # Enable/disable stub domains
 AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
 AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
-AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
+AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
 AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
 AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
 AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
--
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org<mailto:Xen-devel@lists.xen.org>
http://lists.xen.org/xen-devel

Re: [PATCH] Disable caml-stubdom by default

[Roger Pau Monné]

On 14/12/12 15:33, Fioravante, Matthew E. wrote:
> Caml was disabled in the original stubdom default build targets. I should not have enabled it in my original stubdom autoconf patch.

Does caml-stubdom require something else apart from caml itself? If not
I think it should be enabled by default if caml is detected (like we do
for the caml xenstore in the tools).

> ________________________________________
> From: dunlapg@gmail.com [dunlapg@gmail.com] On Behalf Of George Dunlap [dunlapg@umich.edu]
> Sent: Thursday, December 13, 2012 12:47 PM
> To: Fioravante, Matthew E.
> Cc: Ian Campbell; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [PATCH] Disable caml-stubdom by default
> 
> Is there a rationale for this?  If so, it should probably be in the commit message.
> 
>  -George
> 
> 
> On Thu, Dec 13, 2012 at 3:31 PM, Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>> wrote:
> Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>>
> ---
>  stubdom/configure.ac<http://configure.ac> |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/stubdom/configure.ac<http://configure.ac> b/stubdom/configure.ac<http://configure.ac>
> index db44d4a..384a94a 100644
> --- a/stubdom/configure.ac<http://configure.ac>
> +++ b/stubdom/configure.ac<http://configure.ac>
> @@ -18,7 +18,7 @@ m4_include([../m4/depends.m4])
>  # Enable/disable stub domains
>  AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
>  AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
> -AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
> +AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
>  AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
>  AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
>  AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
> --
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org<mailto:Xen-devel@lists.xen.org>
> http://lists.xen.org/xen-devel
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
> 

Re: [PATCH] Disable caml-stubdom by default

[Fioravante, Matthew E.]

I thought the purpose of caml stubdom like c stubdom is an example for developing new domains. If that is the case, then I don't think it makes sense to build and install it by default. End users who are just building and installing xen don't need to have it.

The other problem is that c-stubdom and caml-stubdom have main() functions but also define CONFIG_TEST=y in their config files. The test framework also defines a main() function, causing a multiple definition linker error.

Whats the intention here? Do we want them to run the test code or do we want them to just be simple stubs with hello world main functions?
________________________________________
From: Roger Pau Monné [roger.pau@citrix.com]
Sent: Friday, December 14, 2012 10:34 AM
To: Fioravante, Matthew E.
Cc: George Dunlap; Ian Campbell; xen-devel@lists.xen.org
Subject: Re: [Xen-devel] [PATCH] Disable caml-stubdom by default

On 14/12/12 15:33, Fioravante, Matthew E. wrote:
> Caml was disabled in the original stubdom default build targets. I should not have enabled it in my original stubdom autoconf patch.

Does caml-stubdom require something else apart from caml itself? If not
I think it should be enabled by default if caml is detected (like we do
for the caml xenstore in the tools).

> ________________________________________
> From: dunlapg@gmail.com [dunlapg@gmail.com] On Behalf Of George Dunlap [dunlapg@umich.edu]
> Sent: Thursday, December 13, 2012 12:47 PM
> To: Fioravante, Matthew E.
> Cc: Ian Campbell; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [PATCH] Disable caml-stubdom by default
>
> Is there a rationale for this?  If so, it should probably be in the commit message.
>
>  -George
>
>
> On Thu, Dec 13, 2012 at 3:31 PM, Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>> wrote:
> Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>>
> ---
>  stubdom/configure.ac<http://configure.ac> |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubdom/configure.ac<http://configure.ac> b/stubdom/configure.ac<http://configure.ac>
> index db44d4a..384a94a 100644
> --- a/stubdom/configure.ac<http://configure.ac>
> +++ b/stubdom/configure.ac<http://configure.ac>
> @@ -18,7 +18,7 @@ m4_include([../m4/depends.m4])
>  # Enable/disable stub domains
>  AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
>  AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
> -AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
> +AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
>  AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
>  AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
>  AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
> --
> 1.7.10.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org<mailto:Xen-devel@lists.xen.org>
> http://lists.xen.org/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>

Re: [PATCH] Disable caml-stubdom by default

[Ian Campbell]

*Please* can you stop top posting.

    A: Because it messes up the order in which people normally read text.
    Q: Why is top-posting such a bad thing?

On Fri, 2012-12-14 at 16:20 +0000, Fioravante, Matthew E. wrote:
> I thought the purpose of caml stubdom like c stubdom is an example for
> developing new domains. If that is the case, then I don't think it
> makes sense to build and install it by default. End users who are just
> building and installing xen don't need to have it.
> 
> The other problem is that c-stubdom and caml-stubdom have main()
> functions but also define CONFIG_TEST=y in their config files. The
> test framework also defines a main() function, causing a multiple
> definition linker error.
> 
> Whats the intention here? Do we want them to run the test code or do
> we want them to just be simple stubs with hello world main functions?

I think the Caml one should certainly drop CONFIG_TEST. Any "test"
behaviour of that domain should be done in ocaml not in C.

For the C one I'm less sure. I'd be in favour of nuking it but then
nothing (AFAIK) would be using CONFIG_TEST. Since the C one doesn't
really do anything else I guess it may as well continue to be the
CONFIG_TEST-bed. But then main might as well be nuked.

Ian.