From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Felipe Balbi <balbi@ti.com>, Luciano Coelho <coelho@ti.com>,
svenkatr@ti.com, linux-omap@vger.kernel.org,
linux-mmc@vger.kernel.org, cjb@laptop.org, lrg@ti.com,
linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: 32kHz clock removal causes problems omap_hsmmc
Date: Wed, 19 Dec 2012 11:00:32 +0100 [thread overview]
Message-ID: <50D19040.5090404@ti.com> (raw)
In-Reply-To: <20121219094552.GN4985@opensource.wolfsonmicro.com>
On 12/19/2012 10:45 AM, Mark Brown wrote:
> On Tue, Dec 18, 2012 at 11:54:50AM +0200, Felipe Balbi wrote:
>
>> damn, this is still part of our v3.7-rc kernel. Original commit was done
>> with no testing whatsoever and caused a big regression to (at least)
>> TI's WiFi driver which depend on SDIO to function.
>
>> Too bad things break and even when reported nobody gives a rat's ***
>> about them :-s
>
> I guess it's going to be even more of an issue going forward given the
> recent events but FWIW it was always very unusual to see any review of
> any TWL patches, the PMIC appeared to have been rather abandoned so the
> only way of getting any testing was to put stuff in -next and hope.
As for the twl-regulator I still have plan to do a major cleanup there. It is
just sad that it received the DT bindings for the current code. The DT support
addition would have been the perfect place to sanitize it. Now it is just
going to be a huge pain in the back.
As for the 32k clock:
I don't know the state of the common clock framework for OMAPs. Is it already
up in 3.7? Or going for 3.8? 3.9? 3.10?...
We need CCF to resolve this. I can cook up the clock driver for the 32k clock
from twl, but in order to use it we need CCF on OMAP.
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Felipe Balbi <balbi@ti.com>, Luciano Coelho <coelho@ti.com>,
<svenkatr@ti.com>, <linux-omap@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, <cjb@laptop.org>, <lrg@ti.com>,
<linux-kernel@vger.kernel.org>, Tony Lindgren <tony@atomide.com>
Subject: Re: 32kHz clock removal causes problems omap_hsmmc
Date: Wed, 19 Dec 2012 11:00:32 +0100 [thread overview]
Message-ID: <50D19040.5090404@ti.com> (raw)
In-Reply-To: <20121219094552.GN4985@opensource.wolfsonmicro.com>
On 12/19/2012 10:45 AM, Mark Brown wrote:
> On Tue, Dec 18, 2012 at 11:54:50AM +0200, Felipe Balbi wrote:
>
>> damn, this is still part of our v3.7-rc kernel. Original commit was done
>> with no testing whatsoever and caused a big regression to (at least)
>> TI's WiFi driver which depend on SDIO to function.
>
>> Too bad things break and even when reported nobody gives a rat's ***
>> about them :-s
>
> I guess it's going to be even more of an issue going forward given the
> recent events but FWIW it was always very unusual to see any review of
> any TWL patches, the PMIC appeared to have been rather abandoned so the
> only way of getting any testing was to put stuff in -next and hope.
As for the twl-regulator I still have plan to do a major cleanup there. It is
just sad that it received the DT bindings for the current code. The DT support
addition would have been the perfect place to sanitize it. Now it is just
going to be a huge pain in the back.
As for the 32k clock:
I don't know the state of the common clock framework for OMAPs. Is it already
up in 3.7? Or going for 3.8? 3.9? 3.10?...
We need CCF to resolve this. I can cook up the clock driver for the 32k clock
from twl, but in order to use it we need CCF on OMAP.
--
Péter
next prev parent reply other threads:[~2012-12-19 10:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 8:31 32kHz clock removal causes problems omap_hsmmc Luciano Coelho
2012-11-15 8:31 ` Luciano Coelho
2012-12-18 9:54 ` Felipe Balbi
2012-12-18 9:54 ` Felipe Balbi
2012-12-19 9:45 ` Mark Brown
2012-12-19 10:00 ` Peter Ujfalusi [this message]
2012-12-19 10:00 ` Peter Ujfalusi
2012-12-19 10:09 ` Mark Brown
2012-12-19 10:18 ` Peter Ujfalusi
2012-12-19 10:18 ` Peter Ujfalusi
2012-12-19 10:32 ` Mark Brown
2012-12-19 10:45 ` Luciano Coelho
2012-12-19 10:45 ` Luciano Coelho
2012-12-19 10:56 ` Peter Ujfalusi
2012-12-19 10:56 ` Peter Ujfalusi
2012-12-19 11:00 ` Peter Ujfalusi
2012-12-19 11:00 ` Peter Ujfalusi
2012-12-19 11:02 ` Mark Brown
2012-12-19 11:07 ` Luciano Coelho
2012-12-19 11:07 ` Luciano Coelho
2012-12-19 13:01 ` Felipe Balbi
2012-12-19 13:01 ` Felipe Balbi
2012-12-19 13:51 ` Benoit Cousson
2012-12-19 13:51 ` Benoit Cousson
2012-12-19 13:54 ` Felipe Balbi
2012-12-19 13:54 ` Felipe Balbi
2012-12-19 13:58 ` Mark Brown
2012-12-19 13:58 ` Luciano Coelho
2012-12-19 13:58 ` Luciano Coelho
2012-12-19 14:04 ` Benoit Cousson
2012-12-19 14:04 ` Benoit Cousson
2012-12-19 18:06 ` R Sricharan
2012-12-19 18:06 ` R Sricharan
2012-12-19 14:31 ` Peter Ujfalusi
2012-12-19 14:31 ` Peter Ujfalusi
2012-12-19 16:28 ` Tony Lindgren
2012-12-19 10:01 ` Luciano Coelho
2012-12-19 10:01 ` Luciano Coelho
2012-12-19 10:28 ` Mark Brown
2012-12-19 10:42 ` Luciano Coelho
2012-12-19 10:42 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D19040.5090404@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=coelho@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=svenkatr@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.