From: Stephen Warren <swarren@wwwdotorg.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Stephen Warren <swarren@nvidia.com>,
devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH] of: Fix export of of_find_matching_node_and_match()
Date: Wed, 19 Dec 2012 09:24:08 -0700 [thread overview]
Message-ID: <50D1EA28.2000807@wwwdotorg.org> (raw)
In-Reply-To: <1355914716-19469-1-git-send-email-grant.likely@secretlab.ca>
On 12/19/2012 03:58 AM, Grant Likely wrote:
> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()"
> renamed of_find_matching_node() to of_find_matching_node_and_match() and
> created a new static inline of_find_matching_node() wrapper around the
> new name. However, the change neglected to change the EXPORT_SYMBOL()
> reference causing build errors for modules.
>
> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC
> Efika build with the mpc52xx_uart driver being built as a module.
Oops. The patch is obviously correct,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
I guess none of the ARM defconfigs enable any module that uses this,
since I have built all of them multiple times recently:-(
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] of: Fix export of of_find_matching_node_and_match()
Date: Wed, 19 Dec 2012 09:24:08 -0700 [thread overview]
Message-ID: <50D1EA28.2000807@wwwdotorg.org> (raw)
In-Reply-To: <1355914716-19469-1-git-send-email-grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
On 12/19/2012 03:58 AM, Grant Likely wrote:
> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()"
> renamed of_find_matching_node() to of_find_matching_node_and_match() and
> created a new static inline of_find_matching_node() wrapper around the
> new name. However, the change neglected to change the EXPORT_SYMBOL()
> reference causing build errors for modules.
>
> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC
> Efika build with the mpc52xx_uart driver being built as a module.
Oops. The patch is obviously correct,
Reviewed-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
I guess none of the ARM defconfigs enable any module that uses this,
since I have built all of them multiple times recently:-(
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org,
Stephen Warren <swarren@nvidia.com>,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH] of: Fix export of of_find_matching_node_and_match()
Date: Wed, 19 Dec 2012 09:24:08 -0700 [thread overview]
Message-ID: <50D1EA28.2000807@wwwdotorg.org> (raw)
In-Reply-To: <1355914716-19469-1-git-send-email-grant.likely@secretlab.ca>
On 12/19/2012 03:58 AM, Grant Likely wrote:
> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()"
> renamed of_find_matching_node() to of_find_matching_node_and_match() and
> created a new static inline of_find_matching_node() wrapper around the
> new name. However, the change neglected to change the EXPORT_SYMBOL()
> reference causing build errors for modules.
>
> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC
> Efika build with the mpc52xx_uart driver being built as a module.
Oops. The patch is obviously correct,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
I guess none of the ARM defconfigs enable any module that uses this,
since I have built all of them multiple times recently:-(
next prev parent reply other threads:[~2012-12-19 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 10:58 [PATCH] of: Fix export of of_find_matching_node_and_match() Grant Likely
2012-12-19 10:58 ` Grant Likely
2012-12-19 10:58 ` Grant Likely
2012-12-19 11:02 ` Grant Likely
2012-12-19 11:02 ` Grant Likely
2012-12-19 13:50 ` Rob Herring
2012-12-19 13:50 ` Rob Herring
2012-12-19 13:50 ` Rob Herring
2012-12-19 15:04 ` Grant Likely
2012-12-19 15:04 ` Grant Likely
2012-12-19 15:04 ` Grant Likely
2012-12-19 16:24 ` Stephen Warren [this message]
2012-12-19 16:24 ` Stephen Warren
2012-12-19 16:24 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D1EA28.2000807@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.