From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: djbw-b10kYP2dOMg@public.gmane.org,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer
Date: Wed, 19 Dec 2012 10:02:53 -0700 [thread overview]
Message-ID: <50D1F33D.1050709@wwwdotorg.org> (raw)
In-Reply-To: <1355924434-7930-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 12/19/2012 06:40 AM, Laxman Dewangan wrote:
> The flag parameter is added in the cyclic transfer request.
> Use the flag option of:
> - DMA_PREP_INTERRUPT for enabling interrupt.
> - DMA_CTRL_ACK for deciding whether ack is requred or not for
> descriptor.
Do the relevant drivers that use Tegra's DMA engine already set flags
correctly, so that this change won't cause any regressions?
Why would you not want to enable interrupts; how does a client know when
to refill the buffer?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: djbw@fb.com, vinod.koul@intel.com, linux-kernel@vger.kernel.org,
swarren@nvidia.com, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer
Date: Wed, 19 Dec 2012 10:02:53 -0700 [thread overview]
Message-ID: <50D1F33D.1050709@wwwdotorg.org> (raw)
In-Reply-To: <1355924434-7930-1-git-send-email-ldewangan@nvidia.com>
On 12/19/2012 06:40 AM, Laxman Dewangan wrote:
> The flag parameter is added in the cyclic transfer request.
> Use the flag option of:
> - DMA_PREP_INTERRUPT for enabling interrupt.
> - DMA_CTRL_ACK for deciding whether ack is requred or not for
> descriptor.
Do the relevant drivers that use Tegra's DMA engine already set flags
correctly, so that this change won't cause any regressions?
Why would you not want to enable interrupts; how does a client know when
to refill the buffer?
next prev parent reply other threads:[~2012-12-19 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 13:40 [PATCH] dma: tegra: implement flags parameters for cyclic transfer Laxman Dewangan
2012-12-19 13:40 ` Laxman Dewangan
[not found] ` <1355924434-7930-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-19 17:02 ` Stephen Warren [this message]
2012-12-19 17:02 ` Stephen Warren
[not found] ` <50D1F33D.1050709-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-20 6:11 ` Laxman Dewangan
2012-12-20 6:11 ` Laxman Dewangan
[not found] ` <50D2ABF7.8090308-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-20 16:46 ` Stephen Warren
2012-12-20 16:46 ` Stephen Warren
[not found] ` <50D340E1.7040600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-21 4:23 ` Laxman Dewangan
2012-12-21 4:23 ` Laxman Dewangan
[not found] ` <50D3E44F.4060007-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-21 20:53 ` Stephen Warren
2012-12-21 20:53 ` Stephen Warren
[not found] ` <50D4CC62.6080304-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-07 13:52 ` Laxman Dewangan
2013-01-07 13:52 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D1F33D.1050709@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=djbw-b10kYP2dOMg@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.