All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: "vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"djbw-b10kYP2dOMg@public.gmane.org"
	<djbw-b10kYP2dOMg@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer
Date: Mon, 7 Jan 2013 19:22:07 +0530	[thread overview]
Message-ID: <50EAD307.9040604@nvidia.com> (raw)
In-Reply-To: <50D4CC62.6080304-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

On Saturday 22 December 2012 02:23 AM, Stephen Warren wrote:
> On 12/20/2012 09:23 PM, Laxman Dewangan wrote:
>> On Thursday 20 December 2012 10:16 PM, Stephen Warren wrote:
>>> On 12/19/2012 11:11 PM, Laxman Dewangan wrote:
>>>> On Wednesday 19 December 2012 10:32 PM, Stephen Warren wrote:
>>>>> On 12/19/2012 06:40 AM, Laxman Dewangan wrote:
>>>>>> The flag parameter is added in the cyclic transfer request.
>>>>>> Use the flag option of:
>>>>>> - DMA_PREP_INTERRUPT for enabling interrupt.
>>>>>> - DMA_CTRL_ACK for deciding whether ack is requred or not for
>>>>>>      descriptor.
>>>>> Do the relevant drivers that use Tegra's DMA engine already set flags
>>>>> correctly, so that this change won't cause any regressions?
>>>> Currently, the sound soc driver uses the cyclic mode of dma transfer and
>>>> it has already enable the proper flags. This was done recently after
>>>> adding flags in cyclic api.
>>>> Also, there was bug in our dma driver for not setting DMA_CTRL_ACK by
>>>> default for cyclic case.
>>>> This will fix the issue.
>>> OK. I assume "This was done recently after adding flags in cyclic api."
>>> was a patch that went into 3.8?  So, this patch is a bug-fix that should
>>> be included in 3.8 then?
>> I can see this in Linux 3.7 tag.
> So I assume that means that when Vinod applies *this* patch, it should
> be Cc: stable for 3.7 and up?
>
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=history;f=drivers/dma/tegra20-apb-dma.c;h=528c62dd4b00e1b52928ff66f3a54e7ae206680f;hb=29594404d7fe73cd80eaa4ee8c43dcc53970c60e
> I don't think that points where you want; it just shows a log of 3.7 for me.

Oops, I just wanted to say that 3.7 branch and history of 
drivers/dma/tegra20-apb-dma.c shows the above change of inclusion of flags.
Seems link is messed up.

WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "vinod.koul@intel.com" <vinod.koul@intel.com>,
	"djbw@fb.com" <djbw@fb.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Warren <swarren@nvidia.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer
Date: Mon, 7 Jan 2013 19:22:07 +0530	[thread overview]
Message-ID: <50EAD307.9040604@nvidia.com> (raw)
In-Reply-To: <50D4CC62.6080304@wwwdotorg.org>

On Saturday 22 December 2012 02:23 AM, Stephen Warren wrote:
> On 12/20/2012 09:23 PM, Laxman Dewangan wrote:
>> On Thursday 20 December 2012 10:16 PM, Stephen Warren wrote:
>>> On 12/19/2012 11:11 PM, Laxman Dewangan wrote:
>>>> On Wednesday 19 December 2012 10:32 PM, Stephen Warren wrote:
>>>>> On 12/19/2012 06:40 AM, Laxman Dewangan wrote:
>>>>>> The flag parameter is added in the cyclic transfer request.
>>>>>> Use the flag option of:
>>>>>> - DMA_PREP_INTERRUPT for enabling interrupt.
>>>>>> - DMA_CTRL_ACK for deciding whether ack is requred or not for
>>>>>>      descriptor.
>>>>> Do the relevant drivers that use Tegra's DMA engine already set flags
>>>>> correctly, so that this change won't cause any regressions?
>>>> Currently, the sound soc driver uses the cyclic mode of dma transfer and
>>>> it has already enable the proper flags. This was done recently after
>>>> adding flags in cyclic api.
>>>> Also, there was bug in our dma driver for not setting DMA_CTRL_ACK by
>>>> default for cyclic case.
>>>> This will fix the issue.
>>> OK. I assume "This was done recently after adding flags in cyclic api."
>>> was a patch that went into 3.8?  So, this patch is a bug-fix that should
>>> be included in 3.8 then?
>> I can see this in Linux 3.7 tag.
> So I assume that means that when Vinod applies *this* patch, it should
> be Cc: stable for 3.7 and up?
>
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=history;f=drivers/dma/tegra20-apb-dma.c;h=528c62dd4b00e1b52928ff66f3a54e7ae206680f;hb=29594404d7fe73cd80eaa4ee8c43dcc53970c60e
> I don't think that points where you want; it just shows a log of 3.7 for me.

Oops, I just wanted to say that 3.7 branch and history of 
drivers/dma/tegra20-apb-dma.c shows the above change of inclusion of flags.
Seems link is messed up.


  parent reply	other threads:[~2013-01-07 13:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-19 13:40 [PATCH] dma: tegra: implement flags parameters for cyclic transfer Laxman Dewangan
2012-12-19 13:40 ` Laxman Dewangan
     [not found] ` <1355924434-7930-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-19 17:02   ` Stephen Warren
2012-12-19 17:02     ` Stephen Warren
     [not found]     ` <50D1F33D.1050709-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-20  6:11       ` Laxman Dewangan
2012-12-20  6:11         ` Laxman Dewangan
     [not found]         ` <50D2ABF7.8090308-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-20 16:46           ` Stephen Warren
2012-12-20 16:46             ` Stephen Warren
     [not found]             ` <50D340E1.7040600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-21  4:23               ` Laxman Dewangan
2012-12-21  4:23                 ` Laxman Dewangan
     [not found]                 ` <50D3E44F.4060007-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-21 20:53                   ` Stephen Warren
2012-12-21 20:53                     ` Stephen Warren
     [not found]                     ` <50D4CC62.6080304-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-07 13:52                       ` Laxman Dewangan [this message]
2013-01-07 13:52                         ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EAD307.9040604@nvidia.com \
    --to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=djbw-b10kYP2dOMg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.