All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: John Spencer <maillist-qemu@barfooze.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: remove forward declarations
Date: Wed, 26 Dec 2012 08:51:25 +0100	[thread overview]
Message-ID: <50DAAC7D.5050001@weilnetz.de> (raw)
In-Reply-To: <1356479389-1967-1-git-send-email-maillist-qemu@barfooze.de>

Am 26.12.2012 00:49, schrieb John Spencer:
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
>   linux-user/syscall.c |    8 +++-----
>   1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
>   #include <sys/time.h>
>   #include <sys/stat.h>
>   #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
>   #include <sys/prctl.h>
>   #include <sys/resource.h>
>   #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
>             struct host_rlimit64 *, old_limit)
>   #endif
>   
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -
>   /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
>   #ifdef TARGET_ARM
>   static inline int regpairs_aligned(void *cpu_env) {

Reviewed-by: Stefan Weil <sw@weilnetz.de>



WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: John Spencer <maillist-qemu@barfooze.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: remove forward declarations
Date: Wed, 26 Dec 2012 08:51:25 +0100	[thread overview]
Message-ID: <50DAAC7D.5050001@weilnetz.de> (raw)
In-Reply-To: <1356479389-1967-1-git-send-email-maillist-qemu@barfooze.de>

Am 26.12.2012 00:49, schrieb John Spencer:
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
>   linux-user/syscall.c |    8 +++-----
>   1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
>   #include <sys/time.h>
>   #include <sys/stat.h>
>   #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
>   #include <sys/prctl.h>
>   #include <sys/resource.h>
>   #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
>             struct host_rlimit64 *, old_limit)
>   #endif
>   
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -
>   /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
>   #ifdef TARGET_ARM
>   static inline int regpairs_aligned(void *cpu_env) {

Reviewed-by: Stefan Weil <sw@weilnetz.de>

  parent reply	other threads:[~2012-12-26  7:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-25 23:49 [Qemu-trivial] [PATCH] linux-user/syscall.c: remove forward declarations John Spencer
2012-12-25 23:49 ` [Qemu-devel] " John Spencer
2012-12-26  1:25 ` [Qemu-trivial] " Amos Kong
2012-12-26  1:25   ` Amos Kong
2012-12-26  7:51 ` Stefan Weil [this message]
2012-12-26  7:51   ` Stefan Weil
2013-01-03  9:04 ` [Qemu-trivial] " Stefan Hajnoczi
2013-01-03  9:04   ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50DAAC7D.5050001@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=maillist-qemu@barfooze.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.