* [Qemu-devel] [PATCH] linux-user/syscall.c: remove forward declarations
@ 2012-12-25 23:49 ` John Spencer
0 siblings, 0 replies; 8+ messages in thread
From: John Spencer @ 2012-12-25 23:49 UTC (permalink / raw)
To: sw; +Cc: qemu-trivial, qemu-devel, John Spencer
instead use the correct headers that define these functions.
Requested-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
---
linux-user/syscall.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index e99adab..3167a87 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -36,6 +36,9 @@
#include <sys/time.h>
#include <sys/stat.h>
#include <sys/mount.h>
+#include <sys/file.h>
+#include <sys/fsuid.h>
+#include <sys/personality.h>
#include <sys/prctl.h>
#include <sys/resource.h>
#include <sys/mman.h>
@@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
struct host_rlimit64 *, old_limit)
#endif
-extern int personality(int);
-extern int flock(int, int);
-extern int setfsuid(int);
-extern int setfsgid(int);
-
/* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
#ifdef TARGET_ARM
static inline int regpairs_aligned(void *cpu_env) {
--
1.7.3.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user/syscall.c: remove forward declarations
2012-12-25 23:49 ` [Qemu-devel] " John Spencer
@ 2012-12-26 1:25 ` Amos Kong
-1 siblings, 0 replies; 8+ messages in thread
From: Amos Kong @ 2012-12-26 1:25 UTC (permalink / raw)
To: John Spencer; +Cc: qemu-trivial, sw, qemu-devel
On Wed, Dec 26, 2012 at 7:49 AM, John Spencer <maillist-qemu@barfooze.de> wrote:
>
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
> linux-user/syscall.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
> #include <sys/time.h>
> #include <sys/stat.h>
> #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
> #include <sys/prctl.h>
> #include <sys/resource.h>
> #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
> struct host_rlimit64 *, old_limit)
> #endif
>
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -
Reviewed-by: Amos Kong <kongjianjun@gmail.com>
> /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
> #ifdef TARGET_ARM
> static inline int regpairs_aligned(void *cpu_env) {
> --
> 1.7.3.4
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user/syscall.c: remove forward declarations
@ 2012-12-26 1:25 ` Amos Kong
0 siblings, 0 replies; 8+ messages in thread
From: Amos Kong @ 2012-12-26 1:25 UTC (permalink / raw)
To: John Spencer; +Cc: qemu-trivial, sw, qemu-devel
On Wed, Dec 26, 2012 at 7:49 AM, John Spencer <maillist-qemu@barfooze.de> wrote:
>
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
> linux-user/syscall.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
> #include <sys/time.h>
> #include <sys/stat.h>
> #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
> #include <sys/prctl.h>
> #include <sys/resource.h>
> #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
> struct host_rlimit64 *, old_limit)
> #endif
>
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -
Reviewed-by: Amos Kong <kongjianjun@gmail.com>
> /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
> #ifdef TARGET_ARM
> static inline int regpairs_aligned(void *cpu_env) {
> --
> 1.7.3.4
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: remove forward declarations
2012-12-25 23:49 ` [Qemu-devel] " John Spencer
@ 2012-12-26 7:51 ` Stefan Weil
-1 siblings, 0 replies; 8+ messages in thread
From: Stefan Weil @ 2012-12-26 7:51 UTC (permalink / raw)
To: John Spencer; +Cc: qemu-trivial, qemu-devel
Am 26.12.2012 00:49, schrieb John Spencer:
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
> linux-user/syscall.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
> #include <sys/time.h>
> #include <sys/stat.h>
> #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
> #include <sys/prctl.h>
> #include <sys/resource.h>
> #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
> struct host_rlimit64 *, old_limit)
> #endif
>
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -
> /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
> #ifdef TARGET_ARM
> static inline int regpairs_aligned(void *cpu_env) {
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user/syscall.c: remove forward declarations
@ 2012-12-26 7:51 ` Stefan Weil
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Weil @ 2012-12-26 7:51 UTC (permalink / raw)
To: John Spencer; +Cc: qemu-trivial, qemu-devel
Am 26.12.2012 00:49, schrieb John Spencer:
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
> linux-user/syscall.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
> #include <sys/time.h>
> #include <sys/stat.h>
> #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
> #include <sys/prctl.h>
> #include <sys/resource.h>
> #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
> struct host_rlimit64 *, old_limit)
> #endif
>
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -
> /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
> #ifdef TARGET_ARM
> static inline int regpairs_aligned(void *cpu_env) {
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: remove forward declarations
2012-12-25 23:49 ` [Qemu-devel] " John Spencer
@ 2013-01-03 9:04 ` Stefan Hajnoczi
-1 siblings, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2013-01-03 9:04 UTC (permalink / raw)
To: John Spencer; +Cc: qemu-trivial, sw, qemu-devel
On Wed, Dec 26, 2012 at 12:49:49AM +0100, John Spencer wrote:
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
> linux-user/syscall.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread