All of lore.kernel.org
 help / color / mirror / Atom feed
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpuidle: kirkwood: Move out of mach directory, add DT.
Date: Fri, 28 Dec 2012 15:32:08 +0100	[thread overview]
Message-ID: <50DDAD68.4090704@openwrt.org> (raw)
In-Reply-To: <1356698844-4220-1-git-send-email-andrew@lunn.ch>

Hello Andrew,

Le 12/28/12 13:47, Andrew Lunn a ?crit :
> Move the Kirkwood cpuidle driver out of arch/arm/mach-kirkwood and
> into drivers/cpuidle. Convert the driver into a platform driver and
> add a device tree binding. Add a DT node to instantiate the driver for
> boards converted to DT, and a platform data for old style boards.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---

[snip]

>
> +/*****************************************************************************
> + * CPU idle
> + ****************************************************************************/
> +static struct resource kirkwood_cpuidle_resource[] = {
> +	{
> +		.flags	= IORESOURCE_MEM,
> +		.start	= DDR_OPERATION_BASE,
> +		.end	= 3,

Should not this be DDR_OPERATION_BASE + 3?
--
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: len.brown@intel.com, devicetree-discuss@lists.ozlabs.org,
	rafael.j.wysocki@intel.com, Jason Cooper <jason@lakedaemon.net>,
	linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] cpuidle: kirkwood: Move out of mach directory, add DT.
Date: Fri, 28 Dec 2012 15:32:08 +0100	[thread overview]
Message-ID: <50DDAD68.4090704@openwrt.org> (raw)
In-Reply-To: <1356698844-4220-1-git-send-email-andrew@lunn.ch>

Hello Andrew,

Le 12/28/12 13:47, Andrew Lunn a écrit :
> Move the Kirkwood cpuidle driver out of arch/arm/mach-kirkwood and
> into drivers/cpuidle. Convert the driver into a platform driver and
> add a device tree binding. Add a DT node to instantiate the driver for
> boards converted to DT, and a platform data for old style boards.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---

[snip]

>
> +/*****************************************************************************
> + * CPU idle
> + ****************************************************************************/
> +static struct resource kirkwood_cpuidle_resource[] = {
> +	{
> +		.flags	= IORESOURCE_MEM,
> +		.start	= DDR_OPERATION_BASE,
> +		.end	= 3,

Should not this be DDR_OPERATION_BASE + 3?
--
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2012-12-28 14:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-28 12:47 [PATCH] cpuidle: kirkwood: Move out of mach directory, add DT Andrew Lunn
2012-12-28 12:47 ` Andrew Lunn
2012-12-28 14:18 ` Rob Herring
2012-12-28 14:18   ` Rob Herring
2012-12-28 14:35   ` Andrew Lunn
2012-12-28 14:35     ` Andrew Lunn
2012-12-28 14:55     ` Rob Herring
2012-12-28 14:55       ` Rob Herring
2012-12-28 15:49       ` Andrew Lunn
2012-12-28 15:49         ` Andrew Lunn
2012-12-28 16:14         ` Rob Herring
2012-12-28 16:14           ` Rob Herring
2012-12-28 16:38           ` Andrew Lunn
2012-12-28 16:38             ` Andrew Lunn
2012-12-28 16:59             ` Rob Herring
2012-12-28 16:59               ` Rob Herring
2012-12-28 16:56           ` Santosh Shilimkar
2012-12-28 16:56             ` Santosh Shilimkar
2012-12-28 17:28             ` Andrew Lunn
2012-12-28 17:28               ` Andrew Lunn
2012-12-28 17:50               ` Santosh Shilimkar
2012-12-28 17:50                 ` Santosh Shilimkar
2012-12-28 17:56                 ` Andrew Lunn
2012-12-28 17:56                   ` Andrew Lunn
2012-12-28 18:02                   ` Santosh Shilimkar
2012-12-28 18:02                     ` Santosh Shilimkar
2012-12-28 14:32 ` Florian Fainelli [this message]
2012-12-28 14:32   ` Florian Fainelli
2012-12-28 14:37   ` Andrew Lunn
2012-12-28 14:37     ` Andrew Lunn
2013-02-08 21:34 ` Grant Likely
2013-02-08 21:34   ` Grant Likely
2013-02-10 18:58   ` Andrew Lunn
2013-02-10 18:58     ` Andrew Lunn
2013-02-11 11:41     ` Grant Likely
2013-02-11 11:41       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50DDAD68.4090704@openwrt.org \
    --to=florian@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.