From: gshark <gshark.jeong@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] backlight: lm3649_backlight: remove ret = -EIO at error paths of probe
Date: Wed, 02 Jan 2013 08:07:37 +0000 [thread overview]
Message-ID: <50E3EAC9.9070705@gmail.com> (raw)
In-Reply-To: <1356977911-13521-1-git-send-email-devendra.aaru@gmail.com>
2013년 01월 02일 08:47, Jingoo Han 쓴 글:
> On Tuesday, January 01, 2013 3:19 AM, Devendra Naga wrote
>> the APIs are returning correctly the err codes, no need of assigning -EIO to the
>> ret again
>>
>> Cc: Daniel Jeong <daniel.jeong@ti.com>
>> Cc: G.Shark Jeong <gshark.jeong@gmail.com>
>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> It looks good.
> Acked-by: Jingoo Han <jg1.han@samsung.com>
>
>
> Best regards,
> Jingoo Han
>
>> ---
>> drivers/video/backlight/lm3639_bl.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
>> index 7ab2d2a..053964d 100644
>> --- a/drivers/video/backlight/lm3639_bl.c
>> +++ b/drivers/video/backlight/lm3639_bl.c
>> @@ -350,14 +350,13 @@ static int lm3639_probe(struct i2c_client *client,
>> &lm3639_bled_ops, &props);
>> if (IS_ERR(pchip->bled)) {
>> dev_err(&client->dev, "fail : backlight register\n");
>> - ret = -EIO;
>> + ret = PTR_ERR(pchip->bled);
>> goto err_out;
>> }
>>
>> ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode);
>> if (ret < 0) {
>> dev_err(&client->dev, "failed : add sysfs entries\n");
>> - ret = -EIO;
>> goto err_bled_mode;
>> }
>>
>> @@ -369,7 +368,6 @@ static int lm3639_probe(struct i2c_client *client,
>> &client->dev, &pchip->cdev_flash);
>> if (ret < 0) {
>> dev_err(&client->dev, "fail : flash register\n");
>> - ret = -EIO;
>> goto err_flash;
>> }
>>
>> @@ -381,7 +379,6 @@ static int lm3639_probe(struct i2c_client *client,
>> &client->dev, &pchip->cdev_torch);
>> if (ret < 0) {
>> dev_err(&client->dev, "fail : torch register\n");
>> - ret = -EIO;
>> goto err_torch;
>> }
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
Thank you. This patch looks good for us.
lm3630 has same thing and I will fix it.
Acked-by: Daniel Jeong <daniel.jeong@ti.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-01-02 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 18:18 [PATCH] backlight: lm3649_backlight: remove ret = -EIO at error paths of probe Devendra Naga
2013-01-01 23:47 ` Jingoo Han
2013-01-02 8:07 ` gshark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E3EAC9.9070705@gmail.com \
--to=gshark.jeong@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.