[PATCH] backlight: lm3649_backlight: remove ret = -EIO at error paths of probe

[PATCH] backlight: lm3649_backlight: remove ret = -EIO at error paths of probe

[Devendra Naga]

the APIs are returning correctly the err codes, no need of assigning -EIO to the
ret again

Cc: Daniel Jeong <daniel.jeong@ti.com>
Cc: G.Shark Jeong <gshark.jeong@gmail.com>
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
 drivers/video/backlight/lm3639_bl.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
index 7ab2d2a..053964d 100644
--- a/drivers/video/backlight/lm3639_bl.c
+++ b/drivers/video/backlight/lm3639_bl.c
@@ -350,14 +350,13 @@ static int lm3639_probe(struct i2c_client *client,
 				      &lm3639_bled_ops, &props);
 	if (IS_ERR(pchip->bled)) {
 		dev_err(&client->dev, "fail : backlight register\n");
-		ret = -EIO;
+		ret = PTR_ERR(pchip->bled);
 		goto err_out;
 	}
 
 	ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode);
 	if (ret < 0) {
 		dev_err(&client->dev, "failed : add sysfs entries\n");
-		ret = -EIO;
 		goto err_bled_mode;
 	}
 
@@ -369,7 +368,6 @@ static int lm3639_probe(struct i2c_client *client,
 				    &client->dev, &pchip->cdev_flash);
 	if (ret < 0) {
 		dev_err(&client->dev, "fail : flash register\n");
-		ret = -EIO;
 		goto err_flash;
 	}
 
@@ -381,7 +379,6 @@ static int lm3639_probe(struct i2c_client *client,
 				    &client->dev, &pchip->cdev_torch);
 	if (ret < 0) {
 		dev_err(&client->dev, "fail : torch register\n");
-		ret = -EIO;
 		goto err_torch;
 	}
 
-- 
1.7.10.4

Re: [PATCH] backlight: lm3649_backlight: remove ret = -EIO at error paths of probe

[Jingoo Han]

T24gVHVlc2RheSwgSmFudWFyeSAwMSwgMjAxMyAzOjE5IEFNLCBEZXZlbmRyYSBOYWdhIHdyb3Rl
DQo+IHRoZSBBUElzIGFyZSByZXR1cm5pbmcgY29ycmVjdGx5IHRoZSBlcnIgY29kZXMsIG5vIG5l
ZWQgb2YgYXNzaWduaW5nIC1FSU8gdG8gdGhlDQo+IHJldCBhZ2Fpbg0KPiANCj4gQ2M6IERhbmll
bCBKZW9uZyA8ZGFuaWVsLmplb25nQHRpLmNvbT4NCj4gQ2M6IEcuU2hhcmsgSmVvbmcgPGdzaGFy
ay5qZW9uZ0BnbWFpbC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IERldmVuZHJhIE5hZ2EgPGRldmVu
ZHJhLmFhcnVAZ21haWwuY29tPg0KDQpJdCBsb29rcyBnb29kLg0KQWNrZWQtYnk6IEppbmdvbyBI
YW4gPGpnMS5oYW5Ac2Ftc3VuZy5jb20+DQoNCg0KQmVzdCByZWdhcmRzLA0KSmluZ29vIEhhbg0K
DQo+IC0tLQ0KPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG0zNjM5X2JsLmMgfCAgICA1ICst
LS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDQgZGVsZXRpb25zKC0pDQo+
IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG0zNjM5X2JsLmMgYi9k
cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9sbTM2MzlfYmwuYw0KPiBpbmRleCA3YWIyZDJhLi4wNTM5
NjRkIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9sbTM2MzlfYmwuYw0K
PiArKysgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9sbTM2MzlfYmwuYw0KPiBAQCAtMzUwLDE0
ICszNTAsMTMgQEAgc3RhdGljIGludCBsbTM2MzlfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNs
aWVudCwNCj4gIAkJCQkgICAgICAmbG0zNjM5X2JsZWRfb3BzLCAmcHJvcHMpOw0KPiAgCWlmIChJ
U19FUlIocGNoaXAtPmJsZWQpKSB7DQo+ICAJCWRldl9lcnIoJmNsaWVudC0+ZGV2LCAiZmFpbCA6
IGJhY2tsaWdodCByZWdpc3RlclxuIik7DQo+IC0JCXJldCA9IC1FSU87DQo+ICsJCXJldCA9IFBU
Ul9FUlIocGNoaXAtPmJsZWQpOw0KPiAgCQlnb3RvIGVycl9vdXQ7DQo+ICAJfQ0KPiANCj4gIAly
ZXQgPSBkZXZpY2VfY3JlYXRlX2ZpbGUoJihwY2hpcC0+YmxlZC0+ZGV2KSwgJmRldl9hdHRyX2Js
ZWRfbW9kZSk7DQo+ICAJaWYgKHJldCA8IDApIHsNCj4gIAkJZGV2X2VycigmY2xpZW50LT5kZXYs
ICJmYWlsZWQgOiBhZGQgc3lzZnMgZW50cmllc1xuIik7DQo+IC0JCXJldCA9IC1FSU87DQo+ICAJ
CWdvdG8gZXJyX2JsZWRfbW9kZTsNCj4gIAl9DQo+IA0KPiBAQCAtMzY5LDcgKzM2OCw2IEBAIHN0
YXRpYyBpbnQgbG0zNjM5X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsDQo+ICAJCQkJ
ICAgICZjbGllbnQtPmRldiwgJnBjaGlwLT5jZGV2X2ZsYXNoKTsNCj4gIAlpZiAocmV0IDwgMCkg
ew0KPiAgCQlkZXZfZXJyKCZjbGllbnQtPmRldiwgImZhaWwgOiBmbGFzaCByZWdpc3RlclxuIik7
DQo+IC0JCXJldCA9IC1FSU87DQo+ICAJCWdvdG8gZXJyX2ZsYXNoOw0KPiAgCX0NCj4gDQo+IEBA
IC0zODEsNyArMzc5LDYgQEAgc3RhdGljIGludCBsbTM2MzlfcHJvYmUoc3RydWN0IGkyY19jbGll
bnQgKmNsaWVudCwNCj4gIAkJCQkgICAgJmNsaWVudC0+ZGV2LCAmcGNoaXAtPmNkZXZfdG9yY2gp
Ow0KPiAgCWlmIChyZXQgPCAwKSB7DQo+ICAJCWRldl9lcnIoJmNsaWVudC0+ZGV2LCAiZmFpbCA6
IHRvcmNoIHJlZ2lzdGVyXG4iKTsNCj4gLQkJcmV0ID0gLUVJTzsNCj4gIAkJZ290byBlcnJfdG9y
Y2g7DQo+ICAJfQ0KPiANCj4gLS0NCj4gMS43LjEwLjQNCj4gDQo+IC0tDQo+IFRvIHVuc3Vic2Ny
aWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1mYmRl
diIgaW4NCj4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5v
cmcNCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpv
cmRvbW8taW5mby5odG1sDQo

Re: [PATCH] backlight: lm3649_backlight: remove ret = -EIO at error paths of probe

[gshark]

2013년 01월 02일 08:47, Jingoo Han 쓴 글:
> On Tuesday, January 01, 2013 3:19 AM, Devendra Naga wrote
>> the APIs are returning correctly the err codes, no need of assigning -EIO to the
>> ret again
>>
>> Cc: Daniel Jeong <daniel.jeong@ti.com>
>> Cc: G.Shark Jeong <gshark.jeong@gmail.com>
>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> It looks good.
> Acked-by: Jingoo Han <jg1.han@samsung.com>
>
>
> Best regards,
> Jingoo Han
>
>> ---
>>  drivers/video/backlight/lm3639_bl.c |    5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
>> index 7ab2d2a..053964d 100644
>> --- a/drivers/video/backlight/lm3639_bl.c
>> +++ b/drivers/video/backlight/lm3639_bl.c
>> @@ -350,14 +350,13 @@ static int lm3639_probe(struct i2c_client *client,
>>  				      &lm3639_bled_ops, &props);
>>  	if (IS_ERR(pchip->bled)) {
>>  		dev_err(&client->dev, "fail : backlight register\n");
>> -		ret = -EIO;
>> +		ret = PTR_ERR(pchip->bled);
>>  		goto err_out;
>>  	}
>>
>>  	ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode);
>>  	if (ret < 0) {
>>  		dev_err(&client->dev, "failed : add sysfs entries\n");
>> -		ret = -EIO;
>>  		goto err_bled_mode;
>>  	}
>>
>> @@ -369,7 +368,6 @@ static int lm3639_probe(struct i2c_client *client,
>>  				    &client->dev, &pchip->cdev_flash);
>>  	if (ret < 0) {
>>  		dev_err(&client->dev, "fail : flash register\n");
>> -		ret = -EIO;
>>  		goto err_flash;
>>  	}
>>
>> @@ -381,7 +379,6 @@ static int lm3639_probe(struct i2c_client *client,
>>  				    &client->dev, &pchip->cdev_torch);
>>  	if (ret < 0) {
>>  		dev_err(&client->dev, "fail : torch register\n");
>> -		ret = -EIO;
>>  		goto err_torch;
>>  	}
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thank you. This patch looks good for us.
lm3630 has same thing and I will fix it.

Acked-by: Daniel Jeong <daniel.jeong@ti.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html