From: Sergei Shtylyov <sshtylyov@mvista.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: davinci-linux-open-source@linux.davincidsp.com,
devicetree-discuss@lists.ozlabs.org,
Grant Likely <grant.likely@secretlab.ca>,
linux-mtd@lists.infradead.org,
Scott Wood <scottwood@freescale.com>,
hs@denx.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller
Date: Thu, 03 Jan 2013 15:39:08 +0400 [thread overview]
Message-ID: <50E56DDC.8060804@mvista.com> (raw)
In-Reply-To: <1357212752.16197.127.camel@shinybook.infradead.org>
Hello.
On 03-01-2013 15:32, David Woodhouse wrote:
>>>>> +#if defined(CONFIG_OF)
>>>>> +static const struct of_device_id davinci_nand_of_match[] = {
>>>>> + {.compatible = "ti,davinci-nand", },
>>>>> + {},
>>>>> +}
>>>>> +MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>>> Hmm.. maybe this crept in later after I sent the patches? They were
>>> pending for a while ... I compiled it just yet again (based on my
>>> tree when I posted this patch based on commit:
>> I've just checked the archives: every patch version you posted had ';'
>> after '}' missing.
> If it was built-in, rather than as a module, then MODULE_DEVICE_TABLE(…)
> expands to nothing, and the structure gets to use the semicolon from the
> end of that line.
Ah, that explains it: 'davinci_all_defconfig' has
CONFIG_MTD_NAND_DAVINCI=m, so that's how the error got triggered at last.
Probably worth adding this explanation to the changelog, how do you think?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller
Date: Thu, 03 Jan 2013 15:39:08 +0400 [thread overview]
Message-ID: <50E56DDC.8060804@mvista.com> (raw)
In-Reply-To: <1357212752.16197.127.camel@shinybook.infradead.org>
Hello.
On 03-01-2013 15:32, David Woodhouse wrote:
>>>>> +#if defined(CONFIG_OF)
>>>>> +static const struct of_device_id davinci_nand_of_match[] = {
>>>>> + {.compatible = "ti,davinci-nand", },
>>>>> + {},
>>>>> +}
>>>>> +MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>>> Hmm.. maybe this crept in later after I sent the patches? They were
>>> pending for a while ... I compiled it just yet again (based on my
>>> tree when I posted this patch based on commit:
>> I've just checked the archives: every patch version you posted had ';'
>> after '}' missing.
> If it was built-in, rather than as a module, then MODULE_DEVICE_TABLE(?)
> expands to nothing, and the structure gets to use the semicolon from the
> end of that line.
Ah, that explains it: 'davinci_all_defconfig' has
CONFIG_MTD_NAND_DAVINCI=m, so that's how the error got triggered at last.
Probably worth adding this explanation to the changelog, how do you think?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
hs-ynQEQJNshbs@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller
Date: Thu, 03 Jan 2013 15:39:08 +0400 [thread overview]
Message-ID: <50E56DDC.8060804@mvista.com> (raw)
In-Reply-To: <1357212752.16197.127.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
Hello.
On 03-01-2013 15:32, David Woodhouse wrote:
>>>>> +#if defined(CONFIG_OF)
>>>>> +static const struct of_device_id davinci_nand_of_match[] = {
>>>>> + {.compatible = "ti,davinci-nand", },
>>>>> + {},
>>>>> +}
>>>>> +MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>>> Hmm.. maybe this crept in later after I sent the patches? They were
>>> pending for a while ... I compiled it just yet again (based on my
>>> tree when I posted this patch based on commit:
>> I've just checked the archives: every patch version you posted had ';'
>> after '}' missing.
> If it was built-in, rather than as a module, then MODULE_DEVICE_TABLE(…)
> expands to nothing, and the structure gets to use the semicolon from the
> end of that line.
Ah, that explains it: 'davinci_all_defconfig' has
CONFIG_MTD_NAND_DAVINCI=m, so that's how the error got triggered at last.
Probably worth adding this explanation to the changelog, how do you think?
WBR, Sergei
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2013-01-03 11:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 7:22 [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller Heiko Schocher
2012-07-30 7:22 ` Heiko Schocher
2012-07-30 7:22 ` Heiko Schocher
2012-08-07 14:34 ` Heiko Schocher
2012-08-07 14:34 ` Heiko Schocher
2012-08-07 14:34 ` Heiko Schocher
2012-08-07 17:36 ` Sekhar Nori
2012-08-07 17:36 ` Sekhar Nori
2012-08-07 17:36 ` Sekhar Nori
2012-08-23 15:34 ` Artem Bityutskiy
2012-08-23 15:34 ` Artem Bityutskiy
2012-08-23 15:34 ` Artem Bityutskiy
2013-01-02 19:43 ` Sergei Shtylyov
2013-01-02 19:43 ` Sergei Shtylyov
2013-01-02 19:43 ` Sergei Shtylyov
2013-01-03 7:03 ` Heiko Schocher
2013-01-03 7:03 ` Heiko Schocher
2013-01-03 7:03 ` Heiko Schocher
2013-01-03 11:26 ` Sergei Shtylyov
2013-01-03 11:26 ` Sergei Shtylyov
2013-01-03 11:26 ` Sergei Shtylyov
2013-01-03 11:32 ` David Woodhouse
2013-01-03 11:32 ` David Woodhouse
2013-01-03 11:32 ` David Woodhouse
2013-01-03 11:39 ` Sergei Shtylyov [this message]
2013-01-03 11:39 ` Sergei Shtylyov
2013-01-03 11:39 ` Sergei Shtylyov
2013-01-03 17:56 ` Sergei Shtylyov
2013-01-03 17:56 ` Sergei Shtylyov
2013-01-03 17:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E56DDC.8060804@mvista.com \
--to=sshtylyov@mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=hs@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.