From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 1/4] switch debugcon to memory api
Date: Sun, 06 Jan 2013 19:03:14 +0100 [thread overview]
Message-ID: <50E9BC62.6000509@suse.de> (raw)
In-Reply-To: <1357287364-24921-2-git-send-email-kraxel@redhat.com>
Am 04.01.2013 09:16, schrieb Gerd Hoffmann:
> Also some QOM glue while being at it.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/debugcon.c | 31 ++++++++++++++++++++++++-------
> 1 files changed, 24 insertions(+), 7 deletions(-)
>
> diff --git a/hw/debugcon.c b/hw/debugcon.c
> index 14f83f1..e8a855e 100644
> --- a/hw/debugcon.c
> +++ b/hw/debugcon.c
> @@ -29,20 +29,27 @@
> #include "isa.h"
> #include "pc.h"
>
> +#define TYPE_ISA_DEBUGCON_DEVICE "isa-debugcon"
> +#define ISA_DEBUGCON_DEVICE(obj) \
> + OBJECT_CHECK(ISADebugconState, (obj), TYPE_ISA_DEBUGCON_DEVICE)
Note that my previous QOM'ification RFC used the more verbose
[TYPE_]ISA_DEBUG_CONSOLE to avoid the "debugcon" abbreviation. Care to
cleanup?
Otherwise looks good, thanks, and would've got a Reviewed-by had you not
rushed to send a PULL.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-01-06 18:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 8:16 [Qemu-devel] [PULL 0/4] test and debug devices Gerd Hoffmann
2013-01-04 8:16 ` [Qemu-devel] [PATCH 1/4] switch debugcon to memory api Gerd Hoffmann
2013-01-06 18:03 ` Andreas Färber [this message]
2013-01-04 8:16 ` [Qemu-devel] [PATCH 2/4] add isa-debug-exit device Gerd Hoffmann
2013-01-04 8:16 ` [Qemu-devel] [PATCH 3/4] hw: Add test device for unittests execution Gerd Hoffmann
2013-01-04 21:44 ` Stefan Weil
2013-01-04 22:38 ` Alexander Graf
2013-01-06 18:19 ` Andreas Färber
2013-01-04 8:16 ` [Qemu-devel] [PATCH 4/4] pc: remove bochs bios debug ports Gerd Hoffmann
2013-01-04 10:28 ` [Qemu-devel] [PULL 0/4] test and debug devices Andreas Färber
2013-01-04 12:57 ` Gerd Hoffmann
2013-01-04 13:07 ` Andreas Färber
2013-01-04 13:45 ` Anthony Liguori
2013-01-04 20:21 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E9BC62.6000509@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.