All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Prashant Gaikwad
	<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH v2 01/10] spi: tegra: Do not use clock name to get clock
Date: Fri, 11 Jan 2013 13:58:28 -0700	[thread overview]
Message-ID: <50F07CF4.2090502@wwwdotorg.org> (raw)
In-Reply-To: <1357891289-23500-1-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 01/11/2013 01:01 AM, Prashant Gaikwad wrote:
> Since Tegra spi devices do not have multiple clocks, no need to use
> clock name to get the clock.

Cc'ing in the SPI maintainers as an FYI and for Acks; this patch needs
to go through the Tegra tree due to dependencies.

> Signed-off-by: Prashant Gaikwad <pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> This series depends on v4 of Tegra's ccf-rework patch series.
> Tested on Ventana (Tegra20) and Cardhu (Tegra30).
> Rebased on Tegra's for-3.9/soc and for-3.9/cleanup.
> 
> Changes from V1:
> - Fixed clock lookup for SPI and nvec drivers.
> - Add clock information for nvec in device tree.
> ---
>  drivers/spi/spi-tegra20-sflash.c |    2 +-
>  drivers/spi/spi-tegra20-slink.c  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
> index 02feaa5..e5dce91 100644
> --- a/drivers/spi/spi-tegra20-sflash.c
> +++ b/drivers/spi/spi-tegra20-sflash.c
> @@ -525,7 +525,7 @@ static int tegra_sflash_probe(struct platform_device *pdev)
>  		goto exit_free_master;
>  	}
>  
> -	tsd->clk = devm_clk_get(&pdev->dev, "spi");
> +	tsd->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(tsd->clk)) {
>  		dev_err(&pdev->dev, "can not get clock\n");
>  		ret = PTR_ERR(tsd->clk);
> diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
> index fa208a5..e255e7a 100644
> --- a/drivers/spi/spi-tegra20-slink.c
> +++ b/drivers/spi/spi-tegra20-slink.c
> @@ -1191,7 +1191,7 @@ static int tegra_slink_probe(struct platform_device *pdev)
>  		goto exit_free_master;
>  	}
>  
> -	tspi->clk = devm_clk_get(&pdev->dev, "slink");
> +	tspi->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(tspi->clk)) {
>  		dev_err(&pdev->dev, "can not get clock\n");
>  		ret = PTR_ERR(tspi->clk);
> 

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/10] spi: tegra: Do not use clock name to get clock
Date: Fri, 11 Jan 2013 13:58:28 -0700	[thread overview]
Message-ID: <50F07CF4.2090502@wwwdotorg.org> (raw)
In-Reply-To: <1357891289-23500-1-git-send-email-pgaikwad@nvidia.com>

On 01/11/2013 01:01 AM, Prashant Gaikwad wrote:
> Since Tegra spi devices do not have multiple clocks, no need to use
> clock name to get the clock.

Cc'ing in the SPI maintainers as an FYI and for Acks; this patch needs
to go through the Tegra tree due to dependencies.

> Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
> ---
> This series depends on v4 of Tegra's ccf-rework patch series.
> Tested on Ventana (Tegra20) and Cardhu (Tegra30).
> Rebased on Tegra's for-3.9/soc and for-3.9/cleanup.
> 
> Changes from V1:
> - Fixed clock lookup for SPI and nvec drivers.
> - Add clock information for nvec in device tree.
> ---
>  drivers/spi/spi-tegra20-sflash.c |    2 +-
>  drivers/spi/spi-tegra20-slink.c  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
> index 02feaa5..e5dce91 100644
> --- a/drivers/spi/spi-tegra20-sflash.c
> +++ b/drivers/spi/spi-tegra20-sflash.c
> @@ -525,7 +525,7 @@ static int tegra_sflash_probe(struct platform_device *pdev)
>  		goto exit_free_master;
>  	}
>  
> -	tsd->clk = devm_clk_get(&pdev->dev, "spi");
> +	tsd->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(tsd->clk)) {
>  		dev_err(&pdev->dev, "can not get clock\n");
>  		ret = PTR_ERR(tsd->clk);
> diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
> index fa208a5..e255e7a 100644
> --- a/drivers/spi/spi-tegra20-slink.c
> +++ b/drivers/spi/spi-tegra20-slink.c
> @@ -1191,7 +1191,7 @@ static int tegra_slink_probe(struct platform_device *pdev)
>  		goto exit_free_master;
>  	}
>  
> -	tspi->clk = devm_clk_get(&pdev->dev, "slink");
> +	tspi->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(tspi->clk)) {
>  		dev_err(&pdev->dev, "can not get clock\n");
>  		ret = PTR_ERR(tspi->clk);
> 

  parent reply	other threads:[~2013-01-11 20:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11  8:01 [PATCH v2 01/10] spi: tegra: Do not use clock name to get clock Prashant Gaikwad
2013-01-11  8:01 ` Prashant Gaikwad
     [not found] ` <1357891289-23500-1-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11  8:01   ` [PATCH v2 02/10] ARM: dt: tegra20: Add clock information Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 03/10] ARM: dt: tegra30: " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
     [not found]     ` <1357891289-23500-3-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16  8:01       ` Terje Bergström
2013-01-16  8:01         ` Terje Bergström
     [not found]         ` <50F65E4B.8040409-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16 17:28           ` Stephen Warren
2013-01-16 17:28             ` Stephen Warren
     [not found]             ` <50F6E32F.80602-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-17  6:33               ` Terje Bergström
2013-01-17  6:33                 ` Terje Bergström
2013-01-11  8:01   ` [PATCH v2 04/10] ARM: dt: tegra: paz00: add " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 05/10] staging: nvec: remove use of clk_get_sys Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 06/10] ASoC: tegra: remove auxdata Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
     [not found]     ` <1357891289-23500-6-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 20:59       ` Stephen Warren
2013-01-11 20:59         ` Stephen Warren
     [not found]         ` <50F07D30.9020102-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-11 21:05           ` Mark Brown
2013-01-11 21:05             ` Mark Brown
2013-01-11  8:01   ` [PATCH v2 07/10] arm: tegra20: " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 08/10] arm: tegra30: " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 09/10] clk: tegra20: remove unused TEGRA_CLK_DUPLICATE()s Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
     [not found]     ` <1357891289-23500-9-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 21:00       ` Stephen Warren
2013-01-11 21:00         ` Stephen Warren
2013-01-14 20:56         ` Mike Turquette
2013-01-14 20:56           ` Mike Turquette
2013-01-11  8:01   ` [PATCH v2 10/10] clk: tegra30: " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
     [not found]     ` <1357891289-23500-10-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 21:01       ` Stephen Warren
2013-01-11 21:01         ` Stephen Warren
2013-01-14 20:58         ` Mike Turquette
2013-01-14 20:58           ` Mike Turquette
2013-01-11 20:58   ` Stephen Warren [this message]
2013-01-11 20:58     ` [PATCH v2 01/10] spi: tegra: Do not use clock name to get clock Stephen Warren
     [not found]     ` <50F07CF4.2090502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-14 20:17       ` Grant Likely
2013-01-14 20:17         ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F07CF4.2090502@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.