All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Prashant Gaikwad
	<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org"
	<alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>
Subject: Re: [PATCH v2 06/10] ASoC: tegra: remove auxdata
Date: Fri, 11 Jan 2013 13:59:28 -0700	[thread overview]
Message-ID: <50F07D30.9020102@wwwdotorg.org> (raw)
In-Reply-To: <1357891289-23500-6-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 01/11/2013 01:01 AM, Prashant Gaikwad wrote:
> Configlink clock information is added to device tree. Get the clocks
> using device node. Remove AUXDATA.

Cc'ing in the ASoC maintainers as an FYI and for Acks; this patch needs
to go through the Tegra tree due to dependencies.

> 
> Signed-off-by: Prashant Gaikwad <pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  sound/soc/tegra/tegra30_ahub.c |   14 ++------------
>  1 files changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
> index bb31c41..2355630 100644
> --- a/sound/soc/tegra/tegra30_ahub.c
> +++ b/sound/soc/tegra/tegra30_ahub.c
> @@ -299,15 +299,6 @@ static const char * const configlink_clocks[] = {
>  	"spdif_in",
>  };
>  
> -struct of_dev_auxdata ahub_auxdata[] = {
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080300, "tegra30-i2s.0", NULL),
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080400, "tegra30-i2s.1", NULL),
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080500, "tegra30-i2s.2", NULL),
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080600, "tegra30-i2s.3", NULL),
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080700, "tegra30-i2s.4", NULL),
> -	{}
> -};
> -
>  #define LAST_REG(name) \
>  	(TEGRA30_AHUB_##name + \
>  	 (TEGRA30_AHUB_##name##_STRIDE * TEGRA30_AHUB_##name##_COUNT) - 4)
> @@ -451,7 +442,7 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
>  	 * Ensure that here.
>  	 */
>  	for (i = 0; i < ARRAY_SIZE(configlink_clocks); i++) {
> -		clk = clk_get_sys(NULL, configlink_clocks[i]);
> +		clk = clk_get(&pdev->dev, configlink_clocks[i]);
>  		if (IS_ERR(clk)) {
>  			dev_err(&pdev->dev, "Can't get clock %s\n",
>  				configlink_clocks[i]);
> @@ -569,8 +560,7 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
>  			goto err_pm_disable;
>  	}
>  
> -	of_platform_populate(pdev->dev.of_node, NULL, ahub_auxdata,
> -			     &pdev->dev);
> +	of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
>  
>  	return 0;
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 06/10] ASoC: tegra: remove auxdata
Date: Fri, 11 Jan 2013 13:59:28 -0700	[thread overview]
Message-ID: <50F07D30.9020102@wwwdotorg.org> (raw)
In-Reply-To: <1357891289-23500-6-git-send-email-pgaikwad@nvidia.com>

On 01/11/2013 01:01 AM, Prashant Gaikwad wrote:
> Configlink clock information is added to device tree. Get the clocks
> using device node. Remove AUXDATA.

Cc'ing in the ASoC maintainers as an FYI and for Acks; this patch needs
to go through the Tegra tree due to dependencies.

> 
> Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
> ---
>  sound/soc/tegra/tegra30_ahub.c |   14 ++------------
>  1 files changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
> index bb31c41..2355630 100644
> --- a/sound/soc/tegra/tegra30_ahub.c
> +++ b/sound/soc/tegra/tegra30_ahub.c
> @@ -299,15 +299,6 @@ static const char * const configlink_clocks[] = {
>  	"spdif_in",
>  };
>  
> -struct of_dev_auxdata ahub_auxdata[] = {
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080300, "tegra30-i2s.0", NULL),
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080400, "tegra30-i2s.1", NULL),
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080500, "tegra30-i2s.2", NULL),
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080600, "tegra30-i2s.3", NULL),
> -	OF_DEV_AUXDATA("nvidia,tegra30-i2s", 0x70080700, "tegra30-i2s.4", NULL),
> -	{}
> -};
> -
>  #define LAST_REG(name) \
>  	(TEGRA30_AHUB_##name + \
>  	 (TEGRA30_AHUB_##name##_STRIDE * TEGRA30_AHUB_##name##_COUNT) - 4)
> @@ -451,7 +442,7 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
>  	 * Ensure that here.
>  	 */
>  	for (i = 0; i < ARRAY_SIZE(configlink_clocks); i++) {
> -		clk = clk_get_sys(NULL, configlink_clocks[i]);
> +		clk = clk_get(&pdev->dev, configlink_clocks[i]);
>  		if (IS_ERR(clk)) {
>  			dev_err(&pdev->dev, "Can't get clock %s\n",
>  				configlink_clocks[i]);
> @@ -569,8 +560,7 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
>  			goto err_pm_disable;
>  	}
>  
> -	of_platform_populate(pdev->dev.of_node, NULL, ahub_auxdata,
> -			     &pdev->dev);
> +	of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
>  
>  	return 0;
>  
> 

  parent reply	other threads:[~2013-01-11 20:59 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11  8:01 [PATCH v2 01/10] spi: tegra: Do not use clock name to get clock Prashant Gaikwad
2013-01-11  8:01 ` Prashant Gaikwad
     [not found] ` <1357891289-23500-1-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11  8:01   ` [PATCH v2 02/10] ARM: dt: tegra20: Add clock information Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 03/10] ARM: dt: tegra30: " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
     [not found]     ` <1357891289-23500-3-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16  8:01       ` Terje Bergström
2013-01-16  8:01         ` Terje Bergström
     [not found]         ` <50F65E4B.8040409-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16 17:28           ` Stephen Warren
2013-01-16 17:28             ` Stephen Warren
     [not found]             ` <50F6E32F.80602-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-17  6:33               ` Terje Bergström
2013-01-17  6:33                 ` Terje Bergström
2013-01-11  8:01   ` [PATCH v2 04/10] ARM: dt: tegra: paz00: add " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 05/10] staging: nvec: remove use of clk_get_sys Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 06/10] ASoC: tegra: remove auxdata Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
     [not found]     ` <1357891289-23500-6-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 20:59       ` Stephen Warren [this message]
2013-01-11 20:59         ` Stephen Warren
     [not found]         ` <50F07D30.9020102-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-11 21:05           ` Mark Brown
2013-01-11 21:05             ` Mark Brown
2013-01-11  8:01   ` [PATCH v2 07/10] arm: tegra20: " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 08/10] arm: tegra30: " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
2013-01-11  8:01   ` [PATCH v2 09/10] clk: tegra20: remove unused TEGRA_CLK_DUPLICATE()s Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
     [not found]     ` <1357891289-23500-9-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 21:00       ` Stephen Warren
2013-01-11 21:00         ` Stephen Warren
2013-01-14 20:56         ` Mike Turquette
2013-01-14 20:56           ` Mike Turquette
2013-01-11  8:01   ` [PATCH v2 10/10] clk: tegra30: " Prashant Gaikwad
2013-01-11  8:01     ` Prashant Gaikwad
     [not found]     ` <1357891289-23500-10-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 21:01       ` Stephen Warren
2013-01-11 21:01         ` Stephen Warren
2013-01-14 20:58         ` Mike Turquette
2013-01-14 20:58           ` Mike Turquette
2013-01-11 20:58   ` [PATCH v2 01/10] spi: tegra: Do not use clock name to get clock Stephen Warren
2013-01-11 20:58     ` Stephen Warren
     [not found]     ` <50F07CF4.2090502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-14 20:17       ` Grant Likely
2013-01-14 20:17         ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F07D30.9020102@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lrg-l0cyMroinI0@public.gmane.org \
    --cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.