All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Thomas Schlichter <thomas.schlichter@web.de>
Cc: "Len Brown" <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	"Andreas Müller" <goo@stapelspeicher.org>,
	"Julius Werner" <jwerner@chromium.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: fix new C-states not functional after AC disconnect
Date: Sun, 13 Jan 2013 15:41:34 +0100	[thread overview]
Message-ID: <50F2C79E.5000302@linaro.org> (raw)
In-Reply-To: <2099093.cPXO6Nhn9v@netbook>

On 01/13/2013 01:34 PM, Thomas Schlichter wrote:
> Hi,
> 
> there is a long-standing regression about new C-states not working after 
> disconnecting AC power from a laptop if the cpuidle driver "acpi-idle" is 
> used. It was reported here:
> 
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=42870  (March 5th 2012)
> [2] https://bugzilla.kernel.org/show_bug.cgi?id=43349  (June 7th 2012)
> [3] https://lkml.org/lkml/2012/10/16/518   (October 19th 2012)
> 
> In [1] Andreas proposed a patch that initialized the missing power_usage 
> values from within acpi_idle in the same way as cpuidle does.
> In [2] I proposed a patch to use the power values provided by ACPI to 
> initialize the power_usage variables.
> In [3] Julius proposed a patch to call the initialization function 
> set_power_states()  not only once, but always when the C-states change.
> 
> Currently, Daniel Lezcano seems to be working on an intrusive change of not 
> using the power_usage value at all for choosing a C-state:
> 
> [4] https://lkml.org/lkml/2012/12/14/155
> 
> As I could not find any of these patches in any git trees to be merged for 
> 3.8, I propose an other, least intrusive patch for the time being. It is 
> attached an initializes _all_ power_usage values in the first place.
> 
> As this is a real power consumption regression since 3.2, I really ask you to 
> apply anything and push it to stable, too!

Rafael, is possible to apply the patch [1/2] I previously sent ?

https://patchwork.kernel.org/patch/1878691/

So we get this bug fixed.

I will resend the patch [2/2] as soon as possible.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Thomas Schlichter <thomas.schlichter@web.de>
Cc: "Len Brown" <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	"Andreas Müller" <goo@stapelspeicher.org>,
	"Julius Werner" <jwerner@chromium.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: fix new C-states not functional after AC disconnect
Date: Sun, 13 Jan 2013 15:41:34 +0100	[thread overview]
Message-ID: <50F2C79E.5000302@linaro.org> (raw)
In-Reply-To: <2099093.cPXO6Nhn9v@netbook>

On 01/13/2013 01:34 PM, Thomas Schlichter wrote:
> Hi,
> 
> there is a long-standing regression about new C-states not working after 
> disconnecting AC power from a laptop if the cpuidle driver "acpi-idle" is 
> used. It was reported here:
> 
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=42870  (March 5th 2012)
> [2] https://bugzilla.kernel.org/show_bug.cgi?id=43349  (June 7th 2012)
> [3] https://lkml.org/lkml/2012/10/16/518   (October 19th 2012)
> 
> In [1] Andreas proposed a patch that initialized the missing power_usage 
> values from within acpi_idle in the same way as cpuidle does.
> In [2] I proposed a patch to use the power values provided by ACPI to 
> initialize the power_usage variables.
> In [3] Julius proposed a patch to call the initialization function 
> set_power_states()  not only once, but always when the C-states change.
> 
> Currently, Daniel Lezcano seems to be working on an intrusive change of not 
> using the power_usage value at all for choosing a C-state:
> 
> [4] https://lkml.org/lkml/2012/12/14/155
> 
> As I could not find any of these patches in any git trees to be merged for 
> 3.8, I propose an other, least intrusive patch for the time being. It is 
> attached an initializes _all_ power_usage values in the first place.
> 
> As this is a real power consumption regression since 3.2, I really ask you to 
> apply anything and push it to stable, too!

Rafael, is possible to apply the patch [1/2] I previously sent ?

https://patchwork.kernel.org/patch/1878691/

So we get this bug fixed.

I will resend the patch [2/2] as soon as possible.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2013-01-13 14:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 12:34 [PATCH] cpuidle: fix new C-states not functional after AC disconnect Thomas Schlichter
2013-01-13 14:41 ` Daniel Lezcano [this message]
2013-01-13 14:41   ` Daniel Lezcano
2013-01-13 20:04   ` Rafael J. Wysocki
2013-01-18 20:34     ` Thomas Schlichter
2013-01-18 22:24       ` Thomas Schlichter
2013-01-31  3:52     ` Julius Werner
2013-01-31 13:21       ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2013-01-13 19:30 Sedat Dilek
2013-01-13 20:36 ` Sedat Dilek
2013-01-13 20:44   ` Daniel Lezcano
2013-01-13 20:44     ` Daniel Lezcano
2013-01-13 20:49     ` Sedat Dilek
2013-01-30 20:23     ` Thomas Schlichter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F2C79E.5000302@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=goo@stapelspeicher.org \
    --cc=jwerner@chromium.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=rjw@sisk.pl \
    --cc=thomas.schlichter@web.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.