From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board
Date: Tue, 15 Jan 2013 10:58:30 -0300 [thread overview]
Message-ID: <50F56086.2040101@free-electrons.com> (raw)
In-Reply-To: <201301151307.26665.arnd@arndb.de>
Hi Arnd,
On 01/15/2013 10:07 AM, Arnd Bergmann wrote:
> On Tuesday 15 January 2013, Ezequiel Garcia wrote:
>> Cc: Lior Amsalem <alior@marvell.com>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>
> The patches look good, but when you have four trivial patches
> doing the same thing in different files, and you decide that it's
> not worth writing a changelog for them, they should probably
> go into a single patch.
>
Mmm... maybe you're right and such splitting is excessive.
It seemed tidier this way, enabling each board on a different patch.
I can squash them on a v2, if you want me to.
Thanks for reviewing!
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Florian Fainelli
<florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Yehuda Yitschak <yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Michael Opdenacker
<michael.opdenacker-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board
Date: Tue, 15 Jan 2013 10:58:30 -0300 [thread overview]
Message-ID: <50F56086.2040101@free-electrons.com> (raw)
In-Reply-To: <201301151307.26665.arnd-r2nGTMty4D4@public.gmane.org>
Hi Arnd,
On 01/15/2013 10:07 AM, Arnd Bergmann wrote:
> On Tuesday 15 January 2013, Ezequiel Garcia wrote:
>> Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
>> Cc: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>> Cc: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>
> The patches look good, but when you have four trivial patches
> doing the same thing in different files, and you decide that it's
> not worth writing a changelog for them, they should probably
> go into a single patch.
>
Mmm... maybe you're right and such splitting is excessive.
It seemed tidier this way, enabling each board on a different patch.
I can squash them on a v2, if you want me to.
Thanks for reviewing!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-15 13:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 9:54 [PATCH 1/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP Ezequiel Garcia
2013-01-15 9:54 ` Ezequiel Garcia
2013-01-15 9:54 ` [PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board Ezequiel Garcia
2013-01-15 9:54 ` Ezequiel Garcia
2013-01-15 13:07 ` Arnd Bergmann
2013-01-15 13:07 ` Arnd Bergmann
2013-01-15 13:58 ` Ezequiel Garcia [this message]
2013-01-15 13:58 ` Ezequiel Garcia
2013-01-15 9:54 ` [PATCH 3/6] arm: mvebu: Enable USB controllers on Armada 370 Mirabox board Ezequiel Garcia
2013-01-15 9:54 ` Ezequiel Garcia
2013-01-15 9:54 ` [PATCH 4/6] arm: mvebu: Enable USB controllers on Armada XP evaluation board Ezequiel Garcia
2013-01-15 9:54 ` Ezequiel Garcia
2013-01-15 9:54 ` [PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board Ezequiel Garcia
2013-01-15 9:54 ` Ezequiel Garcia
2013-01-16 0:01 ` Nobuhiro Iwamatsu
2013-01-16 0:01 ` Nobuhiro Iwamatsu
2013-01-16 19:16 ` Ezequiel Garcia
2013-01-16 19:16 ` Ezequiel Garcia
2013-01-16 19:37 ` Thomas Petazzoni
2013-01-16 19:37 ` Thomas Petazzoni
2013-01-19 0:07 ` Nobuhiro Iwamatsu
2013-01-19 0:07 ` Nobuhiro Iwamatsu
2013-01-19 0:11 ` Gregory CLEMENT
2013-01-19 0:11 ` Gregory CLEMENT
2013-01-19 0:21 ` Nobuhiro Iwamatsu
2013-01-19 0:21 ` Nobuhiro Iwamatsu
2013-01-15 9:54 ` [PATCH 6/6] arm: mvebu: Update defconfig to select USB support Ezequiel Garcia
2013-01-15 9:54 ` Ezequiel Garcia
2013-01-15 10:23 ` [PATCH 1/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP Florian Fainelli
2013-01-15 10:23 ` Florian Fainelli
2013-01-15 10:49 ` Ezequiel Garcia
2013-01-15 10:49 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F56086.2040101@free-electrons.com \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.