From: Josh Wu <josh.wu@atmel.com>
To: dedekind1@gmail.com
Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] MTD: at91: atmel_nand: for PMECC, add code to choose the ecc bits and sector size according to the ONFI parameter ECC requirement.
Date: Wed, 16 Jan 2013 16:28:44 +0800 [thread overview]
Message-ID: <50F664BC.7@atmel.com> (raw)
In-Reply-To: <1358252760.2731.133.camel@sauron.fi.intel.com>
Hi, Artem
On 1/15/2013 8:26 PM, Artem Bityutskiy wrote:
> I cannot compile this patch:
>
> ERROR (phandle_references): Reference to non-existent node or label "pinctrl_ssc0_tx"
>
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[2]: *** [arch/arm/boot/dts/at91sam9g20ek.dtb] Error 2
As Bo Shen already mentioned, they are caused by ssc pinctrl patches. it
will be merged in next rc or late.
>
> On Wed, 2012-12-19 at 18:27 +0800, Josh Wu wrote:
>> This patch will check NAND flash's ecc minimum requirement in ONFI parameter. If it is equal or smaller than pmecc-cap in dtsi, then use ecc_bits in ONFI. otherwise, return an error since pmecc-cap in dtsi don't meet the ecc minimum reqirement.
>>
>> This patch also check sector size (codeword) requirement in ONFI. If it is equal or bigger than sector_size in dtsi, then use the one of ONFI. otherwise return error.
>>
>> Currently we don't support to read the ECC parameter in ONFI extended parameter page. So in that case we just use the value specified in dts.
>>
>> For non-ONFI nand flash, we assume the minimum ecc requirement is 2bits in 512 bytes.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Please, wrap the lines like kernel developers usually do.
OK. I will resend the whole patch series with wrapped commit message.
thanks.
Best Regards,
Josh Wu
>
WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] MTD: at91: atmel_nand: for PMECC, add code to choose the ecc bits and sector size according to the ONFI parameter ECC requirement.
Date: Wed, 16 Jan 2013 16:28:44 +0800 [thread overview]
Message-ID: <50F664BC.7@atmel.com> (raw)
In-Reply-To: <1358252760.2731.133.camel@sauron.fi.intel.com>
Hi, Artem
On 1/15/2013 8:26 PM, Artem Bityutskiy wrote:
> I cannot compile this patch:
>
> ERROR (phandle_references): Reference to non-existent node or label "pinctrl_ssc0_tx"
>
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[2]: *** [arch/arm/boot/dts/at91sam9g20ek.dtb] Error 2
As Bo Shen already mentioned, they are caused by ssc pinctrl patches. it
will be merged in next rc or late.
>
> On Wed, 2012-12-19 at 18:27 +0800, Josh Wu wrote:
>> This patch will check NAND flash's ecc minimum requirement in ONFI parameter. If it is equal or smaller than pmecc-cap in dtsi, then use ecc_bits in ONFI. otherwise, return an error since pmecc-cap in dtsi don't meet the ecc minimum reqirement.
>>
>> This patch also check sector size (codeword) requirement in ONFI. If it is equal or bigger than sector_size in dtsi, then use the one of ONFI. otherwise return error.
>>
>> Currently we don't support to read the ECC parameter in ONFI extended parameter page. So in that case we just use the value specified in dts.
>>
>> For non-ONFI nand flash, we assume the minimum ecc requirement is 2bits in 512 bytes.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Please, wrap the lines like kernel developers usually do.
OK. I will resend the whole patch series with wrapped commit message.
thanks.
Best Regards,
Josh Wu
>
next prev parent reply other threads:[~2013-01-16 8:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 10:27 [PATCH 0/3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek Josh Wu
2012-12-19 10:27 ` Josh Wu
2012-12-19 10:27 ` [PATCH 1/3] MTD: at91: atmel_nand: for PMECC, add code to choose the ecc bits and sector size according to the ONFI parameter ECC requirement Josh Wu
2012-12-19 10:27 ` Josh Wu
2013-01-15 12:26 ` Artem Bityutskiy
2013-01-15 12:26 ` Artem Bityutskiy
2013-01-16 1:50 ` Bo Shen
2013-01-16 1:50 ` Bo Shen
2013-01-16 8:28 ` Josh Wu [this message]
2013-01-16 8:28 ` Josh Wu
2013-01-17 11:54 ` Artem Bityutskiy
2013-01-17 11:54 ` Artem Bityutskiy
2012-12-19 10:27 ` [PATCH 2/3] at91: 9x5: add DT parameters to enable PMECC Josh Wu
2012-12-19 10:27 ` Josh Wu
2012-12-19 10:27 ` [PATCH 3/3] at91: at91sam9n12: " Josh Wu
2012-12-19 10:27 ` Josh Wu
2013-01-14 9:01 ` [PATCH 0/3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek Josh Wu
2013-01-14 9:01 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F664BC.7@atmel.com \
--to=josh.wu@atmel.com \
--cc=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.