All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Manu Abraham <abraham.manu@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Simon Farnsworth <simon.farnsworth@onelan.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH RFCv10 00/15] DVB QoS statistics API
Date: Thu, 17 Jan 2013 11:33:46 +0200	[thread overview]
Message-ID: <50F7C57A.6090703@iki.fi> (raw)
In-Reply-To: <CAHFNz9L-Dzrv=+Z01ndrfK3GmvFyxT6941W4-_63bwn1HrQBYQ@mail.gmail.com>

On 01/17/2013 05:40 AM, Manu Abraham wrote:
> On Thu, Jan 17, 2013 at 3:31 AM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>> Em Wed, 16 Jan 2013 19:29:28 +0000
>> Simon Farnsworth <simon.farnsworth@onelan.com> escreveu:
>>
>>> On Wednesday 16 January 2013 23:56:48 Manu Abraham wrote:
>>>> On Wed, Jan 16, 2013 at 10:51 PM, Mauro Carvalho Chehab
>>> <snip>
>>>>>
>>>>> It is a common sense that the existing API is broken. If my proposal
>>>>> requires adjustments, please comment on each specific patchset, instead
>>>>> of filling this thread of destructive and useless complains.
>>>>
>>>>
>>>> No, the concept of such a generalization is broken, as each new device will
>>>> be different and trying to make more generalization is a waste of developer
>>>> time and effort. The simplest approach would be to do a coarse approach,
>>>> which is not a perfect world, but it will do some good results for all the
>>>> people who use Linux-DVB. Still, repeating myself we are not dealing with
>>>> high end professional devices. If we have such devices, then it makes sense
>>>> to start such a discussion. Anyway professional devices will need a lot of
>>>> other API extensions, so your arguments on the need for professional
>>>> devices that do not exist are pointless and not agreeable to.
>>>>
>>> Let's step back a bit. As a sophisticated API user, I want to be able to give
>>> my end-users the following information:
>>>
>>>   * Signal strength in dBm
>>>   * Signal quality as "poor", "OK" and "good".
>>>   * Ideally, "increase signal strength to improve things" or "attenuate signal
>>> to improve things"
>>>
>>> In a DVBv3 world, "poor" equates to UNC != 0, "OK" is UNC == 0, BER != 0,
>>> and "good" is UNC == BER == 0. The idea is that a user seeing "poor" knows
>>> that they will see glitches in the output; a user seeing "OK" knows that
>>> there's no glitching right now, but that the setup is marginal and may
>>> struggle if anything changes, and a user seeing "good" knows that they've got
>>> high quality signal.
>>>
>>> VDR wants even simpler - it just wants strength and quality on a 0 to 100
>>> scale, where 100 is perfect, and 0 is nothing present.
>>>
>>> In both cases, we want per-layer quality for ISDB-T, for the reasons you've
>>> already outlined.
>>>
>>> So, how do you provide such information? Is it enough to simply provide
>>> strength in dBm, and quality as 0 to 100, where anything under 33 indicates
>>> uncorrected errors, and anything under 66 indicates that quality is marginal?
>>
>> Unfortunately, not all devices can provide strength in dBm.
>
> MB86A20 is not the only demodulator driver with the Linux DVB.
> And not all devices can output in dB scale proposed by you, But any device
> output can be scaled in a relative way. So I don't see any reason why
> userspace has to deal with cumbersome controls to deal with redundant
> statistics, which is nonsense.

What goes to these units in general, dB conversion is done by the driver 
about always. It is quite hard or even impossible to find out that 
formula unless you has adjustable test signal generator.

Also we could not offer always dBm as signal strength. This comes to 
fact that only recent silicon RF-tuners are able to provide RF strength. 
More traditionally that estimation is done by demod from IF/RF AGC, 
which leads very, very, rough estimation.

So at least for the signal strength it is impossible to require dBm. dB 
for SNR is possible, but it is very hard due to lack of developers 
knowledge and test equipment. SNR could be still forced to look like it 
is in given dB scale. I think it is not big loss even though SNR values 
reported are a little bit wrong.


About half year ago I looked how SNR was measured every demod we has:

http://palosaari.fi/linux/v4l-dvb/snr_2012-05-21.txt

as we can see there is currently only two style used:
1) 0.1 dB (very common in new drivers)
2) unknown (== mostly just raw register values)


regards
Antti

-- 
http://palosaari.fi/

  reply	other threads:[~2013-01-17  9:34 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  2:30 [PATCH RFCv10 00/15] DVB QoS statistics API Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 01/15] mb86a20s: improve error handling at get_frontend Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 02/15] dvb: Add DVBv5 stats properties for Quality of Service Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 03/15] dvb: the core logic to handle the DVBv5 QoS properties Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 04/15] mb86a20s: Update QoS statistics at FE read_status Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 05/15] mb86a20s: functions reorder Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 06/15] mb86a20s: Fix i2c gate on error Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 07/15] mb86a20s: improve debug for RF level Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 08/15] mb86a20s: fix interleaving and FEC retrival Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 09/15] mb86a20s: convert it to use dev_info/dev_err/dev_dbg Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 10/15] mb86a20s: -EBUSY is expected when getting QoS measures Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 11/15] mb86a20s: make AGC work better Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 12/15] mb86a20s: Some improvements for BER measurement Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 13/15] mb86a20s: improve bit error count for BER Mauro Carvalho Chehab
2013-01-15  2:31 ` [PATCH RFCv10 14/15] dvb: increase API version Mauro Carvalho Chehab
2013-01-15  8:20 ` [PATCH RFCv10 00/15] DVB QoS statistics API Johannes Stezenbach
2013-01-15  8:55   ` Antti Palosaari
2013-01-15 12:23     ` Mauro Carvalho Chehab
2013-01-15  9:34 ` Antti Palosaari
2013-01-15 13:10   ` Mauro Carvalho Chehab
2013-01-15 14:49     ` Antti Palosaari
2013-01-15 15:21       ` Mauro Carvalho Chehab
2013-01-15 15:47         ` Devin Heitmueller
2013-01-15 17:02           ` Mauro Carvalho Chehab
2013-01-15 15:26       ` Antti Palosaari
2013-01-15 17:12         ` Mauro Carvalho Chehab
2013-01-15 20:37           ` Antti Palosaari
2013-01-16  4:26             ` Manu Abraham
2013-01-16 11:41               ` Luca Olivetti
2013-01-16 13:56               ` Mauro Carvalho Chehab
2013-01-16 15:19                 ` Manu Abraham
2013-01-16 17:21                   ` Mauro Carvalho Chehab
2013-01-16 18:26                     ` Manu Abraham
2013-01-16 19:22                       ` Mauro Carvalho Chehab
2013-01-16 21:40                         ` Manu Abraham
2013-01-16 19:29                       ` Simon Farnsworth
2013-01-16 21:37                         ` Manu Abraham
2013-01-16 22:11                           ` Mauro Carvalho Chehab
2013-01-17  3:26                             ` Manu Abraham
2013-01-16 22:01                         ` Mauro Carvalho Chehab
2013-01-17  3:40                           ` Manu Abraham
2013-01-17  9:33                             ` Antti Palosaari [this message]
2013-01-17 16:50                               ` Mauro Carvalho Chehab
2013-01-17 17:15                                 ` Antti Palosaari
2013-01-17 18:11                                   ` Mauro Carvalho Chehab
2013-01-17 18:27                                     ` Antti Palosaari
2013-01-17 18:37                                       ` Manu Abraham
2013-01-17 18:50                                         ` Mauro Carvalho Chehab
2013-01-17 19:11                                           ` Antti Palosaari
2013-01-17 19:35                                             ` Mauro Carvalho Chehab
2013-01-17 21:29                                             ` Manu Abraham
2013-01-17 22:22                                               ` Antti Palosaari
2013-01-17 22:46                                                 ` Mauro Carvalho Chehab
2013-01-22 12:16                                             ` Mauro Carvalho Chehab
2013-01-23 15:08                                               ` Antti Palosaari
2013-01-23 15:12                                                 ` Antti Palosaari
2013-01-23 18:18                                                 ` Mauro Carvalho Chehab
2013-01-23 18:57                                                   ` Mauro Carvalho Chehab
2013-01-23 19:55                                                     ` Antti Palosaari
2013-01-23 21:00                                                       ` Mauro Carvalho Chehab
2013-01-23 22:02                                                         ` Mauro Carvalho Chehab
2013-01-17 17:16                               ` Manu Abraham
2013-01-17 17:22                                 ` Antti Palosaari
2013-01-17 17:37                                   ` [linux-media] " Klaus Schmidinger
2013-01-17 17:39                                     ` [linux-media] " Klaus Schmidinger
2013-01-17 18:36                                   ` Mauro Carvalho Chehab
2013-01-19 12:04                           ` Mauro Carvalho Chehab
2013-01-16 13:24             ` Mauro Carvalho Chehab
2013-01-15 10:38 ` Manu Abraham
2013-01-15 15:23   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F7C57A.6090703@iki.fi \
    --to=crope@iki.fi \
    --cc=abraham.manu@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=simon.farnsworth@onelan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.