Re: [Qemu-devel] [PATCH 1/4] build: move around libcacard-y definition

["Andreas Färber" <afaerber@suse.de>]

Am 19.01.2013 11:06, schrieb Paolo Bonzini:
> It is also needed if !CONFIG_SOFTMMU, unlike everything that surrounds it.

Why? linux-user should not depend on it - bad wording only?

Andreas

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile.objs |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index d465a72..3548f9b 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -34,6 +34,15 @@ CONFIG_REALLY_VIRTFS=y
>  endif
>  
>  ######################################################################
> +# smartcard
> +
> +libcacard-y += libcacard/cac.o libcacard/event.o
> +libcacard-y += libcacard/vcard.o libcacard/vreader.o
> +libcacard-y += libcacard/vcard_emul_nss.o
> +libcacard-y += libcacard/vcard_emul_type.o
> +libcacard-y += libcacard/card_7816.o
> +
> +######################################################################
>  # Target independent part of system emulation. The long term path is to
>  # suppress *all* target specific code in case of system emulation, i.e. a
>  # single QEMU executable should support all CPUs and machines.
> @@ -77,15 +86,6 @@ ifeq ($(CONFIG_SECCOMP),y)
>  common-obj-y += qemu-seccomp.o
>  endif
>  
> -######################################################################
> -# smartcard
> -
> -libcacard-y += libcacard/cac.o libcacard/event.o
> -libcacard-y += libcacard/vcard.o libcacard/vreader.o
> -libcacard-y += libcacard/vcard_emul_nss.o
> -libcacard-y += libcacard/vcard_emul_type.o
> -libcacard-y += libcacard/card_7816.o
> -
>  common-obj-$(CONFIG_SMARTCARD_NSS) += $(libcacard-y)
>  
>  ######################################################################
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg