* [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list
@ 2013-01-19 5:00 Kukjin Kim
2013-01-19 10:40 ` Tomasz Figa
0 siblings, 1 reply; 6+ messages in thread
From: Kukjin Kim @ 2013-01-19 5:00 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Giridhar Maruthy, Kukjin Kim
From: Giridhar Maruthy <giridhar.m@samsung.com>
Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
arch/arm/boot/dts/exynos5440-ssdk5440.dts | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
index 81e2c96..5239d75 100644
--- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
+++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
@@ -36,10 +36,6 @@
status = "disabled";
};
- watchdog {
- status = "disabled";
- };
-
rtc {
status = "disabled";
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list
2013-01-19 5:00 [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list Kukjin Kim
@ 2013-01-19 10:40 ` Tomasz Figa
2013-01-20 23:29 ` Kukjin Kim
2013-01-21 6:51 ` Tushar Behera
0 siblings, 2 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-01-19 10:40 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc, Giridhar Maruthy
Hi Kukjin,
The commit message is a bit confusing, because it says that something is
being added, while in fact the whole node is being removed.
Shouldn't it rather say something like:
ARM: dts: exynos5440-ssdk5440: Remove disabled status from watchdog node
Best regards,
Tomasz Figa
On Friday 18 of January 2013 21:00:51 Kukjin Kim wrote:
> From: Giridhar Maruthy <giridhar.m@samsung.com>
>
> Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/boot/dts/exynos5440-ssdk5440.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> b/arch/arm/boot/dts/exynos5440-ssdk5440.dts index 81e2c96..5239d75
> 100644
> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> @@ -36,10 +36,6 @@
> status = "disabled";
> };
>
> - watchdog {
> - status = "disabled";
> - };
> -
> rtc {
> status = "disabled";
> };
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list
2013-01-19 10:40 ` Tomasz Figa
@ 2013-01-20 23:29 ` Kukjin Kim
2013-01-21 6:51 ` Tushar Behera
1 sibling, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-01-20 23:29 UTC (permalink / raw)
To: 'Tomasz Figa'; +Cc: linux-samsung-soc, 'Giridhar Maruthy'
Tomasz Figa wrote:
>
> Hi Kukjin,
>
Hi,
> The commit message is a bit confusing, because it says that something is
> being added, while in fact the whole node is being removed.
>
> Shouldn't it rather say something like:
> ARM: dts: exynos5440-ssdk5440: Remove disabled status from watchdog
> node
>
Same as previous my comments.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list
2013-01-19 10:40 ` Tomasz Figa
2013-01-20 23:29 ` Kukjin Kim
@ 2013-01-21 6:51 ` Tushar Behera
2013-01-21 13:09 ` Tomasz Figa
1 sibling, 1 reply; 6+ messages in thread
From: Tushar Behera @ 2013-01-21 6:51 UTC (permalink / raw)
To: Tomasz Figa; +Cc: Kukjin Kim, linux-samsung-soc, Giridhar Maruthy
On 01/19/2013 04:10 PM, Tomasz Figa wrote:
> Hi Kukjin,
>
> The commit message is a bit confusing, because it says that something is
> being added, while in fact the whole node is being removed.
>
> Shouldn't it rather say something like:
> ARM: dts: exynos5440-ssdk5440: Remove disabled status from watchdog node
>
Rather, should we not be following a consistent approach for both
EXYNSO4 and EXYNOS5.
In EXYNOS4, the default state of the nodes is 'disabled' and they are
enabled in the board-specific files whereas it is exactly the opposite
in case of EXYNOS5.
> Best regards,
> Tomasz Figa
>
> On Friday 18 of January 2013 21:00:51 Kukjin Kim wrote:
>> From: Giridhar Maruthy <giridhar.m@samsung.com>
>>
>> Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
>> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5440-ssdk5440.dts | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> b/arch/arm/boot/dts/exynos5440-ssdk5440.dts index 81e2c96..5239d75
>> 100644
>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> @@ -36,10 +36,6 @@
>> status = "disabled";
>> };
>>
>> - watchdog {
>> - status = "disabled";
>> - };
>> -
>> rtc {
>> status = "disabled";
>> };
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list
2013-01-21 6:51 ` Tushar Behera
@ 2013-01-21 13:09 ` Tomasz Figa
2013-01-23 2:36 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Tomasz Figa @ 2013-01-21 13:09 UTC (permalink / raw)
To: Tushar Behera
Cc: Tomasz Figa, Kukjin Kim, linux-samsung-soc, Giridhar Maruthy
On Monday 21 of January 2013 12:21:41 Tushar Behera wrote:
> On 01/19/2013 04:10 PM, Tomasz Figa wrote:
> > Hi Kukjin,
> >
> > The commit message is a bit confusing, because it says that something
> > is being added, while in fact the whole node is being removed.
> >
> > Shouldn't it rather say something like:
> > ARM: dts: exynos5440-ssdk5440: Remove disabled status from watchdog
> > node
> Rather, should we not be following a consistent approach for both
> EXYNSO4 and EXYNOS5.
>
> In EXYNOS4, the default state of the nodes is 'disabled' and they are
> enabled in the board-specific files whereas it is exactly the opposite
> in case of EXYNOS5.
Yes, I think we should eventually modify Exynos 5 to use the same approach
as Exynos 4.
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list
2013-01-21 13:09 ` Tomasz Figa
@ 2013-01-23 2:36 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-01-23 2:36 UTC (permalink / raw)
To: 'Tomasz Figa', 'Tushar Behera'
Cc: 'Tomasz Figa', linux-samsung-soc,
'Giridhar Maruthy', Thomas Abraham
Tomasz Figa wrote:
>
> On Monday 21 of January 2013 12:21:41 Tushar Behera wrote:
> > On 01/19/2013 04:10 PM, Tomasz Figa wrote:
> > > Hi Kukjin,
> > >
> > > The commit message is a bit confusing, because it says that something
> > > is being added, while in fact the whole node is being removed.
> > >
> > > Shouldn't it rather say something like:
> > > ARM: dts: exynos5440-ssdk5440: Remove disabled status from watchdog
> > > node
> > Rather, should we not be following a consistent approach for both
> > EXYNSO4 and EXYNOS5.
> >
> > In EXYNOS4, the default state of the nodes is 'disabled' and they are
> > enabled in the board-specific files whereas it is exactly the opposite
> > in case of EXYNOS5.
>
> Yes, I think we should eventually modify Exynos 5 to use the same approach
> as Exynos 4.
>
Well, I know what you suggested and the way is used on exynos4 DT. But in
the case of EXYNOS5440, all the peripherals are used on boards based on
EXYNOS5440 SoC, so we can keep the peripherals available.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-23 2:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-19 5:00 [PATCH] ARM: dts: Add watchdog in exynos5440-ssdk5440 device list Kukjin Kim
2013-01-19 10:40 ` Tomasz Figa
2013-01-20 23:29 ` Kukjin Kim
2013-01-21 6:51 ` Tushar Behera
2013-01-21 13:09 ` Tomasz Figa
2013-01-23 2:36 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.