All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tushar Behera <tushar.behera@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	linux@arm.linux.org.uk, patches@linaro.org,
	Girish K S <ks.giri@samsung.com>
Subject: Re: [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
Date: Thu, 24 Jan 2013 14:42:44 +0530	[thread overview]
Message-ID: <5100FB0C.7040706@linaro.org> (raw)
In-Reply-To: <CAK9yfHyKK4L_YH5fw=CrcjzeZgfhGKtDMpZQ3GVLnoVt3gkNiQ@mail.gmail.com>

On 01/24/2013 12:14 PM, Sachin Kamat wrote:
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 5ebb44f..60a9e52 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
>>         exynos4210-trats.dtb \
>>         exynos4412-smdk4412.dtb \
>>         exynos5250-smdk5250.dtb \
>> +       exynos5250-arndale.dtb \
> 
> I think this entry could be moved one step up for maintaining
> alphabetical order.
> 

Ok.

>>         exynos5250-snow.dtb \
>>         exynos5440-ssdk5440.dtb
>>  dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
>> new file mode 100644
>> index 0000000..7504cf3
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> @@ -0,0 +1,124 @@
>> +/*
>> + * Samsung's Exynos5250 based Arndale board device tree source
>> + *
>> + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
> 
> 2013?
> 

Ok.

>> + *             http://www.samsung.com
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> +*/
>> +
>> +/dts-v1/;
>> +/include/ "exynos5250.dtsi"
>> +
>> +/ {
>> +       model = "Insignal Arndale evaluation board based on EXYNOS5250";
>> +       compatible = "insignal,arndale", "samsung,exynos5250";
>> +
>> +       memory {
>> +               reg = <0x40000000 0x80000000>;
>> +       };
>> +
>> +       chosen {
>> +               bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";
> 
> This could be resticted only to console
>                 bootargs = "console=ttySAC2,115200";
> 
> 

Ok.

I will resubmit the patchset.

-- 
Tushar Behera

WARNING: multiple messages have this Message-ID (diff)
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
Date: Thu, 24 Jan 2013 14:42:44 +0530	[thread overview]
Message-ID: <5100FB0C.7040706@linaro.org> (raw)
In-Reply-To: <CAK9yfHyKK4L_YH5fw=CrcjzeZgfhGKtDMpZQ3GVLnoVt3gkNiQ@mail.gmail.com>

On 01/24/2013 12:14 PM, Sachin Kamat wrote:
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 5ebb44f..60a9e52 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
>>         exynos4210-trats.dtb \
>>         exynos4412-smdk4412.dtb \
>>         exynos5250-smdk5250.dtb \
>> +       exynos5250-arndale.dtb \
> 
> I think this entry could be moved one step up for maintaining
> alphabetical order.
> 

Ok.

>>         exynos5250-snow.dtb \
>>         exynos5440-ssdk5440.dtb
>>  dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
>> new file mode 100644
>> index 0000000..7504cf3
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> @@ -0,0 +1,124 @@
>> +/*
>> + * Samsung's Exynos5250 based Arndale board device tree source
>> + *
>> + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
> 
> 2013?
> 

Ok.

>> + *             http://www.samsung.com
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> +*/
>> +
>> +/dts-v1/;
>> +/include/ "exynos5250.dtsi"
>> +
>> +/ {
>> +       model = "Insignal Arndale evaluation board based on EXYNOS5250";
>> +       compatible = "insignal,arndale", "samsung,exynos5250";
>> +
>> +       memory {
>> +               reg = <0x40000000 0x80000000>;
>> +       };
>> +
>> +       chosen {
>> +               bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";
> 
> This could be resticted only to console
>                 bootargs = "console=ttySAC2,115200";
> 
> 

Ok.

I will resubmit the patchset.

-- 
Tushar Behera

  reply	other threads:[~2013-01-24  9:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24  6:16 [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file Tushar Behera
2013-01-24  6:16 ` Tushar Behera
2013-01-24  6:44 ` Sachin Kamat
2013-01-24  6:44   ` Sachin Kamat
2013-01-24  9:12   ` Tushar Behera [this message]
2013-01-24  9:12     ` Tushar Behera
2013-01-24  6:51 ` Alim Akhtar
2013-01-24  6:51   ` Alim Akhtar
2013-01-24  9:22   ` Tushar Behera
2013-01-24  9:22     ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5100FB0C.7040706@linaro.org \
    --to=tushar.behera@linaro.org \
    --cc=kgene.kim@samsung.com \
    --cc=ks.giri@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=patches@linaro.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.