From: Tushar Behera <tushar.behera@linaro.org>
To: Alim Akhtar <alim.akhtar@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
linux@arm.linux.org.uk, patches@linaro.org,
Girish K S <ks.giri@samsung.com>
Subject: Re: [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
Date: Thu, 24 Jan 2013 14:52:05 +0530 [thread overview]
Message-ID: <5100FD3D.7080206@linaro.org> (raw)
In-Reply-To: <CAGOxZ53VsXE_as6aNk85jdxVG2FAg-SqWc8svTHpgrcttE_q0w@mail.gmail.com>
On 01/24/2013 12:21 PM, Alim Akhtar wrote:
>> +
>> + i2c@12CC0000 {
>> + status = "disabled";
>> + };
>> +
>> + i2c@12CD0000 {
>> + status = "disabled";
>> + };
>> +
>> + i2c@121D0000 {
>> + status = "disabled";
>> + };
>> +
>
> Why to disable these i2c devices here? Any particular reason?
> You can moves these to exynos5250.dtsi which is suppose to be common
> for all the exynos5250 platforms.
> Please see the exynos4.dtsi for reference.
>
Agreed. There was a discussion going on in [1] related to this. Since
there was no consensus on that, I preferred to go with the current
approach that is followed for other EXYNOS5250 based scripts.
If it is agreed by Kukjin to move to Exynos4 style, then I can submit
patches for that.
[1]
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg15013.html
--
Tushar Behera
WARNING: multiple messages have this Message-ID (diff)
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file
Date: Thu, 24 Jan 2013 14:52:05 +0530 [thread overview]
Message-ID: <5100FD3D.7080206@linaro.org> (raw)
In-Reply-To: <CAGOxZ53VsXE_as6aNk85jdxVG2FAg-SqWc8svTHpgrcttE_q0w@mail.gmail.com>
On 01/24/2013 12:21 PM, Alim Akhtar wrote:
>> +
>> + i2c at 12CC0000 {
>> + status = "disabled";
>> + };
>> +
>> + i2c at 12CD0000 {
>> + status = "disabled";
>> + };
>> +
>> + i2c at 121D0000 {
>> + status = "disabled";
>> + };
>> +
>
> Why to disable these i2c devices here? Any particular reason?
> You can moves these to exynos5250.dtsi which is suppose to be common
> for all the exynos5250 platforms.
> Please see the exynos4.dtsi for reference.
>
Agreed. There was a discussion going on in [1] related to this. Since
there was no consensus on that, I preferred to go with the current
approach that is followed for other EXYNOS5250 based scripts.
If it is agreed by Kukjin to move to Exynos4 style, then I can submit
patches for that.
[1]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg15013.html
--
Tushar Behera
next prev parent reply other threads:[~2013-01-24 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 6:16 [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file Tushar Behera
2013-01-24 6:16 ` Tushar Behera
2013-01-24 6:44 ` Sachin Kamat
2013-01-24 6:44 ` Sachin Kamat
2013-01-24 9:12 ` Tushar Behera
2013-01-24 9:12 ` Tushar Behera
2013-01-24 6:51 ` Alim Akhtar
2013-01-24 6:51 ` Alim Akhtar
2013-01-24 9:22 ` Tushar Behera [this message]
2013-01-24 9:22 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100FD3D.7080206@linaro.org \
--to=tushar.behera@linaro.org \
--cc=alim.akhtar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=ks.giri@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.