From: Rajeev kumar <rajeev-dlh.kumar@st.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [patch] ASoC: dwc: fix support for more than two channels
Date: Fri, 25 Jan 2013 14:03:46 +0530 [thread overview]
Message-ID: <5102436A.4030205@st.com> (raw)
In-Reply-To: <20130125064343.GE4882@elgon.mountain>
On 1/25/2013 12:13 PM, Dan Carpenter wrote:
> here were missing break statements so everything used
> TWO_CHANNEL_SUPPORT.
>
> Also I added a return statement to silence a GCC warning:
>
> sound/soc/dwc/designware_i2s.c: In function ‘dw_i2s_hw_params’:
> sound/soc/dwc/designware_i2s.c:236:32: warning: ‘ch_reg’ may be
> used uninitialized in this function
> [-Wmaybe-uninitialized]
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> ---
> Static analysis. Untested.
Acked By: Rajeev Kumar <rajeev-dlh.kumar@st.com>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Rajeev kumar <rajeev-dlh.kumar@st.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [patch] ASoC: dwc: fix support for more than two channels
Date: Fri, 25 Jan 2013 08:45:46 +0000 [thread overview]
Message-ID: <5102436A.4030205@st.com> (raw)
In-Reply-To: <20130125064343.GE4882@elgon.mountain>
On 1/25/2013 12:13 PM, Dan Carpenter wrote:
> here were missing break statements so everything used
> TWO_CHANNEL_SUPPORT.
>
> Also I added a return statement to silence a GCC warning:
>
> sound/soc/dwc/designware_i2s.c: In function ‘dw_i2s_hw_params’:
> sound/soc/dwc/designware_i2s.c:236:32: warning: ‘ch_reg’ may be
> used uninitialized in this function
> [-Wmaybe-uninitialized]
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> ---
> Static analysis. Untested.
Acked By: Rajeev Kumar <rajeev-dlh.kumar@st.com>
next prev parent reply other threads:[~2013-01-25 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 6:43 [patch] ASoC: dwc: fix support for more than two channels Dan Carpenter
2013-01-25 6:43 ` Dan Carpenter
2013-01-25 8:33 ` Rajeev kumar [this message]
2013-01-25 8:45 ` Rajeev kumar
2013-01-26 7:37 ` Mark Brown
2013-01-26 7:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5102436A.4030205@st.com \
--to=rajeev-dlh.kumar@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.