[PATCH] Btrfs-progs: remove btrfsctl, btrfs-show and btrfs-vol from default build

[PATCH] Btrfs-progs: remove btrfsctl, btrfs-show and btrfs-vol from default build

[Stefan Behrens]

Remove btrfsctl, btrfs-show and btrfs-vol from "all" target of Makefile.

Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index aaf1381..79e7a56 100644
--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,7 @@ bindir = $(prefix)/bin
 LIBS=-luuid
 RESTORE_LIBS=-lz
 
-progs = btrfsctl mkfs.btrfs btrfs-debug-tree btrfs-show btrfs-vol btrfsck \
+progs = mkfs.btrfs btrfs-debug-tree btrfsck \
 	btrfs btrfs-map-logical btrfs-image btrfs-zero-log btrfs-convert \
 	btrfs-find-root btrfs-restore btrfstune
 
-- 
1.7.10.4

Re: [PATCH] Btrfs-progs: remove btrfsctl, btrfs-show and btrfs-vol from default build

[Gene Czarcinski]

On 06/08/2012 02:00 PM, Stefan Behrens wrote:
> Remove btrfsctl, btrfs-show and btrfs-vol from "all" target of Makefile.
>
> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
> ---
>   Makefile |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index aaf1381..79e7a56 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -18,7 +18,7 @@ bindir = $(prefix)/bin
>   LIBS=-luuid
>   RESTORE_LIBS=-lz
>
> -progs = btrfsctl mkfs.btrfs btrfs-debug-tree btrfs-show btrfs-vol btrfsck \
> +progs = mkfs.btrfs btrfs-debug-tree btrfsck \
>   	btrfs btrfs-map-logical btrfs-image btrfs-zero-log btrfs-convert \
>   	btrfs-find-root btrfs-restore btrfstune
>
>
I agree.  It is time to remove these old programs; they serve no useful 
purpose; and they complicate maintenance.

Gene

Re: [PATCH] Btrfs-progs: remove btrfsctl, btrfs-show and btrfs-vol from default build

[Eric Sandeen]

On 1/25/13 5:57 AM, Gene Czarcinski wrote:
> On 06/08/2012 02:00 PM, Stefan Behrens wrote:
>> Remove btrfsctl, btrfs-show and btrfs-vol from "all" target of Makefile.

TBH, unless there are objections, I'd rather remove the source files as well.

Having unbuilt source code lying around is potentially even more confusing.

I'd at least move it to a deprecated/ subdir or something, but it'll only
fester and die there as well.  I'd just remove it, if it's time to do so.

Are they fully deprecated?  Is there anything these tools do that btrfs
does not?

-Eric

>> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
>> ---
>>   Makefile |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index aaf1381..79e7a56 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -18,7 +18,7 @@ bindir = $(prefix)/bin
>>   LIBS=-luuid
>>   RESTORE_LIBS=-lz
>>
>> -progs = btrfsctl mkfs.btrfs btrfs-debug-tree btrfs-show btrfs-vol btrfsck \
>> +progs = mkfs.btrfs btrfs-debug-tree btrfsck \
>>       btrfs btrfs-map-logical btrfs-image btrfs-zero-log btrfs-convert \
>>       btrfs-find-root btrfs-restore btrfstune
>>
>>
> I agree.  It is time to remove these old programs; they serve no useful purpose; and they complicate maintenance.
> 
> Gene
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Btrfs-progs: remove btrfsctl, btrfs-show and btrfs-vol from default build

[Stefan Behrens]

On Fri, 25 Jan 2013 09:32:01 -0600, Eric Sandeen wrote:
> On 1/25/13 5:57 AM, Gene Czarcinski wrote:
>> On 06/08/2012 02:00 PM, Stefan Behrens wrote:
>>> Remove btrfsctl, btrfs-show and btrfs-vol from "all" target of Makefile.
> 
> TBH, unless there are objections, I'd rather remove the source files as well.
> 
> Having unbuilt source code lying around is potentially even more confusing.
> 
> I'd at least move it to a deprecated/ subdir or something, but it'll only
> fester and die there as well.  I'd just remove it, if it's time to do so.

Yes, right. Half a year ago, this was a first attempt from me to start a
discussion on this topic. But I agree that the removal of the sources
and the removal in the Makefile should be made in one commit.

Unfortunately Suse is still needing these old files as David wrote.


> Are they fully deprecated?  Is there anything these tools do that btrfs
> does not?

Yes (fully deprecated for 2 years). No (the unified btrfs tool is a full
replacement).

Re: [PATCH] Btrfs-progs: remove btrfsctl, btrfs-show and btrfs-vol from default build

[Anand Jain]

  This patch is much needed. thanks.

  Further, IMO the summary may provide a table of mapping of
  the original to its predecessor command-and-option so that
  - it will ensure we have taken care of all the original
  features in the new cli, and it will help to document
  for the onlooker.

  eg:
  old-command        replaced-by
   btrfsctl -D        btrfs subvol del
   ::
   ::

  (if this is already there somewhere providing a ref/copying
  here will help)

Thanks, Anand

On 06/09/2012 02:00 AM, Stefan Behrens wrote:
> Remove btrfsctl, btrfs-show and btrfs-vol from "all" target of Makefile.
>
> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
> ---
>   Makefile |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index aaf1381..79e7a56 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -18,7 +18,7 @@ bindir = $(prefix)/bin
>   LIBS=-luuid
>   RESTORE_LIBS=-lz
>
> -progs = btrfsctl mkfs.btrfs btrfs-debug-tree btrfs-show btrfs-vol btrfsck \
> +progs = mkfs.btrfs btrfs-debug-tree btrfsck \
>   	btrfs btrfs-map-logical btrfs-image btrfs-zero-log btrfs-convert \
>   	btrfs-find-root btrfs-restore btrfstune
>
>