All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Jerome Glisse <jglisse@redhat.com>,
	Ben Skeggs <bskeggs@redhat.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm: fix compile failure by including <linux/swiotlb.h>
Date: Sun, 03 Feb 2013 22:58:29 +0100	[thread overview]
Message-ID: <510EDD85.60909@canonical.com> (raw)
In-Reply-To: <201302012045.r11KjctX014737@farm-0002.internal.tilera.com>

Op 01-02-13 19:44, Chris Metcalf schreef:
> On tile architecture (with "make allyesconfig") including
> <linux/swiotlb.h> is required to call swiotlb_nr_tbl().
I'll take your word for the need, since I lack the hardware to verify the failure. :-)
Applying your patch doesn't seem to break compilation on x86 though, which is good enough for me.

Acked-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_bo.c |    1 +
>  drivers/gpu/drm/radeon/radeon_ttm.c  |    1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 69d7b1d..1699a90 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -28,6 +28,7 @@
>   */
>  
>  #include <core/engine.h>
> +#include <linux/swiotlb.h>
>  
>  #include <subdev/fb.h>
>  #include <subdev/vm.h>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 1d8ff2f..93f760e 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -38,6 +38,7 @@
>  #include <drm/radeon_drm.h>
>  #include <linux/seq_file.h>
>  #include <linux/slab.h>
> +#include <linux/swiotlb.h>
>  #include "radeon_reg.h"
>  #include "radeon.h"
>  

WARNING: multiple messages have this Message-ID (diff)
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Ben Skeggs <bskeggs@redhat.com>, Dave Airlie <airlied@redhat.com>,
	Thomas Hellstrom <thellstrom@vmware.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Jerome Glisse <jglisse@redhat.com>,
	Christian Konig <deathsimple@vodafone.de>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: fix compile failure by including <linux/swiotlb.h>
Date: Sun, 03 Feb 2013 22:58:29 +0100	[thread overview]
Message-ID: <510EDD85.60909@canonical.com> (raw)
In-Reply-To: <201302012045.r11KjctX014737@farm-0002.internal.tilera.com>

Op 01-02-13 19:44, Chris Metcalf schreef:
> On tile architecture (with "make allyesconfig") including
> <linux/swiotlb.h> is required to call swiotlb_nr_tbl().
I'll take your word for the need, since I lack the hardware to verify the failure. :-)
Applying your patch doesn't seem to break compilation on x86 though, which is good enough for me.

Acked-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_bo.c |    1 +
>  drivers/gpu/drm/radeon/radeon_ttm.c  |    1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 69d7b1d..1699a90 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -28,6 +28,7 @@
>   */
>  
>  #include <core/engine.h>
> +#include <linux/swiotlb.h>
>  
>  #include <subdev/fb.h>
>  #include <subdev/vm.h>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 1d8ff2f..93f760e 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -38,6 +38,7 @@
>  #include <drm/radeon_drm.h>
>  #include <linux/seq_file.h>
>  #include <linux/slab.h>
> +#include <linux/swiotlb.h>
>  #include "radeon_reg.h"
>  #include "radeon.h"
>  

  reply	other threads:[~2013-02-03 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 18:44 [PATCH] drm: fix compile failure by including <linux/swiotlb.h> Chris Metcalf
2013-02-01 18:44 ` Chris Metcalf
2013-02-03 21:58 ` Maarten Lankhorst [this message]
2013-02-03 21:58   ` Maarten Lankhorst
  -- strict thread matches above, loose matches on Subject: below --
2013-02-01 18:44 Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510EDD85.60909@canonical.com \
    --to=maarten.lankhorst@canonical.com \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=bskeggs@redhat.com \
    --cc=cmetcalf@tilera.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jglisse@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.