From: kishon <kishon-l0cyMroinI0@public.gmane.org>
To: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
b-cousson-l0cyMroinI0@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
rnayak-l0cyMroinI0@public.gmane.org,
paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 10/13] ARM: dts: OMAP4: Add HS USB Host IP nodes
Date: Tue, 5 Feb 2013 14:27:03 +0530 [thread overview]
Message-ID: <5110C95F.9070500@ti.com> (raw)
In-Reply-To: <5110C8CE.2020606-l0cyMroinI0@public.gmane.org>
On Tuesday 05 February 2013 02:24 PM, Roger Quadros wrote:
> On 02/05/2013 08:24 AM, kishon wrote:
>> On Monday 04 February 2013 09:28 PM, Roger Quadros wrote:
>>> Adds device nodes for HS USB Host module, TLL module,
>>> OHCI and EHCI controllers.
>>>
>>> Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
>>> ---
>>> arch/arm/boot/dts/omap4.dtsi | 30 ++++++++++++++++++++++++++++++
>>> 1 files changed, 30 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>>> index 739bb79..3429280 100644
>>> --- a/arch/arm/boot/dts/omap4.dtsi
>>> +++ b/arch/arm/boot/dts/omap4.dtsi
>>> @@ -529,5 +529,35 @@
>>> ti,hwmods = "timer11";
>>> ti,timer-pwm;
>>> };
>>> +
>>> + usbhstll: usbhstll@0x4a062000 {
>>> + compatible = "ti,usbhs-tll";
>>> + reg = <0x4a062000 0x1000>;
>>> + interrupts = <0 78 0x4>;
>>> + ti,hwmods = "usb_tll_hs";
>>> + };
>>> +
>>> + usbhshost: usbhshost@0x4a064000 {
>>> + compatible = "ti,usbhs-host";
>>> + reg = <0x4a064000 0x800>;
>>> + ti,hwmods = "usb_host_hs";
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges;
>>> +
>>> + usbhsohci: ohci@0x4a064800 {
>>> + compatible = "ti,omap3-ohci", "usb-ohci";
>>> + reg = <0x4a064800 0x400>;
>>> + interrupt-parent = <&gic>;
>>
>> Just curious.. Were you facing issues if you are not having interrupt-parent here? It's also missing in your dt node usbhstll.
>
> Yes I was. Interrupt-parent is not there in any of the children which are at the same level as usbhstll.
Cool. Thought so :-)
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (kishon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/13] ARM: dts: OMAP4: Add HS USB Host IP nodes
Date: Tue, 5 Feb 2013 14:27:03 +0530 [thread overview]
Message-ID: <5110C95F.9070500@ti.com> (raw)
In-Reply-To: <5110C8CE.2020606@ti.com>
On Tuesday 05 February 2013 02:24 PM, Roger Quadros wrote:
> On 02/05/2013 08:24 AM, kishon wrote:
>> On Monday 04 February 2013 09:28 PM, Roger Quadros wrote:
>>> Adds device nodes for HS USB Host module, TLL module,
>>> OHCI and EHCI controllers.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> arch/arm/boot/dts/omap4.dtsi | 30 ++++++++++++++++++++++++++++++
>>> 1 files changed, 30 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>>> index 739bb79..3429280 100644
>>> --- a/arch/arm/boot/dts/omap4.dtsi
>>> +++ b/arch/arm/boot/dts/omap4.dtsi
>>> @@ -529,5 +529,35 @@
>>> ti,hwmods = "timer11";
>>> ti,timer-pwm;
>>> };
>>> +
>>> + usbhstll: usbhstll at 0x4a062000 {
>>> + compatible = "ti,usbhs-tll";
>>> + reg = <0x4a062000 0x1000>;
>>> + interrupts = <0 78 0x4>;
>>> + ti,hwmods = "usb_tll_hs";
>>> + };
>>> +
>>> + usbhshost: usbhshost at 0x4a064000 {
>>> + compatible = "ti,usbhs-host";
>>> + reg = <0x4a064000 0x800>;
>>> + ti,hwmods = "usb_host_hs";
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges;
>>> +
>>> + usbhsohci: ohci at 0x4a064800 {
>>> + compatible = "ti,omap3-ohci", "usb-ohci";
>>> + reg = <0x4a064800 0x400>;
>>> + interrupt-parent = <&gic>;
>>
>> Just curious.. Were you facing issues if you are not having interrupt-parent here? It's also missing in your dt node usbhstll.
>
> Yes I was. Interrupt-parent is not there in any of the children which are at the same level as usbhstll.
Cool. Thought so :-)
Thanks
Kishon
next prev parent reply other threads:[~2013-02-05 8:57 UTC|newest]
Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 15:58 [PATCH 00/13] Device tree support for OMAP HS USB Host Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 01/13] usb: phy: nop: Add device tree support and binding information Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-05 7:26 ` Felipe Balbi
2013-02-05 7:26 ` Felipe Balbi
2013-02-05 8:30 ` Roger Quadros
2013-02-05 8:30 ` Roger Quadros
[not found] ` <5110C339.7080109-l0cyMroinI0@public.gmane.org>
2013-02-05 9:07 ` Felipe Balbi
2013-02-05 9:07 ` Felipe Balbi
[not found] ` <20130205072637.GA32118-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-03-11 15:52 ` Marc Kleine-Budde
2013-03-11 15:52 ` Marc Kleine-Budde
[not found] ` <513DFDD7.7000801-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-12 9:09 ` Roger Quadros
2013-03-12 9:09 ` Roger Quadros
2013-03-08 10:46 ` Marc Kleine-Budde
2013-03-08 10:46 ` Marc Kleine-Budde
2013-03-08 15:04 ` Roger Quadros
2013-03-08 15:04 ` Roger Quadros
[not found] ` <5139C174.7030401-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-08 15:45 ` Marc Kleine-Budde
2013-03-08 15:45 ` Marc Kleine-Budde
[not found] ` <513A079A.1020106-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-11 8:40 ` Roger Quadros
2013-03-11 8:40 ` Roger Quadros
2013-03-11 15:53 ` Marc Kleine-Budde
2013-03-11 15:53 ` Marc Kleine-Budde
[not found] ` <1359993540-20780-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-04 15:58 ` [PATCH 02/13] USB: phy: nop: Defer probe if device needs VCC/RESET Roger Quadros
2013-02-04 15:58 ` Roger Quadros
[not found] ` <1359993540-20780-3-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-05 5:54 ` kishon
2013-02-05 5:54 ` kishon
2013-02-05 8:44 ` Roger Quadros
2013-02-05 8:44 ` Roger Quadros
2013-02-05 9:09 ` Felipe Balbi
2013-02-05 9:09 ` Felipe Balbi
2013-02-05 9:43 ` Roger Quadros
2013-02-05 9:43 ` Roger Quadros
[not found] ` <5110D45A.3040007-l0cyMroinI0@public.gmane.org>
2013-03-11 15:58 ` Marc Kleine-Budde
2013-03-11 15:58 ` Marc Kleine-Budde
2013-03-12 9:10 ` Roger Quadros
2013-03-12 9:10 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 03/13] mfd: omap-usb-tll: move configuration code to omap_tll_init() Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 04/13] mfd: omap-usb-tll: Add device tree support Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-05 6:04 ` kishon
2013-02-05 6:04 ` kishon
[not found] ` <5110A0DF.7050609-l0cyMroinI0@public.gmane.org>
2013-02-05 8:46 ` Roger Quadros
2013-02-05 8:46 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information Roger Quadros
2013-02-04 15:58 ` Roger Quadros
[not found] ` <1359993540-20780-10-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-05 6:16 ` kishon
2013-02-05 6:16 ` kishon
[not found] ` <5110A3C6.6040808-l0cyMroinI0@public.gmane.org>
2013-02-05 8:50 ` Roger Quadros
2013-02-05 8:50 ` Roger Quadros
2013-02-05 10:58 ` Roger Quadros
2013-02-05 10:58 ` Roger Quadros
[not found] ` <5110E5C4.1000501-l0cyMroinI0@public.gmane.org>
2013-02-05 12:11 ` kishon
2013-02-05 12:11 ` kishon
2013-02-05 12:27 ` Roger Quadros
2013-02-05 12:27 ` Roger Quadros
2013-02-05 14:20 ` Mark Rutland
2013-02-05 14:20 ` Mark Rutland
2013-02-05 14:42 ` Roger Quadros
2013-02-05 14:42 ` Roger Quadros
2013-02-05 16:11 ` Mark Rutland
2013-02-05 16:11 ` Mark Rutland
[not found] ` <20130205161141.GD26842-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-02-06 8:56 ` Roger Quadros
2013-02-06 8:56 ` Roger Quadros
2013-02-04 15:59 ` [PATCH 13/13] ARM: dts: omap3-beagle: Add USB Host support Roger Quadros
2013-02-04 15:59 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 05/13] USB: ehci-omap: Get platform resources by index rather than by name Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-04 21:12 ` Alan Stern
2013-02-04 21:12 ` Alan Stern
2013-02-04 15:58 ` [PATCH 06/13] USB: ohci-omap3: " Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-04 21:12 ` Alan Stern
2013-02-04 21:12 ` Alan Stern
2013-02-04 15:58 ` [PATCH 07/13] USB: ohci-omap3: Add device tree support and binding information Roger Quadros
2013-02-04 15:58 ` Roger Quadros
[not found] ` <1359993540-20780-8-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-04 21:14 ` Alan Stern
2013-02-04 21:14 ` Alan Stern
2013-02-04 15:58 ` [PATCH 08/13] USB: ehci-omap: " Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-04 21:15 ` Alan Stern
2013-02-04 21:15 ` Alan Stern
2013-02-05 12:33 ` Mark Rutland
2013-02-05 12:33 ` Mark Rutland
[not found] ` <20130205123346.GB26842-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-02-05 12:46 ` Roger Quadros
2013-02-05 12:46 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 10/13] ARM: dts: OMAP4: Add HS USB Host IP nodes Roger Quadros
2013-02-04 15:58 ` Roger Quadros
[not found] ` <1359993540-20780-11-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-05 6:24 ` kishon
2013-02-05 6:24 ` kishon
2013-02-05 8:54 ` Roger Quadros
2013-02-05 8:54 ` Roger Quadros
[not found] ` <5110C8CE.2020606-l0cyMroinI0@public.gmane.org>
2013-02-05 8:57 ` kishon [this message]
2013-02-05 8:57 ` kishon
2013-02-05 7:41 ` Felipe Balbi
2013-02-05 7:41 ` Felipe Balbi
2013-02-05 8:57 ` Roger Quadros
2013-02-05 8:57 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 11/13] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-02-04 15:58 ` Roger Quadros
[not found] ` <1359993540-20780-12-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-05 9:34 ` how to specify an OMAP clock in device tree? Roger Quadros
[not found] ` <5110D229.1000808-l0cyMroinI0@public.gmane.org>
2013-02-05 11:15 ` Rajendra Nayak
2013-02-05 11:15 ` Rajendra Nayak
2013-02-05 13:46 ` Roger Quadros
2013-02-05 13:46 ` Roger Quadros
[not found] ` <51110D4B.50904-l0cyMroinI0@public.gmane.org>
2013-02-05 14:13 ` Rajendra Nayak
2013-02-05 14:13 ` Rajendra Nayak
2013-02-05 14:18 ` Roger Quadros
2013-02-05 14:18 ` Roger Quadros
2013-02-05 14:21 ` Rajendra Nayak
2013-02-05 14:21 ` Rajendra Nayak
2013-02-05 14:29 ` Roger Quadros
2013-02-05 14:29 ` Roger Quadros
[not found] ` <51111739.2050805-l0cyMroinI0@public.gmane.org>
2013-02-05 14:36 ` Rajendra Nayak
2013-02-05 14:36 ` Rajendra Nayak
2013-02-05 14:52 ` Roger Quadros
2013-02-05 14:52 ` Roger Quadros
2013-02-06 10:21 ` Rajendra Nayak
2013-02-06 10:21 ` Rajendra Nayak
[not found] ` <51122EC0.3040804-l0cyMroinI0@public.gmane.org>
2013-02-06 10:39 ` Roger Quadros
2013-02-06 10:39 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 12/13] ARM: dts: OMAP3: Add HS USB Host IP nodes Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-05 11:25 ` [PATCH 00/13] Device tree support for OMAP HS USB Host Rajendra Nayak
2013-02-05 11:25 ` Rajendra Nayak
[not found] ` <5110EC0D.40609-l0cyMroinI0@public.gmane.org>
2013-02-05 11:32 ` Roger Quadros
2013-02-05 11:32 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5110C95F.9070500@ti.com \
--to=kishon-l0cymroini0@public.gmane.org \
--cc=b-cousson-l0cyMroinI0@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=rnayak-l0cyMroinI0@public.gmane.org \
--cc=rogerq-l0cyMroinI0@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.