All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: tony@atomide.com, b-cousson@ti.com, balbi@ti.com,
	stern@rowland.harvard.edu, linux@arm.linux.org.uk,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	paul@pwsan.com
Subject: Re: how to specify an OMAP clock in device tree?
Date: Tue, 5 Feb 2013 16:29:13 +0200	[thread overview]
Message-ID: <51111739.2050805@ti.com> (raw)
In-Reply-To: <5111157D.7040803@ti.com>

On 02/05/2013 04:21 PM, Rajendra Nayak wrote:
> On Tuesday 05 February 2013 07:48 PM, Roger Quadros wrote:
>> On 02/05/2013 04:13 PM, Rajendra Nayak wrote:
>>> On Tuesday 05 February 2013 07:16 PM, Roger Quadros wrote:
>>>> Fixing the device name doesn't really solve the problem.
>>>> Not all OMAP boards will use the same clock for the external device.
>>>
>>> Are you saying different OMAP boards will use different Internal clocks?
>>> Or different OMAP boards will use a single Internal clock or an
>>> external one.
>>>
>> All I was saying is that one board can use for example auxclk1 whereas another
>> one can use auxclk3, both generated by OMAP for the same PHY configuration.
> 
> Ok, so lets keep DT aside for a while. How would something like this
> work in a non-DT world? Would the driver then be able to do a
> clk_get(dev, "main_clk"); and get say auxclk1 on one board and
> auxclk3 on another?
> 

Yes, all you need to do is specify an alias to the clock in the board file.

e.g. in board 1 file
	clk_add_alias("main_clk", "phy.1", "auxclk1_ck", NULL);

in board 2 file
	clk_add_alias("main_clk", "phy.1", "auxclk3_ck", NULL);

cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: how to specify an OMAP clock in device tree?
Date: Tue, 5 Feb 2013 16:29:13 +0200	[thread overview]
Message-ID: <51111739.2050805@ti.com> (raw)
In-Reply-To: <5111157D.7040803@ti.com>

On 02/05/2013 04:21 PM, Rajendra Nayak wrote:
> On Tuesday 05 February 2013 07:48 PM, Roger Quadros wrote:
>> On 02/05/2013 04:13 PM, Rajendra Nayak wrote:
>>> On Tuesday 05 February 2013 07:16 PM, Roger Quadros wrote:
>>>> Fixing the device name doesn't really solve the problem.
>>>> Not all OMAP boards will use the same clock for the external device.
>>>
>>> Are you saying different OMAP boards will use different Internal clocks?
>>> Or different OMAP boards will use a single Internal clock or an
>>> external one.
>>>
>> All I was saying is that one board can use for example auxclk1 whereas another
>> one can use auxclk3, both generated by OMAP for the same PHY configuration.
> 
> Ok, so lets keep DT aside for a while. How would something like this
> work in a non-DT world? Would the driver then be able to do a
> clk_get(dev, "main_clk"); and get say auxclk1 on one board and
> auxclk3 on another?
> 

Yes, all you need to do is specify an alias to the clock in the board file.

e.g. in board 1 file
	clk_add_alias("main_clk", "phy.1", "auxclk1_ck", NULL);

in board 2 file
	clk_add_alias("main_clk", "phy.1", "auxclk3_ck", NULL);

cheers,
-roger

  reply	other threads:[~2013-02-05 14:29 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 15:58 [PATCH 00/13] Device tree support for OMAP HS USB Host Roger Quadros
2013-02-04 15:58 ` Roger Quadros
2013-02-04 15:58 ` [PATCH 01/13] usb: phy: nop: Add device tree support and binding information Roger Quadros
2013-02-04 15:58   ` Roger Quadros
2013-02-05  7:26   ` Felipe Balbi
2013-02-05  7:26     ` Felipe Balbi
2013-02-05  8:30     ` Roger Quadros
2013-02-05  8:30       ` Roger Quadros
     [not found]       ` <5110C339.7080109-l0cyMroinI0@public.gmane.org>
2013-02-05  9:07         ` Felipe Balbi
2013-02-05  9:07           ` Felipe Balbi
     [not found]     ` <20130205072637.GA32118-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-03-11 15:52       ` Marc Kleine-Budde
2013-03-11 15:52         ` Marc Kleine-Budde
     [not found]         ` <513DFDD7.7000801-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-12  9:09           ` Roger Quadros
2013-03-12  9:09             ` Roger Quadros
2013-03-08 10:46   ` Marc Kleine-Budde
2013-03-08 10:46     ` Marc Kleine-Budde
2013-03-08 15:04     ` Roger Quadros
2013-03-08 15:04       ` Roger Quadros
     [not found]     ` <5139C174.7030401-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-08 15:45       ` Marc Kleine-Budde
2013-03-08 15:45         ` Marc Kleine-Budde
     [not found]         ` <513A079A.1020106-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-11  8:40           ` Roger Quadros
2013-03-11  8:40             ` Roger Quadros
2013-03-11 15:53             ` Marc Kleine-Budde
2013-03-11 15:53               ` Marc Kleine-Budde
     [not found] ` <1359993540-20780-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-04 15:58   ` [PATCH 02/13] USB: phy: nop: Defer probe if device needs VCC/RESET Roger Quadros
2013-02-04 15:58     ` Roger Quadros
     [not found]     ` <1359993540-20780-3-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-05  5:54       ` kishon
2013-02-05  5:54         ` kishon
2013-02-05  8:44         ` Roger Quadros
2013-02-05  8:44           ` Roger Quadros
2013-02-05  9:09           ` Felipe Balbi
2013-02-05  9:09             ` Felipe Balbi
2013-02-05  9:43             ` Roger Quadros
2013-02-05  9:43               ` Roger Quadros
     [not found]               ` <5110D45A.3040007-l0cyMroinI0@public.gmane.org>
2013-03-11 15:58                 ` Marc Kleine-Budde
2013-03-11 15:58                   ` Marc Kleine-Budde
2013-03-12  9:10                   ` Roger Quadros
2013-03-12  9:10                     ` Roger Quadros
2013-02-04 15:58   ` [PATCH 03/13] mfd: omap-usb-tll: move configuration code to omap_tll_init() Roger Quadros
2013-02-04 15:58     ` Roger Quadros
2013-02-04 15:58   ` [PATCH 04/13] mfd: omap-usb-tll: Add device tree support Roger Quadros
2013-02-04 15:58     ` Roger Quadros
2013-02-05  6:04     ` kishon
2013-02-05  6:04       ` kishon
     [not found]       ` <5110A0DF.7050609-l0cyMroinI0@public.gmane.org>
2013-02-05  8:46         ` Roger Quadros
2013-02-05  8:46           ` Roger Quadros
2013-02-04 15:58   ` [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information Roger Quadros
2013-02-04 15:58     ` Roger Quadros
     [not found]     ` <1359993540-20780-10-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-05  6:16       ` kishon
2013-02-05  6:16         ` kishon
     [not found]         ` <5110A3C6.6040808-l0cyMroinI0@public.gmane.org>
2013-02-05  8:50           ` Roger Quadros
2013-02-05  8:50             ` Roger Quadros
2013-02-05 10:58           ` Roger Quadros
2013-02-05 10:58             ` Roger Quadros
     [not found]             ` <5110E5C4.1000501-l0cyMroinI0@public.gmane.org>
2013-02-05 12:11               ` kishon
2013-02-05 12:11                 ` kishon
2013-02-05 12:27                 ` Roger Quadros
2013-02-05 12:27                   ` Roger Quadros
2013-02-05 14:20       ` Mark Rutland
2013-02-05 14:20         ` Mark Rutland
2013-02-05 14:42         ` Roger Quadros
2013-02-05 14:42           ` Roger Quadros
2013-02-05 16:11           ` Mark Rutland
2013-02-05 16:11             ` Mark Rutland
     [not found]             ` <20130205161141.GD26842-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-02-06  8:56               ` Roger Quadros
2013-02-06  8:56                 ` Roger Quadros
2013-02-04 15:59   ` [PATCH 13/13] ARM: dts: omap3-beagle: Add USB Host support Roger Quadros
2013-02-04 15:59     ` Roger Quadros
2013-02-04 15:58 ` [PATCH 05/13] USB: ehci-omap: Get platform resources by index rather than by name Roger Quadros
2013-02-04 15:58   ` Roger Quadros
2013-02-04 21:12   ` Alan Stern
2013-02-04 21:12     ` Alan Stern
2013-02-04 15:58 ` [PATCH 06/13] USB: ohci-omap3: " Roger Quadros
2013-02-04 15:58   ` Roger Quadros
2013-02-04 21:12   ` Alan Stern
2013-02-04 21:12     ` Alan Stern
2013-02-04 15:58 ` [PATCH 07/13] USB: ohci-omap3: Add device tree support and binding information Roger Quadros
2013-02-04 15:58   ` Roger Quadros
     [not found]   ` <1359993540-20780-8-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-04 21:14     ` Alan Stern
2013-02-04 21:14       ` Alan Stern
2013-02-04 15:58 ` [PATCH 08/13] USB: ehci-omap: " Roger Quadros
2013-02-04 15:58   ` Roger Quadros
2013-02-04 21:15   ` Alan Stern
2013-02-04 21:15     ` Alan Stern
2013-02-05 12:33   ` Mark Rutland
2013-02-05 12:33     ` Mark Rutland
     [not found]     ` <20130205123346.GB26842-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-02-05 12:46       ` Roger Quadros
2013-02-05 12:46         ` Roger Quadros
2013-02-04 15:58 ` [PATCH 10/13] ARM: dts: OMAP4: Add HS USB Host IP nodes Roger Quadros
2013-02-04 15:58   ` Roger Quadros
     [not found]   ` <1359993540-20780-11-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-05  6:24     ` kishon
2013-02-05  6:24       ` kishon
2013-02-05  8:54       ` Roger Quadros
2013-02-05  8:54         ` Roger Quadros
     [not found]         ` <5110C8CE.2020606-l0cyMroinI0@public.gmane.org>
2013-02-05  8:57           ` kishon
2013-02-05  8:57             ` kishon
2013-02-05  7:41   ` Felipe Balbi
2013-02-05  7:41     ` Felipe Balbi
2013-02-05  8:57     ` Roger Quadros
2013-02-05  8:57       ` Roger Quadros
2013-02-04 15:58 ` [PATCH 11/13] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-02-04 15:58   ` Roger Quadros
     [not found]   ` <1359993540-20780-12-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-02-05  9:34     ` how to specify an OMAP clock in device tree? Roger Quadros
     [not found]       ` <5110D229.1000808-l0cyMroinI0@public.gmane.org>
2013-02-05 11:15         ` Rajendra Nayak
2013-02-05 11:15           ` Rajendra Nayak
2013-02-05 13:46           ` Roger Quadros
2013-02-05 13:46             ` Roger Quadros
     [not found]             ` <51110D4B.50904-l0cyMroinI0@public.gmane.org>
2013-02-05 14:13               ` Rajendra Nayak
2013-02-05 14:13                 ` Rajendra Nayak
2013-02-05 14:18                 ` Roger Quadros
2013-02-05 14:18                   ` Roger Quadros
2013-02-05 14:21                   ` Rajendra Nayak
2013-02-05 14:21                     ` Rajendra Nayak
2013-02-05 14:29                     ` Roger Quadros [this message]
2013-02-05 14:29                       ` Roger Quadros
     [not found]                       ` <51111739.2050805-l0cyMroinI0@public.gmane.org>
2013-02-05 14:36                         ` Rajendra Nayak
2013-02-05 14:36                           ` Rajendra Nayak
2013-02-05 14:52                           ` Roger Quadros
2013-02-05 14:52                             ` Roger Quadros
2013-02-06 10:21                             ` Rajendra Nayak
2013-02-06 10:21                               ` Rajendra Nayak
     [not found]                               ` <51122EC0.3040804-l0cyMroinI0@public.gmane.org>
2013-02-06 10:39                                 ` Roger Quadros
2013-02-06 10:39                                   ` Roger Quadros
2013-02-04 15:58 ` [PATCH 12/13] ARM: dts: OMAP3: Add HS USB Host IP nodes Roger Quadros
2013-02-04 15:58   ` Roger Quadros
2013-02-05 11:25 ` [PATCH 00/13] Device tree support for OMAP HS USB Host Rajendra Nayak
2013-02-05 11:25   ` Rajendra Nayak
     [not found]   ` <5110EC0D.40609-l0cyMroinI0@public.gmane.org>
2013-02-05 11:32     ` Roger Quadros
2013-02-05 11:32       ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51111739.2050805@ti.com \
    --to=rogerq@ti.com \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.