All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <tcminyard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Cc: "Corey Minyard"
	<cminyard-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>,
	"Bruno Prémont"
	<bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org>,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	"Linux Kernel"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] Move console redirect to pid namespace
Date: Fri, 15 Feb 2013 08:50:26 -0600	[thread overview]
Message-ID: <511E4B32.3030003@acm.org> (raw)
In-Reply-To: <87d2w29pdo.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>

On 02/14/2013 10:23 PM, Eric W. Biederman wrote:
>
>>> With recent changes this is tied to the initial user namespace.  So the
>>> simple solution to this and so many other similiar security problems is
>>> to run your container in a user namespace.
>>>
>>> The permission check currently is capable(CAP_SYS_ADMIN) which requires
>>> the caller to have the CAP_SYS_ADMIN in the initial user namespace.
>> I'm not sure I follow.  Are these changes in k.org, or in another
>> repository someplace?
> In k.org. 3.7 would work. 3.8-rcX would work even better.
>
> root in a user namespace does not have permission to call TIOCCONS.

Ok, that's good enough for me.  I don't have a compelling reason to make 
it work, beyond liking consistency.

Thank you,

-corey

WARNING: multiple messages have this Message-ID (diff)
From: Corey Minyard <tcminyard@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>,
	"Corey Minyard" <cminyard@mvista.com>,
	containers@lists.linux-foundation.org,
	"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Move console redirect to pid namespace
Date: Fri, 15 Feb 2013 08:50:26 -0600	[thread overview]
Message-ID: <511E4B32.3030003@acm.org> (raw)
In-Reply-To: <87d2w29pdo.fsf@xmission.com>

On 02/14/2013 10:23 PM, Eric W. Biederman wrote:
>
>>> With recent changes this is tied to the initial user namespace.  So the
>>> simple solution to this and so many other similiar security problems is
>>> to run your container in a user namespace.
>>>
>>> The permission check currently is capable(CAP_SYS_ADMIN) which requires
>>> the caller to have the CAP_SYS_ADMIN in the initial user namespace.
>> I'm not sure I follow.  Are these changes in k.org, or in another
>> repository someplace?
> In k.org. 3.7 would work. 3.8-rcX would work even better.
>
> root in a user namespace does not have permission to call TIOCCONS.

Ok, that's good enough for me.  I don't have a compelling reason to make 
it work, beyond liking consistency.

Thank you,

-corey

  parent reply	other threads:[~2013-02-15 14:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-09  2:28 [PATCH] Move console redirect to pid namespace minyard
     [not found] ` <1360376920-30824-1-git-send-email-minyard-HInyCGIudOg@public.gmane.org>
2013-02-09 18:14   ` Bruno Prémont
2013-02-09 18:14     ` Bruno Prémont
     [not found]     ` <20130209191409.643c3d7f-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2013-02-13 19:08       ` Eric W. Biederman
2013-02-13 19:08         ` Eric W. Biederman
     [not found]         ` <87r4kkuj4o.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-02-15  2:08           ` Corey Minyard
2013-02-15  2:08             ` Corey Minyard
     [not found]             ` <511D9890.1040900-HInyCGIudOg@public.gmane.org>
2013-02-15  4:23               ` Eric W. Biederman
2013-02-15  4:23                 ` Eric W. Biederman
     [not found]                 ` <87d2w29pdo.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-02-15 14:50                   ` Corey Minyard [this message]
2013-02-15 14:50                     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511E4B32.3030003@acm.org \
    --to=tcminyard-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org \
    --cc=cminyard-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=minyard-HInyCGIudOg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.