From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Paul Walmsley <paul@pwsan.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency
Date: Sat, 16 Feb 2013 11:01:00 +0530 [thread overview]
Message-ID: <511F1994.90101@ti.com> (raw)
In-Reply-To: <20130215163031.GA5724@atomide.com>
On Friday 15 February 2013 10:00 PM, Tony Lindgren wrote:
> * Santosh Shilimkar <santosh.shilimkar@ti.com> [130215 05:34]:
>> On Friday 15 February 2013 06:57 PM, Russell King - ARM Linux wrote:
>>> On Fri, Feb 15, 2013 at 06:56:47PM +0530, Santosh Shilimkar wrote:
>>>> Whats your view on use of arch_ioremap_caller() hook ? This can allow
>>>> us to avoid the dual ioremap() issue discussed here if the hook
>>>> maintains the list of mapped ios.
>>>>
>>>> I was even thinking of having such intelligence within the core
>>>> ioremap code but thought that might be too invasive.
>>>
>>> Why do you even need it? There's no problem with ioremapping the same
>>> space multiple times (you end up with multiple mappings but that
>>> shouldn't be a problem, except for the additional space used.)
>>>
>> It just waste of iospace and Tony insisted to have just single ioremap()
>> hence all this discussion
>
> The main goal is to avoid duplicating data both in hwmod and DT.
> That's pretty much solved as we can have the driver probe populate
> the common data for hwmod from DT as Santosh has already demonstrated.
>
Right.
> Then we also want the driver specific idle and reset code to be done
> in the drivers rather than in hwmod and glue it together with hwmod
> using runtime PM. The biggest issue there is how do we reset and idle
> some piece of hardware for PM purposes when there's no driver loaded.
>
Driver idle functions is getting sorted out. There is no need for driver
to fiddle around it since PM runtime back-end can take care of of it.
One attempt to clean that is here [1]
For the reset, we need to have a generic runtime hook as discussed and
that should take care of reset as well. That way driver just calls
generic
> For the duplicate ioremapping, I don't think there's any need to
> do it if we get things right.
>
Good to know. So overall, I think we do have a way to move forward
and get right things done.
Regards,
Santosh
[1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg85177.html
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency
Date: Sat, 16 Feb 2013 11:01:00 +0530 [thread overview]
Message-ID: <511F1994.90101@ti.com> (raw)
In-Reply-To: <20130215163031.GA5724@atomide.com>
On Friday 15 February 2013 10:00 PM, Tony Lindgren wrote:
> * Santosh Shilimkar <santosh.shilimkar@ti.com> [130215 05:34]:
>> On Friday 15 February 2013 06:57 PM, Russell King - ARM Linux wrote:
>>> On Fri, Feb 15, 2013 at 06:56:47PM +0530, Santosh Shilimkar wrote:
>>>> Whats your view on use of arch_ioremap_caller() hook ? This can allow
>>>> us to avoid the dual ioremap() issue discussed here if the hook
>>>> maintains the list of mapped ios.
>>>>
>>>> I was even thinking of having such intelligence within the core
>>>> ioremap code but thought that might be too invasive.
>>>
>>> Why do you even need it? There's no problem with ioremapping the same
>>> space multiple times (you end up with multiple mappings but that
>>> shouldn't be a problem, except for the additional space used.)
>>>
>> It just waste of iospace and Tony insisted to have just single ioremap()
>> hence all this discussion
>
> The main goal is to avoid duplicating data both in hwmod and DT.
> That's pretty much solved as we can have the driver probe populate
> the common data for hwmod from DT as Santosh has already demonstrated.
>
Right.
> Then we also want the driver specific idle and reset code to be done
> in the drivers rather than in hwmod and glue it together with hwmod
> using runtime PM. The biggest issue there is how do we reset and idle
> some piece of hardware for PM purposes when there's no driver loaded.
>
Driver idle functions is getting sorted out. There is no need for driver
to fiddle around it since PM runtime back-end can take care of of it.
One attempt to clean that is here [1]
For the reset, we need to have a generic runtime hook as discussed and
that should take care of reset as well. That way driver just calls
generic
> For the duplicate ioremapping, I don't think there's any need to
> do it if we get things right.
>
Good to know. So overall, I think we do have a way to move forward
and get right things done.
Regards,
Santosh
[1] http://www.mail-archive.com/linux-omap at vger.kernel.org/msg85177.html
next prev parent reply other threads:[~2013-02-16 5:29 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 11:15 [RFC/NOT FOR MERGING 1/3] arm: omap: use generic implementation if !od Felipe Balbi
2013-02-14 11:15 ` Felipe Balbi
2013-02-14 11:15 ` [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency Felipe Balbi
2013-02-14 17:12 ` Tony Lindgren
2013-02-14 17:12 ` Tony Lindgren
2013-02-14 17:56 ` Felipe Balbi
2013-02-14 17:56 ` Felipe Balbi
2013-02-14 18:12 ` Tony Lindgren
2013-02-14 18:12 ` Tony Lindgren
2013-02-14 19:27 ` Felipe Balbi
2013-02-14 19:27 ` Felipe Balbi
2013-02-14 19:39 ` Tony Lindgren
2013-02-14 19:39 ` Tony Lindgren
2013-02-14 20:47 ` Paul Walmsley
2013-02-14 20:47 ` Paul Walmsley
2013-02-14 21:40 ` Paul Walmsley
2013-02-14 21:40 ` Paul Walmsley
2013-02-14 22:47 ` Tony Lindgren
2013-02-14 22:47 ` Tony Lindgren
2013-02-15 6:46 ` Felipe Balbi
2013-02-15 6:46 ` Felipe Balbi
2013-02-15 7:29 ` Santosh Shilimkar
2013-02-15 7:29 ` Santosh Shilimkar
2013-02-19 15:30 ` Paul Walmsley
2013-02-19 15:30 ` Paul Walmsley
2013-02-19 15:45 ` Russell King - ARM Linux
2013-02-19 15:45 ` Russell King - ARM Linux
2013-02-19 16:30 ` Tony Lindgren
2013-02-19 16:30 ` Tony Lindgren
2013-02-19 18:22 ` Russell King - ARM Linux
2013-02-19 18:22 ` Russell King - ARM Linux
2013-02-19 19:31 ` Tony Lindgren
2013-02-19 19:31 ` Tony Lindgren
2013-02-19 19:43 ` hwmod data duplication (was: Re: [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency) Felipe Balbi
2013-02-19 19:43 ` Felipe Balbi
2013-02-19 22:09 ` Tony Lindgren
2013-02-19 22:09 ` Tony Lindgren
2013-02-19 22:22 ` Felipe Balbi
2013-02-19 22:22 ` Felipe Balbi
2013-02-19 22:31 ` Tony Lindgren
2013-02-19 22:31 ` Tony Lindgren
2013-02-19 22:51 ` Felipe Balbi
2013-02-19 22:51 ` Felipe Balbi
2013-02-15 10:26 ` [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency Russell King - ARM Linux
2013-02-15 10:26 ` Russell King - ARM Linux
2013-02-14 21:56 ` Paul Walmsley
2013-02-14 21:56 ` Paul Walmsley
2013-02-14 22:22 ` Tony Lindgren
2013-02-14 22:22 ` Tony Lindgren
2013-02-15 6:53 ` Felipe Balbi
2013-02-15 6:53 ` Felipe Balbi
2013-02-15 7:27 ` Bedia, Vaibhav
2013-02-15 7:27 ` Bedia, Vaibhav
2013-02-19 15:27 ` Paul Walmsley
2013-02-19 15:27 ` Paul Walmsley
2013-02-19 16:38 ` Tony Lindgren
2013-02-19 16:38 ` Tony Lindgren
2013-02-19 16:57 ` Felipe Balbi
2013-02-19 16:57 ` Felipe Balbi
2013-02-19 17:43 ` Tony Lindgren
2013-02-19 17:43 ` Tony Lindgren
2013-02-19 18:34 ` Felipe Balbi
2013-02-19 18:34 ` Felipe Balbi
2013-02-19 19:16 ` Kevin Hilman
2013-02-19 19:16 ` Kevin Hilman
2013-02-19 19:32 ` Felipe Balbi
2013-02-19 19:32 ` Felipe Balbi
2013-02-19 19:50 ` Kevin Hilman
2013-02-19 19:50 ` Kevin Hilman
2013-02-19 20:10 ` OMAP reset requirements (was: Re: [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency) ^[:x Felipe Balbi
2013-02-19 20:10 ` OMAP reset requirements (was: Re: [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency)^[:x Felipe Balbi
2013-02-19 20:25 ` OMAP reset requirements Kevin Hilman
2013-02-19 20:25 ` Kevin Hilman
2013-02-20 6:26 ` [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency Santosh Shilimkar
2013-02-20 6:26 ` Santosh Shilimkar
2013-02-15 6:44 ` Felipe Balbi
2013-02-15 6:44 ` Felipe Balbi
2013-02-15 7:27 ` Bedia, Vaibhav
2013-02-15 7:27 ` Bedia, Vaibhav
2013-02-20 17:38 ` Paul Walmsley
2013-02-20 17:38 ` Paul Walmsley
2013-02-20 19:16 ` Felipe Balbi
2013-02-20 19:16 ` Felipe Balbi
2013-02-20 20:03 ` Paul Walmsley
2013-02-20 20:03 ` Paul Walmsley
2013-02-20 20:37 ` Russell King - ARM Linux
2013-02-20 20:37 ` Russell King - ARM Linux
2013-02-21 10:16 ` Peter De Schrijver
2013-02-21 10:16 ` Peter De Schrijver
2013-02-21 12:09 ` Peter Korsgaard
2013-02-21 12:09 ` Peter Korsgaard
2013-02-15 10:16 ` Russell King - ARM Linux
2013-02-15 10:16 ` Russell King - ARM Linux
2013-02-15 13:26 ` Santosh Shilimkar
2013-02-15 13:26 ` Santosh Shilimkar
2013-02-15 13:27 ` Russell King - ARM Linux
2013-02-15 13:27 ` Russell King - ARM Linux
2013-02-15 13:31 ` Santosh Shilimkar
2013-02-15 13:31 ` Santosh Shilimkar
2013-02-15 16:30 ` Tony Lindgren
2013-02-15 16:30 ` Tony Lindgren
2013-02-15 16:42 ` Felipe Balbi
2013-02-15 16:42 ` Felipe Balbi
2013-02-16 6:01 ` Santosh Shilimkar
2013-02-16 6:01 ` Santosh Shilimkar
2013-02-16 8:55 ` Felipe Balbi
2013-02-16 8:55 ` Felipe Balbi
2013-02-16 9:17 ` Santosh Shilimkar
2013-02-16 9:17 ` Santosh Shilimkar
2013-02-16 9:22 ` Felipe Balbi
2013-02-16 9:22 ` Felipe Balbi
2013-02-16 9:31 ` Santosh Shilimkar
2013-02-16 9:31 ` Santosh Shilimkar
2013-02-18 15:27 ` Kevin Hilman
2013-02-18 15:27 ` Kevin Hilman
2013-02-16 5:31 ` Santosh Shilimkar [this message]
2013-02-16 5:31 ` Santosh Shilimkar
2013-02-16 5:36 ` Nicolas Pitre
2013-02-16 5:36 ` Nicolas Pitre
2013-02-16 5:48 ` Santosh Shilimkar
2013-02-16 5:48 ` Santosh Shilimkar
2013-02-18 8:08 ` Bedia, Vaibhav
2013-02-18 8:08 ` Bedia, Vaibhav
2013-02-18 8:28 ` Santosh Shilimkar
2013-02-18 8:28 ` Santosh Shilimkar
2013-02-15 15:40 ` Kevin Hilman
2013-02-15 15:40 ` Kevin Hilman
2013-02-15 16:03 ` Felipe Balbi
2013-02-15 16:03 ` Felipe Balbi
2013-02-16 4:59 ` Santosh Shilimkar
2013-02-16 4:59 ` Santosh Shilimkar
2013-02-18 14:52 ` Kevin Hilman
2013-02-18 14:52 ` Kevin Hilman
2013-02-14 11:15 ` [RFC/NOT FOR MERGING 3/3] arm: boot: dts: omap: remove ti_hwmods from UART ports Felipe Balbi
2013-02-14 11:20 ` [RFC/NOT FOR MERGING 1/3] arm: omap: use generic implementation if !od Russell King - ARM Linux
2013-02-14 11:20 ` Russell King - ARM Linux
2013-02-14 17:57 ` Felipe Balbi
2013-02-14 17:57 ` Felipe Balbi
2013-02-15 15:28 ` Kevin Hilman
2013-02-15 15:28 ` Kevin Hilman
2013-02-15 16:04 ` Felipe Balbi
2013-02-15 16:04 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511F1994.90101@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.