All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] can-utils: AOSP build improvements
@ 2013-02-18  8:06 yegorslists
  2013-02-18  8:15 ` Marc Kleine-Budde
  0 siblings, 1 reply; 6+ messages in thread
From: yegorslists @ 2013-02-18  8:06 UTC (permalink / raw)
  To: linux-can; +Cc: mkl, Yegor Yefremov

From: Yegor Yefremov <yegorslists@googlemail.com>

Add local headers and GCC flags for all can-utils targets.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 Android.mk |  148 ++++++++++++++++++++++++++++++++++++++++++++----------------
 1 files changed, 109 insertions(+), 39 deletions(-)

diff --git a/Android.mk b/Android.mk
index 56a80c1..db83bbb 100755
--- a/Android.mk
+++ b/Android.mk
@@ -8,7 +8,11 @@ include $(CLEAR_VARS)
 
 LOCAL_SRC_FILES := lib.c
 LOCAL_MODULE := libcan
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_STATIC_LIBRARY)
 
@@ -22,8 +26,11 @@ LOCAL_SRC_FILES := candump.c
 LOCAL_MODULE := candump
 LOCAL_MODULE_TAGS := optional
 LOCAL_STATIC_LIBRARIES := libcan
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -37,8 +44,11 @@ LOCAL_SRC_FILES := cansend.c
 LOCAL_MODULE := cansend
 LOCAL_MODULE_TAGS := optional
 LOCAL_STATIC_LIBRARIES := libcan
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -51,8 +61,11 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := bcmserver.c
 LOCAL_MODULE := bcmserver
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -66,8 +79,11 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := can-calc-bit-timing.c
 LOCAL_MODULE := can-calc-bit-timing
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -80,8 +96,11 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := canbusload.c
 LOCAL_MODULE := canbusload
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -94,8 +113,11 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := canfdtest.c
 LOCAL_MODULE := canfdtest
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -109,8 +131,11 @@ LOCAL_SRC_FILES := cangen.c
 LOCAL_MODULE := cangen
 LOCAL_MODULE_TAGS := optional
 LOCAL_STATIC_LIBRARIES := libcan
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -123,8 +148,11 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := cangw.c
 LOCAL_MODULE := cangw
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -138,8 +166,11 @@ LOCAL_SRC_FILES := canlogserver.c
 LOCAL_MODULE := canlogserver
 LOCAL_MODULE_TAGS := optional
 LOCAL_STATIC_LIBRARIES := libcan
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -153,8 +184,11 @@ LOCAL_SRC_FILES := canplayer.c
 LOCAL_MODULE := canplayer
 LOCAL_MODULE_TAGS := optional
 LOCAL_STATIC_LIBRARIES := libcan
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -167,8 +201,11 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := cansniffer.c
 LOCAL_MODULE := cansniffer
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -182,7 +219,10 @@ LOCAL_SRC_FILES := isotpdump.c
 LOCAL_MODULE := isotpdump
 LOCAL_MODULE_TAGS := optional
 LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -196,7 +236,10 @@ LOCAL_SRC_FILES := isotprecv.c
 LOCAL_MODULE := isotprecv
 LOCAL_MODULE_TAGS := optional
 LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -210,7 +253,10 @@ LOCAL_SRC_FILES := isotpsend.c
 LOCAL_MODULE := isotpsend
 LOCAL_MODULE_TAGS := optional
 LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -224,7 +270,10 @@ LOCAL_SRC_FILES := isotpserver.c
 LOCAL_MODULE := isotpserver
 LOCAL_MODULE_TAGS := optional
 LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -238,7 +287,10 @@ LOCAL_SRC_FILES := isotpsniffer.c
 LOCAL_MODULE := isotpsniffer.c
 LOCAL_MODULE_TAGS := optional
 LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -252,7 +304,10 @@ LOCAL_SRC_FILES := isotptun.c
 LOCAL_MODULE := isotptun
 LOCAL_MODULE_TAGS := optional
 LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -266,8 +321,11 @@ LOCAL_SRC_FILES := log2asc.c
 LOCAL_MODULE := log2asc
 LOCAL_MODULE_TAGS := optional
 LOCAL_STATIC_LIBRARIES := libcan
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -281,8 +339,11 @@ LOCAL_SRC_FILES := log2long.c
 LOCAL_MODULE := log2long
 LOCAL_MODULE_TAGS := optional
 LOCAL_STATIC_LIBRARIES := libcan
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -295,8 +356,11 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := slcan_attach.c
 LOCAL_MODULE := slcan_attach
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -309,8 +373,11 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := slcand.c
 LOCAL_MODULE := slcand
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
 
@@ -323,7 +390,10 @@ include $(CLEAR_VARS)
 LOCAL_SRC_FILES := slcanpty.c
 LOCAL_MODULE := slcanpty
 LOCAL_MODULE_TAGS := optional
-LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
-LOCAL_CFLAGS := -O2 -g -W -Wall
+LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
+LOCAL_CFLAGS := -O2 -g -W -Wall \
+	    -DSO_RXQ_OVFL=40 \
+	    -DPF_CAN=29 \
+	    -DAF_CAN=PF_CAN
 
 include $(BUILD_EXECUTABLE)
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] can-utils: AOSP build improvements
  2013-02-18  8:06 [PATCH] can-utils: AOSP build improvements yegorslists
@ 2013-02-18  8:15 ` Marc Kleine-Budde
  2013-02-18  9:10   ` Yegor Yefremov
  0 siblings, 1 reply; 6+ messages in thread
From: Marc Kleine-Budde @ 2013-02-18  8:15 UTC (permalink / raw)
  To: yegorslists; +Cc: linux-can

[-- Attachment #1: Type: text/plain, Size: 10783 bytes --]

On 02/18/2013 09:06 AM, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Add local headers and GCC flags for all can-utils targets.

Can you create a variable PRIVATE_LOCAL_CFLAGS or whatever to hold the
-O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN

and reuse that?

Marc

> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  Android.mk |  148 ++++++++++++++++++++++++++++++++++++++++++++----------------
>  1 files changed, 109 insertions(+), 39 deletions(-)
> 
> diff --git a/Android.mk b/Android.mk
> index 56a80c1..db83bbb 100755
> --- a/Android.mk
> +++ b/Android.mk
> @@ -8,7 +8,11 @@ include $(CLEAR_VARS)
>  
>  LOCAL_SRC_FILES := lib.c
>  LOCAL_MODULE := libcan
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_STATIC_LIBRARY)
>  
> @@ -22,8 +26,11 @@ LOCAL_SRC_FILES := candump.c
>  LOCAL_MODULE := candump
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_STATIC_LIBRARIES := libcan
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -37,8 +44,11 @@ LOCAL_SRC_FILES := cansend.c
>  LOCAL_MODULE := cansend
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_STATIC_LIBRARIES := libcan
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -51,8 +61,11 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := bcmserver.c
>  LOCAL_MODULE := bcmserver
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -66,8 +79,11 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := can-calc-bit-timing.c
>  LOCAL_MODULE := can-calc-bit-timing
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -80,8 +96,11 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := canbusload.c
>  LOCAL_MODULE := canbusload
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -94,8 +113,11 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := canfdtest.c
>  LOCAL_MODULE := canfdtest
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -109,8 +131,11 @@ LOCAL_SRC_FILES := cangen.c
>  LOCAL_MODULE := cangen
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_STATIC_LIBRARIES := libcan
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -123,8 +148,11 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := cangw.c
>  LOCAL_MODULE := cangw
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -138,8 +166,11 @@ LOCAL_SRC_FILES := canlogserver.c
>  LOCAL_MODULE := canlogserver
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_STATIC_LIBRARIES := libcan
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -153,8 +184,11 @@ LOCAL_SRC_FILES := canplayer.c
>  LOCAL_MODULE := canplayer
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_STATIC_LIBRARIES := libcan
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -167,8 +201,11 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := cansniffer.c
>  LOCAL_MODULE := cansniffer
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -182,7 +219,10 @@ LOCAL_SRC_FILES := isotpdump.c
>  LOCAL_MODULE := isotpdump
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -196,7 +236,10 @@ LOCAL_SRC_FILES := isotprecv.c
>  LOCAL_MODULE := isotprecv
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -210,7 +253,10 @@ LOCAL_SRC_FILES := isotpsend.c
>  LOCAL_MODULE := isotpsend
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -224,7 +270,10 @@ LOCAL_SRC_FILES := isotpserver.c
>  LOCAL_MODULE := isotpserver
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -238,7 +287,10 @@ LOCAL_SRC_FILES := isotpsniffer.c
>  LOCAL_MODULE := isotpsniffer.c
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -252,7 +304,10 @@ LOCAL_SRC_FILES := isotptun.c
>  LOCAL_MODULE := isotptun
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -266,8 +321,11 @@ LOCAL_SRC_FILES := log2asc.c
>  LOCAL_MODULE := log2asc
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_STATIC_LIBRARIES := libcan
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -281,8 +339,11 @@ LOCAL_SRC_FILES := log2long.c
>  LOCAL_MODULE := log2long
>  LOCAL_MODULE_TAGS := optional
>  LOCAL_STATIC_LIBRARIES := libcan
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -295,8 +356,11 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := slcan_attach.c
>  LOCAL_MODULE := slcan_attach
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -309,8 +373,11 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := slcand.c
>  LOCAL_MODULE := slcand
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
>  
> @@ -323,7 +390,10 @@ include $(CLEAR_VARS)
>  LOCAL_SRC_FILES := slcanpty.c
>  LOCAL_MODULE := slcanpty
>  LOCAL_MODULE_TAGS := optional
> -LOCAL_C_INCLUDES := $(KERNEL_HEADERS)
> -LOCAL_CFLAGS := -O2 -g -W -Wall
> +LOCAL_C_INCLUDES := $(KERNEL_HEADERS) $(LOCAL_PATH)/include/
> +LOCAL_CFLAGS := -O2 -g -W -Wall \
> +	    -DSO_RXQ_OVFL=40 \
> +	    -DPF_CAN=29 \
> +	    -DAF_CAN=PF_CAN
>  
>  include $(BUILD_EXECUTABLE)
> 


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] can-utils: AOSP build improvements
  2013-02-18  8:15 ` Marc Kleine-Budde
@ 2013-02-18  9:10   ` Yegor Yefremov
  2013-02-18  9:21     ` Marc Kleine-Budde
  0 siblings, 1 reply; 6+ messages in thread
From: Yegor Yefremov @ 2013-02-18  9:10 UTC (permalink / raw)
  To: Marc Kleine-Budde; +Cc: linux-can@vger.kernel.org

On Mon, Feb 18, 2013 at 9:15 AM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 02/18/2013 09:06 AM, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> Add local headers and GCC flags for all can-utils targets.
>
> Can you create a variable PRIVATE_LOCAL_CFLAGS or whatever to hold the
> -O2 -g -W -Wall \
>> +         -DSO_RXQ_OVFL=40 \
>> +         -DPF_CAN=29 \
>> +         -DAF_CAN=PF_CAN
>
> and reuse that?

Thanks. That makes the code cleaner.

Btw what about isotp.h? Is it going to be mainlined?

Yegor

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] can-utils: AOSP build improvements
  2013-02-18  9:10   ` Yegor Yefremov
@ 2013-02-18  9:21     ` Marc Kleine-Budde
  2013-02-18 21:56       ` Oliver Hartkopp
  0 siblings, 1 reply; 6+ messages in thread
From: Marc Kleine-Budde @ 2013-02-18  9:21 UTC (permalink / raw)
  To: Yegor Yefremov; +Cc: linux-can@vger.kernel.org, Oliver Hartkopp

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

On 02/18/2013 10:10 AM, Yegor Yefremov wrote:
> On Mon, Feb 18, 2013 at 9:15 AM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>> On 02/18/2013 09:06 AM, yegorslists@googlemail.com wrote:
>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>
>>> Add local headers and GCC flags for all can-utils targets.
>>
>> Can you create a variable PRIVATE_LOCAL_CFLAGS or whatever to hold the
>> -O2 -g -W -Wall \
>>> +         -DSO_RXQ_OVFL=40 \
>>> +         -DPF_CAN=29 \
>>> +         -DAF_CAN=PF_CAN
>>
>> and reuse that?
> 
> Thanks. That makes the code cleaner.
> 
> Btw what about isotp.h? Is it going to be mainlined?

That's Oliver's cup of tea :)

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] can-utils: AOSP build improvements
  2013-02-18  9:21     ` Marc Kleine-Budde
@ 2013-02-18 21:56       ` Oliver Hartkopp
  2013-02-20  8:43         ` Kurt Van Dijck
  0 siblings, 1 reply; 6+ messages in thread
From: Oliver Hartkopp @ 2013-02-18 21:56 UTC (permalink / raw)
  To: Marc Kleine-Budde, Yegor Yefremov; +Cc: linux-can@vger.kernel.org, Michal Sojka

On 18.02.2013 10:21, Marc Kleine-Budde wrote:

> On 02/18/2013 10:10 AM, Yegor Yefremov wrote:


>>
>> Btw what about isotp.h? Is it going to be mainlined?
> 
> That's Oliver's cup of tea :)


Hm - yes :-)

Of course it is going to be mainlined.

The code itself is working properly for a long time now. The only missing
point is that i do not have a really good idea how to cope with the fact that
up to 500 CAN frames can be pushed into the CAN netdev tx queue at a time.

The advisory to increase the tx_queue_len to 1000 is not a solution.

Maybe qdiscs is a solution or we need to be able to peek the tx queue state
whether we can push the next CAN frame to the device, or if we need to wait.

Once there is a good solution for that, it should be easy to make isotp fit
for mainline inclusion.

Regards,
Oliver


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] can-utils: AOSP build improvements
  2013-02-18 21:56       ` Oliver Hartkopp
@ 2013-02-20  8:43         ` Kurt Van Dijck
  0 siblings, 0 replies; 6+ messages in thread
From: Kurt Van Dijck @ 2013-02-20  8:43 UTC (permalink / raw)
  To: Oliver Hartkopp
  Cc: Marc Kleine-Budde, Yegor Yefremov, linux-can@vger.kernel.org,
	Michal Sojka

On Mon, Feb 18, 2013 at 10:56:19PM +0100, Oliver Hartkopp wrote:
> 
> The code itself is working properly for a long time now. The only missing
> point is that i do not have a really good idea how to cope with the fact that
> up to 500 CAN frames can be pushed into the CAN netdev tx queue at a time.
> 
> The advisory to increase the tx_queue_len to 1000 is not a solution.
> 
> Maybe qdiscs is a solution or we need to be able to peek the tx queue state
> whether we can push the next CAN frame to the device, or if we need to wait.

the tx queue state thing seems very similar to what Felix asked for recently,
and I'm thinking such thing may improve any transport protocol also ...
> 
> Regards,
> Oliver
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Kurt Van Dijck
GRAMMER EiA ELECTRONICS
http://www.eia.be
kurt.van.dijck@eia.be
+32-38708534

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-20  8:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-18  8:06 [PATCH] can-utils: AOSP build improvements yegorslists
2013-02-18  8:15 ` Marc Kleine-Budde
2013-02-18  9:10   ` Yegor Yefremov
2013-02-18  9:21     ` Marc Kleine-Budde
2013-02-18 21:56       ` Oliver Hartkopp
2013-02-20  8:43         ` Kurt Van Dijck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.