All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Steffen Michalke <StMichalke-S0/GAf8tV78@public.gmane.org>
Subject: Re: PROBLEM: Crash cgdeleting empty memory cgroups with memory.kmem.limit_in_bytes set
Date: Thu, 21 Feb 2013 15:22:56 +0400	[thread overview]
Message-ID: <51260390.8010203@parallels.com> (raw)
In-Reply-To: <20130220230019.GJ3570-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>

On 02/21/2013 03:00 AM, Tejun Heo wrote:
> (cc'ing cgroup / memcg people and quoting whole body)
> 
> Looks like something is going wrong with memcg cache destruction.
> Glauber, any ideas?  Also, can we please not use names as generic as
> kmem_cache_destroy_work_func for something specific to memcg?  How
> about something like memcg_destroy_cache_workfn?
> 
> Thanks.

Steffen,

Is there any chance you could test that using SLAB instead of SLUB?
I haven't manage to reproduce it yet, but I am working on some theories
about why this is happening. If I could at least know if this is likely
a cache problem vs a inner-memcg problem, that would help. The calltrace
is not incredibly helpful, but it does indicate that the problem happens
when freeing cache objects.

WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Tejun Heo <tj@kernel.org>
Cc: Steffen Michalke <StMichalke@web.de>,
	<linux-kernel@vger.kernel.org>, "Li Zefan" <lizefan@huawei.com>,
	<containers@lists.linux-foundation.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	Balbir Singh <bsingharora@gmail.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: PROBLEM: Crash cgdeleting empty memory cgroups with memory.kmem.limit_in_bytes set
Date: Thu, 21 Feb 2013 15:22:56 +0400	[thread overview]
Message-ID: <51260390.8010203@parallels.com> (raw)
In-Reply-To: <20130220230019.GJ3570@htj.dyndns.org>

On 02/21/2013 03:00 AM, Tejun Heo wrote:
> (cc'ing cgroup / memcg people and quoting whole body)
> 
> Looks like something is going wrong with memcg cache destruction.
> Glauber, any ideas?  Also, can we please not use names as generic as
> kmem_cache_destroy_work_func for something specific to memcg?  How
> about something like memcg_destroy_cache_workfn?
> 
> Thanks.

Steffen,

Is there any chance you could test that using SLAB instead of SLUB?
I haven't manage to reproduce it yet, but I am working on some theories
about why this is happening. If I could at least know if this is likely
a cache problem vs a inner-memcg problem, that would help. The calltrace
is not incredibly helpful, but it does indicate that the problem happens
when freeing cache objects.




  parent reply	other threads:[~2013-02-21 11:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-20 15:49 PROBLEM: Crash cgdeleting empty memory cgroups with memory.kmem.limit_in_bytes set Steffen Michalke
     [not found] ` <1361375371.7786.5.camel-xN+x09LS9By1OXqM+dc5E26XGmf1S8Or@public.gmane.org>
2013-02-20 23:00   ` Tejun Heo
2013-02-20 23:00     ` Tejun Heo
     [not found]     ` <20130220230019.GJ3570-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-02-21  8:34       ` Glauber Costa
2013-02-21  8:34         ` Glauber Costa
     [not found]         ` <5125DC11.7060106-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-02-22  3:15           ` Kamezawa Hiroyuki
2013-02-22  3:15             ` Kamezawa Hiroyuki
2013-02-21 11:22       ` Glauber Costa [this message]
2013-02-21 11:22         ` Glauber Costa
     [not found]         ` <51260390.8010203-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-02-21 15:44           ` Glauber Costa
2013-02-21 15:44             ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51260390.8010203@parallels.com \
    --to=glommer-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
    --cc=StMichalke-S0/GAf8tV78@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.