From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114
Date: Tue, 26 Feb 2013 09:29:26 -0700 [thread overview]
Message-ID: <512CE2E6.5020904@wwwdotorg.org> (raw)
In-Reply-To: <1361872727-4388-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 02/26/2013 02:58 AM, Joseph Lo wrote:
> The PMC HW dose not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.
> diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
> static const struct of_device_id matches[] __initconst = {
> { .compatible = "nvidia,tegra20-pmc" },
> + { .compatible = "nvidia,tegra30-pmc" },
> + { .compatible = "nvidia,tegra114-pmc" },
> { }
> };
Those should be listed in order of most recent device through least
recent device, i.e. in the opposite order.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114
Date: Tue, 26 Feb 2013 09:29:26 -0700 [thread overview]
Message-ID: <512CE2E6.5020904@wwwdotorg.org> (raw)
In-Reply-To: <1361872727-4388-1-git-send-email-josephl@nvidia.com>
On 02/26/2013 02:58 AM, Joseph Lo wrote:
> The PMC HW dose not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.
> diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
> static const struct of_device_id matches[] __initconst = {
> { .compatible = "nvidia,tegra20-pmc" },
> + { .compatible = "nvidia,tegra30-pmc" },
> + { .compatible = "nvidia,tegra114-pmc" },
> { }
> };
Those should be listed in order of most recent device through least
recent device, i.e. in the opposite order.
next prev parent reply other threads:[~2013-02-26 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 9:58 [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114 Joseph Lo
2013-02-26 9:58 ` Joseph Lo
[not found] ` <1361872727-4388-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-26 16:29 ` Stephen Warren [this message]
2013-02-26 16:29 ` Stephen Warren
2013-02-26 21:00 ` Sergei Shtylyov
2013-02-26 21:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512CE2E6.5020904@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.