* [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114
@ 2013-02-26 9:58 ` Joseph Lo
0 siblings, 0 replies; 6+ messages in thread
From: Joseph Lo @ 2013-02-26 9:58 UTC (permalink / raw)
To: Stephen Warren
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Joseph Lo
The PMC HW dose not 100% compatible across all Tegra series. We need to
specify each of them in the DT match table.
Signed-off-by: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
arch/arm/mach-tegra/pmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
index d4fdb5f..1b5a908 100644
--- a/arch/arm/mach-tegra/pmc.c
+++ b/arch/arm/mach-tegra/pmc.c
@@ -37,6 +37,8 @@ static inline void tegra_pmc_writel(u32 val, u32 reg)
#ifdef CONFIG_OF
static const struct of_device_id matches[] __initconst = {
{ .compatible = "nvidia,tegra20-pmc" },
+ { .compatible = "nvidia,tegra30-pmc" },
+ { .compatible = "nvidia,tegra114-pmc" },
{ }
};
#endif
--
1.8.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114
@ 2013-02-26 9:58 ` Joseph Lo
0 siblings, 0 replies; 6+ messages in thread
From: Joseph Lo @ 2013-02-26 9:58 UTC (permalink / raw)
To: linux-arm-kernel
The PMC HW dose not 100% compatible across all Tegra series. We need to
specify each of them in the DT match table.
Signed-off-by: Joseph Lo <josephl@nvidia.com>
---
arch/arm/mach-tegra/pmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
index d4fdb5f..1b5a908 100644
--- a/arch/arm/mach-tegra/pmc.c
+++ b/arch/arm/mach-tegra/pmc.c
@@ -37,6 +37,8 @@ static inline void tegra_pmc_writel(u32 val, u32 reg)
#ifdef CONFIG_OF
static const struct of_device_id matches[] __initconst = {
{ .compatible = "nvidia,tegra20-pmc" },
+ { .compatible = "nvidia,tegra30-pmc" },
+ { .compatible = "nvidia,tegra114-pmc" },
{ }
};
#endif
--
1.8.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1361872727-4388-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114
2013-02-26 9:58 ` Joseph Lo
@ 2013-02-26 16:29 ` Stephen Warren
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2013-02-26 16:29 UTC (permalink / raw)
To: Joseph Lo
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 02/26/2013 02:58 AM, Joseph Lo wrote:
> The PMC HW dose not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.
> diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
> static const struct of_device_id matches[] __initconst = {
> { .compatible = "nvidia,tegra20-pmc" },
> + { .compatible = "nvidia,tegra30-pmc" },
> + { .compatible = "nvidia,tegra114-pmc" },
> { }
> };
Those should be listed in order of most recent device through least
recent device, i.e. in the opposite order.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114
@ 2013-02-26 16:29 ` Stephen Warren
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2013-02-26 16:29 UTC (permalink / raw)
To: linux-arm-kernel
On 02/26/2013 02:58 AM, Joseph Lo wrote:
> The PMC HW dose not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.
> diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
> static const struct of_device_id matches[] __initconst = {
> { .compatible = "nvidia,tegra20-pmc" },
> + { .compatible = "nvidia,tegra30-pmc" },
> + { .compatible = "nvidia,tegra114-pmc" },
> { }
> };
Those should be listed in order of most recent device through least
recent device, i.e. in the opposite order.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114
2013-02-26 9:58 ` Joseph Lo
@ 2013-02-26 21:00 ` Sergei Shtylyov
-1 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2013-02-26 21:00 UTC (permalink / raw)
To: Joseph Lo
Cc: Stephen Warren, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hello.
On 26-02-2013 13:58, Joseph Lo wrote:
Almost the same mistake.
> The PMC HW dose
s/dose/is/
> not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.
> Signed-off-by: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-26 21:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 9:58 [PATCH 1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114 Joseph Lo
2013-02-26 9:58 ` Joseph Lo
[not found] ` <1361872727-4388-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-26 16:29 ` Stephen Warren
2013-02-26 16:29 ` Stephen Warren
2013-02-26 21:00 ` Sergei Shtylyov
2013-02-26 21:00 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.