From: Rickard Andersson <rickard.andersson@stericsson.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"john.stultz@linaro.org" <john.stultz@linaro.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"patches@linaro.org" <patches@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
Date: Fri, 1 Mar 2013 14:28:18 +0100 [thread overview]
Message-ID: <5130ACF2.6070005@stericsson.com> (raw)
In-Reply-To: <CAKfTPtA=7pTPrwFHr61WiffXGv2Ztmaiji5q_vJpPj9XgyeZMg@mail.gmail.com>
On 03/01/2013 09:56 AM, Vincent Guittot wrote:
> On 1 March 2013 02:13, Linus Walleij<linus.walleij@linaro.org> wrote:
>> On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano
>> <daniel.lezcano@linaro.org> wrote:
>>
>>> Add the dynamic irq affinity feature to the timer clock device.
>>>
>>> Signed-off-by: Daniel Lezcano<daniel.lezcano@linaro.org>
>> Looks reasonable to me, sadly I do not fully grasp the patch set,
>> Vincent+Rickard can you have a look at this?
> ux500 is able to trig the wake up on one CPU and let the other one in
> WFI. This patch will minimize the spurious wake up of CPU0 when CPU1
> is the target CPU of the broadcast timer. One main consequence is that
> we will not uselessly execute all the deferrable and newly idle
> activities on the CPU0 .
>
> you can add my reviewed-by if you want
>
> Vincent
>
It looks ok to me as well.
BR
Rickard
WARNING: multiple messages have this Message-ID (diff)
From: rickard.andersson@stericsson.com (Rickard Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer
Date: Fri, 1 Mar 2013 14:28:18 +0100 [thread overview]
Message-ID: <5130ACF2.6070005@stericsson.com> (raw)
In-Reply-To: <CAKfTPtA=7pTPrwFHr61WiffXGv2Ztmaiji5q_vJpPj9XgyeZMg@mail.gmail.com>
On 03/01/2013 09:56 AM, Vincent Guittot wrote:
> On 1 March 2013 02:13, Linus Walleij<linus.walleij@linaro.org> wrote:
>> On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano
>> <daniel.lezcano@linaro.org> wrote:
>>
>>> Add the dynamic irq affinity feature to the timer clock device.
>>>
>>> Signed-off-by: Daniel Lezcano<daniel.lezcano@linaro.org>
>> Looks reasonable to me, sadly I do not fully grasp the patch set,
>> Vincent+Rickard can you have a look at this?
> ux500 is able to trig the wake up on one CPU and let the other one in
> WFI. This patch will minimize the spurious wake up of CPU0 when CPU1
> is the target CPU of the broadcast timer. One main consequence is that
> we will not uselessly execute all the deferrable and newly idle
> activities on the CPU0 .
>
> you can add my reviewed-by if you want
>
> Vincent
>
It looks ok to me as well.
BR
Rickard
next prev parent reply other threads:[~2013-03-01 13:28 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 22:17 [PATCH 0/4] time: dynamic irq affinity Daniel Lezcano
2013-02-26 22:17 ` Daniel Lezcano
2013-02-26 22:17 ` [PATCH 1/4] time : pass broadcast parameter Daniel Lezcano
2013-02-26 22:17 ` Daniel Lezcano
2013-02-27 5:09 ` Santosh Shilimkar
2013-02-27 5:09 ` Santosh Shilimkar
2013-02-27 5:09 ` Santosh Shilimkar
2013-02-26 22:17 ` [PATCH 2/4] time : set broadcast irq affinity Daniel Lezcano
2013-02-26 22:17 ` Daniel Lezcano
2013-02-27 5:33 ` Santosh Shilimkar
2013-02-27 5:33 ` Santosh Shilimkar
2013-02-27 5:33 ` Santosh Shilimkar
2013-02-26 22:17 ` [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer Daniel Lezcano
2013-02-26 22:17 ` Daniel Lezcano
2013-03-01 1:13 ` Linus Walleij
2013-03-01 1:13 ` Linus Walleij
2013-03-01 8:56 ` Vincent Guittot
2013-03-01 8:56 ` Vincent Guittot
2013-03-01 13:28 ` Rickard Andersson [this message]
2013-03-01 13:28 ` Rickard Andersson
2013-02-26 22:17 ` [PATCH 4/4] ARM: timer-sp: Set dynamic irq affinity Daniel Lezcano
2013-02-26 22:17 ` Daniel Lezcano
2013-02-27 4:56 ` Santosh Shilimkar
2013-02-27 4:56 ` Santosh Shilimkar
2013-02-27 4:56 ` Santosh Shilimkar
2013-02-27 4:59 ` Viresh Kumar
2013-02-27 4:59 ` Viresh Kumar
2013-02-27 5:04 ` Santosh Shilimkar
2013-02-27 5:04 ` Santosh Shilimkar
2013-02-27 5:04 ` Santosh Shilimkar
2013-02-27 6:00 ` [PATCH 0/4] time: " Santosh Shilimkar
2013-02-27 6:00 ` Santosh Shilimkar
2013-02-27 6:00 ` Santosh Shilimkar
2013-02-27 10:47 ` Russell King - ARM Linux
2013-02-27 10:47 ` Russell King - ARM Linux
2013-02-27 22:00 ` Thomas Gleixner
2013-02-27 22:00 ` Thomas Gleixner
2013-03-10 17:33 ` Santosh Shilimkar
2013-03-10 17:33 ` Santosh Shilimkar
2013-03-10 17:33 ` Santosh Shilimkar
2013-03-10 18:22 ` Daniel Lezcano
2013-03-10 18:22 ` Daniel Lezcano
2013-03-11 3:24 ` Santosh Shilimkar
2013-03-11 3:24 ` Santosh Shilimkar
2013-03-11 3:24 ` Santosh Shilimkar
2013-03-11 8:40 ` Daniel Lezcano
2013-03-11 8:40 ` Daniel Lezcano
2013-03-11 9:12 ` Santosh Shilimkar
2013-03-11 9:12 ` Santosh Shilimkar
2013-03-11 9:12 ` Santosh Shilimkar
2013-03-11 9:28 ` Rickard Andersson
2013-03-11 9:28 ` Rickard Andersson
2013-03-11 10:29 ` Santosh Shilimkar
2013-03-11 10:29 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130ACF2.6070005@stericsson.com \
--to=rickard.andersson@stericsson.com \
--cc=daniel.lezcano@linaro.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.