From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions
Date: Mon, 04 Mar 2013 07:55:02 +0100 [thread overview]
Message-ID: <51344546.7080306@redhat.com> (raw)
In-Reply-To: <11e3c93f4c64bda4ef46ec9de8dd8b4fa88b3ec5.1362290776.git.peter.crosthwaite@xilinx.com>
> +/**
> + * A descriptor for a Uint32 that is part of guest accessible device state
> + * @ro: whether or not the bit is read-only state comming out of reset
> + * @w1c: bits with the common write 1 to clear semantic.
> + * @nw0: bits that cant be written with a 0 by the guest (sticky 1)
> + * @nw1: bits that cant be written with a 1 by the guest (sticky 0)
Why these?
reset=0 + ro=1 equals nw1=1
reset=1 + ro=1 equals nw0=1
> + * @width: width of the uint32t. Only the @width least significant bits are
> + * valid. All others are silent Read-as-reset/WI.
That's kida redundant with "ro" too. I'd do it the other way around
btw: Specify the writable bits instead of the read-only ones. width=8
easily be written as wmask=0xff then.
cheers,
Gerd
next prev parent reply other threads:[~2013-03-04 6:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 6:13 [Qemu-devel] [RFC PATCH v1 0/4] Data Driven device registers & Zynq DEVCFG Peter Crosthwaite
2013-03-03 6:13 ` [Qemu-devel] [RFC PATCH v1 1/4] qemu-log: Allow checking of the current mask Peter Crosthwaite
2013-03-03 10:32 ` Peter Maydell
2013-03-03 6:13 ` [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions Peter Crosthwaite
2013-03-03 9:01 ` Blue Swirl
2013-03-04 1:37 ` Peter Crosthwaite
2013-03-04 7:28 ` Gerd Hoffmann
2013-03-04 20:44 ` Blue Swirl
2013-03-04 9:44 ` Michael S. Tsirkin
2013-03-04 20:52 ` Blue Swirl
2013-03-05 13:34 ` Michael S. Tsirkin
2013-03-05 14:17 ` Gerd Hoffmann
2013-03-05 14:32 ` Michael S. Tsirkin
2013-03-07 2:00 ` Peter Crosthwaite
2013-03-07 2:26 ` Peter Maydell
2013-03-09 9:41 ` Blue Swirl
2013-03-04 6:55 ` Gerd Hoffmann [this message]
2013-03-04 7:20 ` Peter Crosthwaite
2013-03-04 7:30 ` Gerd Hoffmann
2013-03-03 6:13 ` [Qemu-devel] [RFC PATCH v1 3/4] xilinx_zynq: devcfg device model Peter Crosthwaite
2013-03-03 6:13 ` [Qemu-devel] [RFC PATCH v1 4/4] zynq: added devcfg to machine model Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51344546.7080306@redhat.com \
--to=kraxel@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.