From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
peter.maydell@linaro.org, Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions
Date: Mon, 04 Mar 2013 08:28:00 +0100 [thread overview]
Message-ID: <51344D00.20707@redhat.com> (raw)
In-Reply-To: <CAEgOgz7ULoUd0=v+3tFvS28GNDjDFJnjYL=sTJ55VYoLd05C-g@mail.gmail.com>
Hi,
>> For maximum flexibility, a callback could be specified but then we
>> overlap memory API.
>
> I think this is a good idea, but continuing on the theme of what this
> API is trying to achieve I think there should be capability for
> per-bit function definitions. On the topic I think Gerd has played
> with the idea of per-register callbacks for some device models in the
> past.
hw/intel-hda.c is it.
Predates memory api though and thus doesn't integrated with it, although
it makes sense of course. Could be as simple as a generic MemoryRegionOps.
I'm not sure it is that useful to have per-bit callbacks. For "normal"
devices you rarely need that, and for gpio arrays probably want more
than just callbacks per bit (qemu_irqs for example).
cheers,
Gerd
next prev parent reply other threads:[~2013-03-04 7:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 6:13 [Qemu-devel] [RFC PATCH v1 0/4] Data Driven device registers & Zynq DEVCFG Peter Crosthwaite
2013-03-03 6:13 ` [Qemu-devel] [RFC PATCH v1 1/4] qemu-log: Allow checking of the current mask Peter Crosthwaite
2013-03-03 10:32 ` Peter Maydell
2013-03-03 6:13 ` [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions Peter Crosthwaite
2013-03-03 9:01 ` Blue Swirl
2013-03-04 1:37 ` Peter Crosthwaite
2013-03-04 7:28 ` Gerd Hoffmann [this message]
2013-03-04 20:44 ` Blue Swirl
2013-03-04 9:44 ` Michael S. Tsirkin
2013-03-04 20:52 ` Blue Swirl
2013-03-05 13:34 ` Michael S. Tsirkin
2013-03-05 14:17 ` Gerd Hoffmann
2013-03-05 14:32 ` Michael S. Tsirkin
2013-03-07 2:00 ` Peter Crosthwaite
2013-03-07 2:26 ` Peter Maydell
2013-03-09 9:41 ` Blue Swirl
2013-03-04 6:55 ` Gerd Hoffmann
2013-03-04 7:20 ` Peter Crosthwaite
2013-03-04 7:30 ` Gerd Hoffmann
2013-03-03 6:13 ` [Qemu-devel] [RFC PATCH v1 3/4] xilinx_zynq: devcfg device model Peter Crosthwaite
2013-03-03 6:13 ` [Qemu-devel] [RFC PATCH v1 4/4] zynq: added devcfg to machine model Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51344D00.20707@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.