Re: [Qemu-devel] [PATCH 1/3] cpu: make CPU_INTERRUPT_RESET available on all targets

["Andreas Färber" <afaerber@suse.de>]

Am 05.03.2013 16:38, schrieb Anthony Liguori:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
>> On the x86, some devices need access to the CPU reset pin (INIT#).
>> Provide a generic service to do this, using one of the internal
>> cpu_interrupt targets.  Generalize the PPC-specific code for
>> CPU_INTERRUPT_RESET to other targets, and provide a function that
>> will raise the interrupt on all CPUs.
>>
>> Since PPC does not support migration, I picked the value that is
>> used on x86, CPU_INTERRUPT_TGT_INT_1.  No other arch used to use
>> CPU_INTERRUPT_TGT_INT_1.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> This is a very nice approach.
> 
> It would still be nice to remove the explicit reset registrations for
> the various cpus and instead just call cpu_soft_reset().
> 
> I'm not sure "soft" is the best word.  This is just a normal CPU reset
> but I won't bikeshed over that.
> 
> Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

I would like to take this through qom-cpu please since I already changed
cpu_interrupt() to CPUState with my last patch series, for which the
prereqs got an Rb now.

cpu_soft_reset() still needs to live outside qom/cpu.c due to the CPU
iteration, so this would be purely mechanical.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg