All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Stuge <peter@stuge.se>
Cc: lersek@redhat.com, aliguori@us.ibm.com,
	Kevin O'Connor <kevin@koconnor.net>,
	David Woodhouse <dwmw2@infradead.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU
Date: Tue, 05 Mar 2013 18:42:56 +0100	[thread overview]
Message-ID: <51362EA0.5020400@redhat.com> (raw)
In-Reply-To: <20130305172636.14123.qmail@stuge.se>

Il 05/03/2013 18:26, Peter Stuge ha scritto:
>>> > > That is: perhaps it's a *SeaBIOS* bug that suspend/resume doesn't
>>> > > work if the PAM configuration is reset?
>> > 
>> > Yeah, it sounded a bit weird when I wrote that commit message. 
>> > This could be the case.  How does it work on Coreboot?
> Yes all hardware except RAM in self-refresh and registers explicitly
> hooked to battery sleep power rail has reset state on resume from S3.
> Those registers seem to grow over time, the i440 probably doesn't
> have very many. The memory controller configuration would be stored
> there.

Ok, so it's not correct either with this patch or without. :)

But without this patch it is more correct; things such as USB queue
heads must be reset, or you'll corrupt random memory when the VM is
restarted.

Paolo

  reply	other threads:[~2013-03-05 17:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 15:04 [Qemu-devel] [PATCH 0/3] Implement x86 soft reset Paolo Bonzini
2013-03-05 15:04 ` [Qemu-devel] [PATCH 1/3] cpu: make CPU_INTERRUPT_RESET available on all targets Paolo Bonzini
2013-03-05 15:38   ` Anthony Liguori
2013-03-05 16:10     ` Andreas Färber
2013-03-05 16:17       ` Paolo Bonzini
2013-03-05 18:00   ` Laszlo Ersek
2013-03-05 15:04 ` [Qemu-devel] [PATCH 2/3] pc: port 92 reset requires a low->high transition Paolo Bonzini
2013-03-05 17:20   ` Anthony Liguori
2013-03-05 18:05   ` Laszlo Ersek
2013-03-05 15:04 ` [Qemu-devel] [PATCH 3/3] hw: correctly implement soft reset Paolo Bonzini
2013-03-05 17:18   ` Anthony Liguori
2013-03-05 17:22   ` David Woodhouse
2013-03-05 17:43     ` Paolo Bonzini
2013-03-05 18:32   ` Laszlo Ersek
2013-03-05 15:51 ` [Qemu-devel] [PATCH 0/3] Implement x86 " David Woodhouse
2013-03-05 16:00   ` Paolo Bonzini
2013-03-05 16:13     ` Andreas Färber
2013-03-05 16:03 ` [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU Paolo Bonzini
2013-03-05 16:59   ` David Woodhouse
2013-03-05 17:10     ` Paolo Bonzini
2013-03-05 17:26       ` Peter Stuge
2013-03-05 17:42         ` Paolo Bonzini [this message]
2013-03-05 19:12     ` Laszlo Ersek
2013-03-05 19:25       ` Paolo Bonzini
2013-03-05 19:51         ` Laszlo Ersek
2013-03-06  1:45     ` Kevin O'Connor
2013-03-06  8:32       ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51362EA0.5020400@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=dwmw2@infradead.org \
    --cc=kevin@koconnor.net \
    --cc=lersek@redhat.com \
    --cc=peter@stuge.se \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.