All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
Date: Tue, 05 Mar 2013 19:34:06 +0100	[thread overview]
Message-ID: <51363A9E.6090507@gmail.com> (raw)
In-Reply-To: <1362476098.16460.65.camel@x61.thuisdomein>

On 03/05/2013 10:34 AM, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. Since the Marvell Dove code includes
> <linux/clk-provider.h>  we can assume that this entry needs to select
> COMMON_CLK instead.
>
> Signed-off-by: Paul Bolle<pebolle@tiscali.nl>
> ---
> Untested.
>
>   arch/arm/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5b71469..31acce7 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -556,7 +556,7 @@ config ARCH_IXP4XX
>   config ARCH_DOVE
>   	bool "Marvell Dove"
>   	select ARCH_REQUIRE_GPIOLIB
> -	select COMMON_CLK_DOVE
> +	select COMMON_CLK
>   	select CPU_V7
>   	select GENERIC_CLOCKEVENTS
>   	select MIGHT_HAVE_PCI

Paul,

thanks for the patch but I guess COMMON_CLK_DOVE is a left-over
from early DT experiments with Dove. It should just be removed
from arm/Kconfig.

Thanks for pointing it out, and it would be great to update
your patch accordingly.

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Russell King <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
Date: Tue, 05 Mar 2013 19:34:06 +0100	[thread overview]
Message-ID: <51363A9E.6090507@gmail.com> (raw)
In-Reply-To: <1362476098.16460.65.camel@x61.thuisdomein>

On 03/05/2013 10:34 AM, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. Since the Marvell Dove code includes
> <linux/clk-provider.h>  we can assume that this entry needs to select
> COMMON_CLK instead.
>
> Signed-off-by: Paul Bolle<pebolle@tiscali.nl>
> ---
> Untested.
>
>   arch/arm/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5b71469..31acce7 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -556,7 +556,7 @@ config ARCH_IXP4XX
>   config ARCH_DOVE
>   	bool "Marvell Dove"
>   	select ARCH_REQUIRE_GPIOLIB
> -	select COMMON_CLK_DOVE
> +	select COMMON_CLK
>   	select CPU_V7
>   	select GENERIC_CLOCKEVENTS
>   	select MIGHT_HAVE_PCI

Paul,

thanks for the patch but I guess COMMON_CLK_DOVE is a left-over
from early DT experiments with Dove. It should just be removed
from arm/Kconfig.

Thanks for pointing it out, and it would be great to update
your patch accordingly.

Sebastian

  parent reply	other threads:[~2013-03-05 18:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05  9:34 [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE" Paul Bolle
2013-03-05  9:34 ` Paul Bolle
2013-03-05 14:00 ` Jason Cooper
2013-03-05 14:00   ` Jason Cooper
2013-03-05 18:02   ` Jean-Francois Moine
2013-03-05 18:02     ` Jean-Francois Moine
2013-03-05 18:23     ` Paul Bolle
2013-03-05 18:23       ` Paul Bolle
2013-03-05 18:34 ` Sebastian Hesselbarth [this message]
2013-03-05 18:34   ` Sebastian Hesselbarth
2013-03-05 20:17   ` [PATCH v2] ARM: dove: drop "select COMMON_CLK_DOVE" Paul Bolle
2013-03-05 20:17     ` Paul Bolle
2013-03-08 21:26     ` Jason Cooper
2013-03-08 21:26       ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51363A9E.6090507@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.