* [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
@ 2013-03-05 9:34 ` Paul Bolle
0 siblings, 0 replies; 14+ messages in thread
From: Paul Bolle @ 2013-03-05 9:34 UTC (permalink / raw)
To: linux-arm-kernel
Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
makes this select statement a nop. Since the Marvell Dove code includes
<linux/clk-provider.h> we can assume that this entry needs to select
COMMON_CLK instead.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.
arch/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5b71469..31acce7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -556,7 +556,7 @@ config ARCH_IXP4XX
config ARCH_DOVE
bool "Marvell Dove"
select ARCH_REQUIRE_GPIOLIB
- select COMMON_CLK_DOVE
+ select COMMON_CLK
select CPU_V7
select GENERIC_CLOCKEVENTS
select MIGHT_HAVE_PCI
--
1.7.11.7
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
@ 2013-03-05 9:34 ` Paul Bolle
0 siblings, 0 replies; 14+ messages in thread
From: Paul Bolle @ 2013-03-05 9:34 UTC (permalink / raw)
To: Russell King; +Cc: Sebastian Hesselbarth, linux-arm-kernel, linux-kernel
Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
makes this select statement a nop. Since the Marvell Dove code includes
<linux/clk-provider.h> we can assume that this entry needs to select
COMMON_CLK instead.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.
arch/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5b71469..31acce7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -556,7 +556,7 @@ config ARCH_IXP4XX
config ARCH_DOVE
bool "Marvell Dove"
select ARCH_REQUIRE_GPIOLIB
- select COMMON_CLK_DOVE
+ select COMMON_CLK
select CPU_V7
select GENERIC_CLOCKEVENTS
select MIGHT_HAVE_PCI
--
1.7.11.7
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
2013-03-05 9:34 ` Paul Bolle
@ 2013-03-05 14:00 ` Jason Cooper
-1 siblings, 0 replies; 14+ messages in thread
From: Jason Cooper @ 2013-03-05 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Paul,
On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. Since the Marvell Dove code includes
> <linux/clk-provider.h> we can assume that this entry needs to select
> COMMON_CLK instead.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> arch/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch, thanks for the patch. Sebastian, could you test this and
report back?
thx,
Jason.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
@ 2013-03-05 14:00 ` Jason Cooper
0 siblings, 0 replies; 14+ messages in thread
From: Jason Cooper @ 2013-03-05 14:00 UTC (permalink / raw)
To: Paul Bolle
Cc: Russell King, linux-kernel, linux-arm-kernel,
Sebastian Hesselbarth
Paul,
On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. Since the Marvell Dove code includes
> <linux/clk-provider.h> we can assume that this entry needs to select
> COMMON_CLK instead.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> arch/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch, thanks for the patch. Sebastian, could you test this and
report back?
thx,
Jason.
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
2013-03-05 14:00 ` Jason Cooper
@ 2013-03-05 18:02 ` Jean-Francois Moine
-1 siblings, 0 replies; 14+ messages in thread
From: Jean-Francois Moine @ 2013-03-05 18:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 5 Mar 2013 09:00:25 -0500
Jason Cooper <jason@lakedaemon.net> wrote:
> On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote:
> > Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> > DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> > Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> > makes this select statement a nop. Since the Marvell Dove code includes
> > <linux/clk-provider.h> we can assume that this entry needs to select
> > COMMON_CLK instead.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Untested.
> >
> > arch/arm/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Nice catch, thanks for the patch. Sebastian, could you test this and
> report back?
I also have a Cubox and I generated a kernel 3.9-rc1 for it (not tested
yet).
The .config contains CONFIG_COMMON_CLK=y naturally because MACH_DOVE
selects PLAT_ORION_LEGACY which selects PLAT_ORION which selects
COMMON_CLK.
So, "select COMMON_CLK" is not needed in ARCH_DOVE.
BTW, why is there a PLAT_ORION_LEGACY?
--
Ken ar c'henta? | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
@ 2013-03-05 18:02 ` Jean-Francois Moine
0 siblings, 0 replies; 14+ messages in thread
From: Jean-Francois Moine @ 2013-03-05 18:02 UTC (permalink / raw)
To: Jason Cooper
Cc: Paul Bolle, Russell King, linux-kernel, linux-arm-kernel,
Sebastian Hesselbarth
On Tue, 5 Mar 2013 09:00:25 -0500
Jason Cooper <jason@lakedaemon.net> wrote:
> On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote:
> > Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> > DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> > Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> > makes this select statement a nop. Since the Marvell Dove code includes
> > <linux/clk-provider.h> we can assume that this entry needs to select
> > COMMON_CLK instead.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Untested.
> >
> > arch/arm/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Nice catch, thanks for the patch. Sebastian, could you test this and
> report back?
I also have a Cubox and I generated a kernel 3.9-rc1 for it (not tested
yet).
The .config contains CONFIG_COMMON_CLK=y naturally because MACH_DOVE
selects PLAT_ORION_LEGACY which selects PLAT_ORION which selects
COMMON_CLK.
So, "select COMMON_CLK" is not needed in ARCH_DOVE.
BTW, why is there a PLAT_ORION_LEGACY?
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
2013-03-05 18:02 ` Jean-Francois Moine
@ 2013-03-05 18:23 ` Paul Bolle
-1 siblings, 0 replies; 14+ messages in thread
From: Paul Bolle @ 2013-03-05 18:23 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2013-03-05 at 19:02 +0100, Jean-Francois Moine wrote:
> The .config contains CONFIG_COMMON_CLK=y naturally because MACH_DOVE
> selects PLAT_ORION_LEGACY which selects PLAT_ORION which selects
> COMMON_CLK.
>
> So, "select COMMON_CLK" is not needed in ARCH_DOVE.
Thanks. Unless people object (because they prefer an explicit, though
superfluous, select of COMMON_CLK) I'll redo my patch.
Paul Bolle
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
@ 2013-03-05 18:23 ` Paul Bolle
0 siblings, 0 replies; 14+ messages in thread
From: Paul Bolle @ 2013-03-05 18:23 UTC (permalink / raw)
To: Jean-Francois Moine
Cc: Jason Cooper, Russell King, linux-kernel, linux-arm-kernel,
Sebastian Hesselbarth
On Tue, 2013-03-05 at 19:02 +0100, Jean-Francois Moine wrote:
> The .config contains CONFIG_COMMON_CLK=y naturally because MACH_DOVE
> selects PLAT_ORION_LEGACY which selects PLAT_ORION which selects
> COMMON_CLK.
>
> So, "select COMMON_CLK" is not needed in ARCH_DOVE.
Thanks. Unless people object (because they prefer an explicit, though
superfluous, select of COMMON_CLK) I'll redo my patch.
Paul Bolle
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
2013-03-05 9:34 ` Paul Bolle
@ 2013-03-05 18:34 ` Sebastian Hesselbarth
-1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Hesselbarth @ 2013-03-05 18:34 UTC (permalink / raw)
To: linux-arm-kernel
On 03/05/2013 10:34 AM, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. Since the Marvell Dove code includes
> <linux/clk-provider.h> we can assume that this entry needs to select
> COMMON_CLK instead.
>
> Signed-off-by: Paul Bolle<pebolle@tiscali.nl>
> ---
> Untested.
>
> arch/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5b71469..31acce7 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -556,7 +556,7 @@ config ARCH_IXP4XX
> config ARCH_DOVE
> bool "Marvell Dove"
> select ARCH_REQUIRE_GPIOLIB
> - select COMMON_CLK_DOVE
> + select COMMON_CLK
> select CPU_V7
> select GENERIC_CLOCKEVENTS
> select MIGHT_HAVE_PCI
Paul,
thanks for the patch but I guess COMMON_CLK_DOVE is a left-over
from early DT experiments with Dove. It should just be removed
from arm/Kconfig.
Thanks for pointing it out, and it would be great to update
your patch accordingly.
Sebastian
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
@ 2013-03-05 18:34 ` Sebastian Hesselbarth
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Hesselbarth @ 2013-03-05 18:34 UTC (permalink / raw)
To: Paul Bolle; +Cc: Russell King, linux-arm-kernel, linux-kernel
On 03/05/2013 10:34 AM, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. Since the Marvell Dove code includes
> <linux/clk-provider.h> we can assume that this entry needs to select
> COMMON_CLK instead.
>
> Signed-off-by: Paul Bolle<pebolle@tiscali.nl>
> ---
> Untested.
>
> arch/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5b71469..31acce7 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -556,7 +556,7 @@ config ARCH_IXP4XX
> config ARCH_DOVE
> bool "Marvell Dove"
> select ARCH_REQUIRE_GPIOLIB
> - select COMMON_CLK_DOVE
> + select COMMON_CLK
> select CPU_V7
> select GENERIC_CLOCKEVENTS
> select MIGHT_HAVE_PCI
Paul,
thanks for the patch but I guess COMMON_CLK_DOVE is a left-over
from early DT experiments with Dove. It should just be removed
from arm/Kconfig.
Thanks for pointing it out, and it would be great to update
your patch accordingly.
Sebastian
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH v2] ARM: dove: drop "select COMMON_CLK_DOVE"
2013-03-05 18:34 ` Sebastian Hesselbarth
@ 2013-03-05 20:17 ` Paul Bolle
-1 siblings, 0 replies; 14+ messages in thread
From: Paul Bolle @ 2013-03-05 20:17 UTC (permalink / raw)
To: linux-arm-kernel
Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
makes this select statement a nop. It's probably a leftover of some
experimental code that never hit mainline. Drop it.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v2: Sebastian suggested to drop this select entirely.
1) Still untested.
arch/arm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5b71469..0c990b7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -556,7 +556,6 @@ config ARCH_IXP4XX
config ARCH_DOVE
bool "Marvell Dove"
select ARCH_REQUIRE_GPIOLIB
- select COMMON_CLK_DOVE
select CPU_V7
select GENERIC_CLOCKEVENTS
select MIGHT_HAVE_PCI
--
1.7.11.7
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2] ARM: dove: drop "select COMMON_CLK_DOVE"
@ 2013-03-05 20:17 ` Paul Bolle
0 siblings, 0 replies; 14+ messages in thread
From: Paul Bolle @ 2013-03-05 20:17 UTC (permalink / raw)
To: Russell King
Cc: Sebastian Hesselbarth, Jason Cooper, Jean-Francois Moine,
linux-arm-kernel, linux-kernel
Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
makes this select statement a nop. It's probably a leftover of some
experimental code that never hit mainline. Drop it.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v2: Sebastian suggested to drop this select entirely.
1) Still untested.
arch/arm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5b71469..0c990b7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -556,7 +556,6 @@ config ARCH_IXP4XX
config ARCH_DOVE
bool "Marvell Dove"
select ARCH_REQUIRE_GPIOLIB
- select COMMON_CLK_DOVE
select CPU_V7
select GENERIC_CLOCKEVENTS
select MIGHT_HAVE_PCI
--
1.7.11.7
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2] ARM: dove: drop "select COMMON_CLK_DOVE"
2013-03-05 20:17 ` Paul Bolle
@ 2013-03-08 21:26 ` Jason Cooper
-1 siblings, 0 replies; 14+ messages in thread
From: Jason Cooper @ 2013-03-08 21:26 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 05, 2013 at 09:17:17PM +0100, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. It's probably a leftover of some
> experimental code that never hit mainline. Drop it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) v2: Sebastian suggested to drop this select entirely.
>
> 1) Still untested.
>
> arch/arm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Applied to mvebu/fixes
thx,
Jason.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] ARM: dove: drop "select COMMON_CLK_DOVE"
@ 2013-03-08 21:26 ` Jason Cooper
0 siblings, 0 replies; 14+ messages in thread
From: Jason Cooper @ 2013-03-08 21:26 UTC (permalink / raw)
To: Paul Bolle
Cc: Russell King, Jean-Francois Moine, linux-kernel, linux-arm-kernel,
Sebastian Hesselbarth
On Tue, Mar 05, 2013 at 09:17:17PM +0100, Paul Bolle wrote:
> Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> makes this select statement a nop. It's probably a leftover of some
> experimental code that never hit mainline. Drop it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) v2: Sebastian suggested to drop this select entirely.
>
> 1) Still untested.
>
> arch/arm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Applied to mvebu/fixes
thx,
Jason.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-03-08 21:27 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 9:34 [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE" Paul Bolle
2013-03-05 9:34 ` Paul Bolle
2013-03-05 14:00 ` Jason Cooper
2013-03-05 14:00 ` Jason Cooper
2013-03-05 18:02 ` Jean-Francois Moine
2013-03-05 18:02 ` Jean-Francois Moine
2013-03-05 18:23 ` Paul Bolle
2013-03-05 18:23 ` Paul Bolle
2013-03-05 18:34 ` Sebastian Hesselbarth
2013-03-05 18:34 ` Sebastian Hesselbarth
2013-03-05 20:17 ` [PATCH v2] ARM: dove: drop "select COMMON_CLK_DOVE" Paul Bolle
2013-03-05 20:17 ` Paul Bolle
2013-03-08 21:26 ` Jason Cooper
2013-03-08 21:26 ` Jason Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.