[PATCH] Add vendor quirk for SIMCOM

[PATCH] Add vendor quirk for SIMCOM

[r.r.zaripov]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

From: Renat Zaripov <r.r.zaripov@gmail.com>

---
 drivers/atmodem/gprs-context.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
index 3694c27..c5a0ae7 100644
--- a/drivers/atmodem/gprs-context.c
+++ b/drivers/atmodem/gprs-context.c
@@ -208,7 +208,11 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, gpointer user_data)
 		return;
 	}
 
-	sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
+	if (gcd->vendor == OFONO_VENDOR_SIMCOM) 
+		memcpy(buf, "ATD*99#", 7);
+	else
+		sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
+
 	if (g_at_chat_send(gcd->chat, buf, none_prefix,
 				at_cgdata_cb, gc, NULL) > 0)
 		return;
-- 
1.7.10.4

Re: [PATCH] Add vendor quirk for SIMCOM

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

Hi Renat,

On 02/28/2013 09:43 AM, r.r.zaripov(a)gmail.com wrote:
> From: Renat Zaripov<r.r.zaripov@gmail.com>
>
> ---
>   drivers/atmodem/gprs-context.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
> index 3694c27..c5a0ae7 100644
> --- a/drivers/atmodem/gprs-context.c
> +++ b/drivers/atmodem/gprs-context.c
> @@ -208,7 +208,11 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, gpointer user_data)
>   		return;
>   	}
>
> -	sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +	if (gcd->vendor == OFONO_VENDOR_SIMCOM)
> +		memcpy(buf, "ATD*99#", 7);

At lease use strcpy, since you're not copying the '\0' here actually.

> +	else
> +		sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +
>   	if (g_at_chat_send(gcd->chat, buf, none_prefix,
>   				at_cgdata_cb, gc, NULL)>  0)
>   		return;

Regards,
-Denis

[PATCH] Add vendor quirk for SIMCOM

[r.r.zaripov]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

From: Renat Zaripov <r.r.zaripov@gmail.com>

---
 drivers/atmodem/gprs-context.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
index 3694c27..0fb63c4 100644
--- a/drivers/atmodem/gprs-context.c
+++ b/drivers/atmodem/gprs-context.c
@@ -208,7 +208,11 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, gpointer user_data)
 		return;
 	}
 
-	sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
+	if (gcd->vendor == OFONO_VENDOR_SIMCOM)
+		strcpy(buf, "ATD*99#\0");
+	else
+		sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
+
 	if (g_at_chat_send(gcd->chat, buf, none_prefix,
 				at_cgdata_cb, gc, NULL) > 0)
 		return;
-- 
1.7.10.4

Re: [PATCH] Add vendor quirk for SIMCOM

[Viallard Anthony]

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

On 12. 03. 13 15:40, r.r.zaripov(a)gmail.com wrote:
> From: Renat Zaripov<r.r.zaripov@gmail.com>
>
> ---
>   drivers/atmodem/gprs-context.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
> index 3694c27..0fb63c4 100644
> --- a/drivers/atmodem/gprs-context.c
> +++ b/drivers/atmodem/gprs-context.c
> @@ -208,7 +208,11 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, gpointer user_data)
>   		return;
>   	}
>
> -	sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +	if (gcd->vendor == OFONO_VENDOR_SIMCOM)
> +		strcpy(buf, "ATD*99#\0");
> +	else
> +		sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +
>   	if (g_at_chat_send(gcd->chat, buf, none_prefix,
>   				at_cgdata_cb, gc, NULL)>  0)
>   		return;

Hello Renat,

I watched the AT commands set for my SIM5216 and I found AT+CGDATA. 
There isn't this command for sim900 ?

And, I saw "ATD*99#" cryptic command was already used in 
gatchat/gsmdial.c if bluetooth is enabled.

Maybe, it's a specific command for your purpose ? I mean, do you need 
this command to "establish communication between the TE and the network 
using one or more Packet Domain PDP types." ? If it's the case, the 
quirk is only for your device and so, it's not a vendor quirk.
	
Otherwise, why this \0 after ATD*99# ? :)

Regards,
Anthony.

Re: [PATCH] Add vendor quirk for SIMCOM

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

Hi Renat,

On 03/12/2013 09:40 AM, r.r.zaripov(a)gmail.com wrote:
> From: Renat Zaripov<r.r.zaripov@gmail.com>
>
> ---
>   drivers/atmodem/gprs-context.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
> index 3694c27..0fb63c4 100644
> --- a/drivers/atmodem/gprs-context.c
> +++ b/drivers/atmodem/gprs-context.c
> @@ -208,7 +208,11 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, gpointer user_data)
>   		return;
>   	}
>
> -	sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +	if (gcd->vendor == OFONO_VENDOR_SIMCOM)
> +		strcpy(buf, "ATD*99#\0");

The embedded null character is not necessary, strcpy will take care of 
that for you.

> +	else
> +		sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +
>   	if (g_at_chat_send(gcd->chat, buf, none_prefix,
>   				at_cgdata_cb, gc, NULL)>  0)
>   		return;

Regards,
-Denis

Re: [PATCH] Add vendor quirk for SIMCOM

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi Anthony,

> And, I saw "ATD*99#" cryptic command was already used in
> gatchat/gsmdial.c if bluetooth is enabled.
>

This is a legacy operation for entering into data mode.  Refer to 27.007 
Section 10.2.1.1.  It can be used as a shortcut for CGDCONT/CGDATA, and 
it seems that some modems do not implement CGDATA at all.

> Otherwise, why this \0 after ATD*99# ? :)
>

Good spot ;)

Regards,
-Denis

Re: [PATCH] Add vendor quirk for SIMCOM

[Renat Zaripov]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

Hello Anthony, Denis,

2013/3/12 Denis Kenzior <denkenz@gmail.com>

> Hi Anthony,
>
>  And, I saw "ATD*99#" cryptic command was already used in
>> gatchat/gsmdial.c if bluetooth is enabled.
>>
>>
> This is a legacy operation for entering into data mode.  Refer to 27.007
> Section 10.2.1.1.  It can be used as a shortcut for CGDCONT/CGDATA, and it
> seems that some modems do not implement CGDATA at all.
>
>
Yes, sim900 supports AT+CGDATA command, but unfortunately I can't make it
work. I get no error messages, but the connection is not being established.
I wrote about this issue to SIMCOM, but with my local distributor this is
long story.


>  Otherwise, why this \0 after ATD*99# ? :)
>>
>>
> Good spot ;)
>
>
If I get answer from SIMCOM about AT+CGDATA and make it work properly, I
promise that never send again patch with this funny mistake;)

Anyway, Denis wrote some time ago, we can implement quirks for separating
various models of modem modules of one manufacturer. Like this:

OFONO_VENDOR_SIMCOM_SIM900
OFONO_VENDOR_SIMCOM_SIM5216E


> Regards,
> -Denis
>
> ______________________________**_________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/**listinfo/ofono<http://lists.ofono.org/listinfo/ofono>
>

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 2349 bytes --]