* [PATCH 2/5] pinctrl: ab8500: Staticize some symbols
2013-03-19 6:31 [PATCH 1/5] pinctrl: abx500: Staticize some symbols Sachin Kamat
@ 2013-03-19 6:31 ` Sachin Kamat
2013-03-19 8:41 ` Patrice CHOTARD
2013-04-09 7:55 ` Linus Walleij
2013-03-19 6:31 ` [PATCH 3/5] pinctrl: ab9540: " Sachin Kamat
` (4 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Sachin Kamat @ 2013-03-19 6:31 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat, patches, Patrice Chotard
These symbols are used only in this file. Silences the following
warnings:
drivers/pinctrl/pinctrl-ab8500.c:392:28: warning:
symbol 'ab8500_alternate_functions' was not declared. Should it be static?
drivers/pinctrl/pinctrl-ab8500.c:458:32: warning:
symbol 'ab8500_gpio_irq_cluster' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Patrice Chotard <patrice.chotard@stericsson.com>
---
drivers/pinctrl/pinctrl-ab8500.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ab8500.c b/drivers/pinctrl/pinctrl-ab8500.c
index 3b471d8..2ac2d0a 100644
--- a/drivers/pinctrl/pinctrl-ab8500.c
+++ b/drivers/pinctrl/pinctrl-ab8500.c
@@ -389,7 +389,8 @@ static const struct abx500_function ab8500_functions[] = {
* alt_A | 1 | 0 | 0
*/
-struct alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1] = {
+static struct
+alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1] = {
ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
ALTERNATE_FUNCTIONS(2, 1, UNUSED, UNUSED, 0, 0, 0), /* GPIO2, altA controlled by bit 1 */
@@ -455,7 +456,7 @@ struct alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1
* GPIO24 and GPIO25
* GPIO36 to GPIO41
*/
-struct abx500_gpio_irq_cluster ab8500_gpio_irq_cluster[] = {
+static struct abx500_gpio_irq_cluster ab8500_gpio_irq_cluster[] = {
GPIO_IRQ_CLUSTER(6, 13, AB8500_INT_GPIO6R),
GPIO_IRQ_CLUSTER(24, 25, AB8500_INT_GPIO24R),
GPIO_IRQ_CLUSTER(36, 41, AB8500_INT_GPIO36R),
--
1.7.4.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 2/5] pinctrl: ab8500: Staticize some symbols
2013-03-19 6:31 ` [PATCH 2/5] pinctrl: ab8500: " Sachin Kamat
@ 2013-03-19 8:41 ` Patrice CHOTARD
2013-04-09 7:55 ` Linus Walleij
1 sibling, 0 replies; 16+ messages in thread
From: Patrice CHOTARD @ 2013-03-19 8:41 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
patches@linaro.org
On 03/19/2013 07:31 AM, Sachin Kamat wrote:
> These symbols are used only in this file. Silences the following
> warnings:
> drivers/pinctrl/pinctrl-ab8500.c:392:28: warning:
> symbol 'ab8500_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8500.c:458:32: warning:
> symbol 'ab8500_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
> ---
> drivers/pinctrl/pinctrl-ab8500.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ab8500.c b/drivers/pinctrl/pinctrl-ab8500.c
> index 3b471d8..2ac2d0a 100644
> --- a/drivers/pinctrl/pinctrl-ab8500.c
> +++ b/drivers/pinctrl/pinctrl-ab8500.c
> @@ -389,7 +389,8 @@ static const struct abx500_function ab8500_functions[] = {
> * alt_A | 1 | 0 | 0
> */
>
> -struct alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1] = {
> +static struct
> +alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1] = {
> ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
> ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
> ALTERNATE_FUNCTIONS(2, 1, UNUSED, UNUSED, 0, 0, 0), /* GPIO2, altA controlled by bit 1 */
> @@ -455,7 +456,7 @@ struct alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1
> * GPIO24 and GPIO25
> * GPIO36 to GPIO41
> */
> -struct abx500_gpio_irq_cluster ab8500_gpio_irq_cluster[] = {
> +static struct abx500_gpio_irq_cluster ab8500_gpio_irq_cluster[] = {
> GPIO_IRQ_CLUSTER(6, 13, AB8500_INT_GPIO6R),
> GPIO_IRQ_CLUSTER(24, 25, AB8500_INT_GPIO24R),
> GPIO_IRQ_CLUSTER(36, 41, AB8500_INT_GPIO36R),
Acked-by: Patrice Chotard <patrice.chotard@st.com>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 2/5] pinctrl: ab8500: Staticize some symbols
2013-03-19 6:31 ` [PATCH 2/5] pinctrl: ab8500: " Sachin Kamat
2013-03-19 8:41 ` Patrice CHOTARD
@ 2013-04-09 7:55 ` Linus Walleij
1 sibling, 0 replies; 16+ messages in thread
From: Linus Walleij @ 2013-04-09 7:55 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, Patch Tracking, Patrice Chotard
On Tue, Mar 19, 2013 at 7:31 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> These symbols are used only in this file. Silences the following
> warnings:
> drivers/pinctrl/pinctrl-ab8500.c:392:28: warning:
> symbol 'ab8500_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8500.c:458:32: warning:
> symbol 'ab8500_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
Patch applied with Patrice's ACK, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 3/5] pinctrl: ab9540: Staticize some symbols
2013-03-19 6:31 [PATCH 1/5] pinctrl: abx500: Staticize some symbols Sachin Kamat
2013-03-19 6:31 ` [PATCH 2/5] pinctrl: ab8500: " Sachin Kamat
@ 2013-03-19 6:31 ` Sachin Kamat
2013-03-19 8:42 ` Patrice CHOTARD
2013-04-09 7:57 ` Linus Walleij
2013-03-19 6:31 ` [PATCH 4/5] pinctrl: ab8540: " Sachin Kamat
` (3 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Sachin Kamat @ 2013-03-19 6:31 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat, patches, Patrice Chotard
Fixes the following warnings:
drivers/pinctrl/pinctrl-ab9540.c:382:28: warning:
symbol 'ab9540alternate_functions' was not declared. Should it be static?
drivers/pinctrl/pinctrl-ab9540.c:457:32: warning:
symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Patrice Chotard <patrice.chotard@stericsson.com>
---
drivers/pinctrl/pinctrl-ab9540.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ab9540.c b/drivers/pinctrl/pinctrl-ab9540.c
index 7610bd0..27835ce 100644
--- a/drivers/pinctrl/pinctrl-ab9540.c
+++ b/drivers/pinctrl/pinctrl-ab9540.c
@@ -379,7 +379,8 @@ static const struct abx500_function ab9540_functions[] = {
* alt_A | 1 | 0 | 0
*/
-struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = {
+static struct
+alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = {
/* GPIOSEL1 - bits 4-7 are reserved */
ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
@@ -454,7 +455,7 @@ struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1]
ALTERNATE_FUNCTIONS(54, 5, UNUSED, UNUSED, 0, 0, 0), /* GPIO54 = GPIO60, altA controlled by bit 5 */
};
-struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = {
+static struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = {
GPIO_IRQ_CLUSTER(10, 13, AB8500_INT_GPIO10R),
GPIO_IRQ_CLUSTER(24, 25, AB8500_INT_GPIO24R),
GPIO_IRQ_CLUSTER(40, 41, AB8500_INT_GPIO40R),
--
1.7.4.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 3/5] pinctrl: ab9540: Staticize some symbols
2013-03-19 6:31 ` [PATCH 3/5] pinctrl: ab9540: " Sachin Kamat
@ 2013-03-19 8:42 ` Patrice CHOTARD
2013-04-09 7:57 ` Linus Walleij
1 sibling, 0 replies; 16+ messages in thread
From: Patrice CHOTARD @ 2013-03-19 8:42 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
patches@linaro.org
On 03/19/2013 07:31 AM, Sachin Kamat wrote:
> Fixes the following warnings:
> drivers/pinctrl/pinctrl-ab9540.c:382:28: warning:
> symbol 'ab9540alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab9540.c:457:32: warning:
> symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
> ---
> drivers/pinctrl/pinctrl-ab9540.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ab9540.c b/drivers/pinctrl/pinctrl-ab9540.c
> index 7610bd0..27835ce 100644
> --- a/drivers/pinctrl/pinctrl-ab9540.c
> +++ b/drivers/pinctrl/pinctrl-ab9540.c
> @@ -379,7 +379,8 @@ static const struct abx500_function ab9540_functions[] = {
> * alt_A | 1 | 0 | 0
> */
>
> -struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = {
> +static struct
> +alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = {
> /* GPIOSEL1 - bits 4-7 are reserved */
> ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
> ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
> @@ -454,7 +455,7 @@ struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1]
> ALTERNATE_FUNCTIONS(54, 5, UNUSED, UNUSED, 0, 0, 0), /* GPIO54 = GPIO60, altA controlled by bit 5 */
> };
>
> -struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = {
> +static struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = {
> GPIO_IRQ_CLUSTER(10, 13, AB8500_INT_GPIO10R),
> GPIO_IRQ_CLUSTER(24, 25, AB8500_INT_GPIO24R),
> GPIO_IRQ_CLUSTER(40, 41, AB8500_INT_GPIO40R),
Fyi, don't use my stericsson email address as it has been disabled.
Acked-by: Patrice Chotard <patrice.chotard@st.com>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 3/5] pinctrl: ab9540: Staticize some symbols
2013-03-19 6:31 ` [PATCH 3/5] pinctrl: ab9540: " Sachin Kamat
2013-03-19 8:42 ` Patrice CHOTARD
@ 2013-04-09 7:57 ` Linus Walleij
1 sibling, 0 replies; 16+ messages in thread
From: Linus Walleij @ 2013-04-09 7:57 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, Patch Tracking, Patrice Chotard
On Tue, Mar 19, 2013 at 7:31 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes the following warnings:
> drivers/pinctrl/pinctrl-ab9540.c:382:28: warning:
> symbol 'ab9540alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab9540.c:457:32: warning:
> symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
Patch applied with Patrice's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 4/5] pinctrl: ab8540: Staticize some symbols
2013-03-19 6:31 [PATCH 1/5] pinctrl: abx500: Staticize some symbols Sachin Kamat
2013-03-19 6:31 ` [PATCH 2/5] pinctrl: ab8500: " Sachin Kamat
2013-03-19 6:31 ` [PATCH 3/5] pinctrl: ab9540: " Sachin Kamat
@ 2013-03-19 6:31 ` Sachin Kamat
2013-03-19 8:43 ` Patrice CHOTARD
2013-04-09 7:59 ` Linus Walleij
2013-03-19 6:31 ` [PATCH 5/5] pinctrl: ab8505: " Sachin Kamat
` (2 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Sachin Kamat @ 2013-03-19 6:31 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat, patches, Patrice Chotard
Silences the following warnings:
drivers/pinctrl/pinctrl-ab8540.c:302:28: warning:
symbol 'ab8540_alternate_functions' was not declared. Should it be static?
drivers/pinctrl/pinctrl-ab8540.c:379:32: warning:
symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Patrice Chotard <patrice.chotard@stericsson.com>
---
drivers/pinctrl/pinctrl-ab8540.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c
index 8ee1e8d..9867535 100644
--- a/drivers/pinctrl/pinctrl-ab8540.c
+++ b/drivers/pinctrl/pinctrl-ab8540.c
@@ -299,7 +299,8 @@ static const struct abx500_function ab8540_functions[] = {
*
*/
-struct alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = {
+static struct
+alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = {
/* GPIOSEL1 - bit 4-7 reserved */
ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
@@ -376,7 +377,7 @@ static struct pullud ab8540_pullud = {
* GPIO43 to GPIO44
* GPIO51 to GPIO54
*/
-struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
+static struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
GPIO_IRQ_CLUSTER(43, 43, AB8540_INT_GPIO43F),
GPIO_IRQ_CLUSTER(44, 44, AB8540_INT_GPIO44F),
GPIO_IRQ_CLUSTER(51, 54, AB9540_INT_GPIO51R),
--
1.7.4.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 4/5] pinctrl: ab8540: Staticize some symbols
2013-03-19 6:31 ` [PATCH 4/5] pinctrl: ab8540: " Sachin Kamat
@ 2013-03-19 8:43 ` Patrice CHOTARD
2013-04-09 7:59 ` Linus Walleij
1 sibling, 0 replies; 16+ messages in thread
From: Patrice CHOTARD @ 2013-03-19 8:43 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
patches@linaro.org
On 03/19/2013 07:31 AM, Sachin Kamat wrote:
> Silences the following warnings:
> drivers/pinctrl/pinctrl-ab8540.c:302:28: warning:
> symbol 'ab8540_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8540.c:379:32: warning:
> symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
> ---
> drivers/pinctrl/pinctrl-ab8540.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c
> index 8ee1e8d..9867535 100644
> --- a/drivers/pinctrl/pinctrl-ab8540.c
> +++ b/drivers/pinctrl/pinctrl-ab8540.c
> @@ -299,7 +299,8 @@ static const struct abx500_function ab8540_functions[] = {
> *
> */
>
> -struct alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = {
> +static struct
> +alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = {
> /* GPIOSEL1 - bit 4-7 reserved */
> ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
> ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
> @@ -376,7 +377,7 @@ static struct pullud ab8540_pullud = {
> * GPIO43 to GPIO44
> * GPIO51 to GPIO54
> */
> -struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
> +static struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
> GPIO_IRQ_CLUSTER(43, 43, AB8540_INT_GPIO43F),
> GPIO_IRQ_CLUSTER(44, 44, AB8540_INT_GPIO44F),
> GPIO_IRQ_CLUSTER(51, 54, AB9540_INT_GPIO51R),
Acked-by: Patrice Chotard <patrice.chotard@st.com>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 4/5] pinctrl: ab8540: Staticize some symbols
2013-03-19 6:31 ` [PATCH 4/5] pinctrl: ab8540: " Sachin Kamat
2013-03-19 8:43 ` Patrice CHOTARD
@ 2013-04-09 7:59 ` Linus Walleij
1 sibling, 0 replies; 16+ messages in thread
From: Linus Walleij @ 2013-04-09 7:59 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, Patch Tracking, Patrice Chotard
On Tue, Mar 19, 2013 at 7:31 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the following warnings:
> drivers/pinctrl/pinctrl-ab8540.c:302:28: warning:
> symbol 'ab8540_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8540.c:379:32: warning:
> symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
Patch applied with Patrice's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 5/5] pinctrl: ab8505: Staticize some symbols
2013-03-19 6:31 [PATCH 1/5] pinctrl: abx500: Staticize some symbols Sachin Kamat
` (2 preceding siblings ...)
2013-03-19 6:31 ` [PATCH 4/5] pinctrl: ab8540: " Sachin Kamat
@ 2013-03-19 6:31 ` Sachin Kamat
2013-03-19 8:43 ` Patrice CHOTARD
2013-04-09 8:00 ` Linus Walleij
2013-03-19 8:28 ` [PATCH 1/5] pinctrl: abx500: " Patrice CHOTARD
2013-04-09 7:52 ` Linus Walleij
5 siblings, 2 replies; 16+ messages in thread
From: Sachin Kamat @ 2013-03-19 6:31 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat, patches, Patrice Chotard
Silences the following warnings:
drivers/pinctrl/pinctrl-ab8505.c:274:28: warning:
symbol 'ab8505_alternate_functions' was not declared. Should it be static?
drivers/pinctrl/pinctrl-ab8505.c:351:32: warning:
symbol 'ab8505_gpio_irq_cluster' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Patrice Chotard <patrice.chotard@stericsson.com>
---
drivers/pinctrl/pinctrl-ab8505.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ab8505.c b/drivers/pinctrl/pinctrl-ab8505.c
index 3a4238e..2841db7 100644
--- a/drivers/pinctrl/pinctrl-ab8505.c
+++ b/drivers/pinctrl/pinctrl-ab8505.c
@@ -271,7 +271,8 @@ static const struct abx500_function ab8505_functions[] = {
* alt_A | 1 | 0 | 0
*/
-struct alternate_functions ab8505_alternate_functions[AB8505_GPIO_MAX_NUMBER + 1] = {
+static struct
+alternate_functions ab8505_alternate_functions[AB8505_GPIO_MAX_NUMBER + 1] = {
ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
ALTERNATE_FUNCTIONS(2, 1, UNUSED, UNUSED, 0, 0, 0), /* GPIO2, altA controlled by bit 1 */
@@ -348,7 +349,7 @@ struct alternate_functions ab8505_alternate_functions[AB8505_GPIO_MAX_NUMBER + 1
* GPIO50
* GPIO52 to GPIO53
*/
-struct abx500_gpio_irq_cluster ab8505_gpio_irq_cluster[] = {
+static struct abx500_gpio_irq_cluster ab8505_gpio_irq_cluster[] = {
GPIO_IRQ_CLUSTER(10, 11, AB8500_INT_GPIO10R),
GPIO_IRQ_CLUSTER(13, 13, AB8500_INT_GPIO13R),
GPIO_IRQ_CLUSTER(40, 41, AB8500_INT_GPIO40R),
--
1.7.4.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 5/5] pinctrl: ab8505: Staticize some symbols
2013-03-19 6:31 ` [PATCH 5/5] pinctrl: ab8505: " Sachin Kamat
@ 2013-03-19 8:43 ` Patrice CHOTARD
2013-04-09 8:00 ` Linus Walleij
1 sibling, 0 replies; 16+ messages in thread
From: Patrice CHOTARD @ 2013-03-19 8:43 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
patches@linaro.org
On 03/19/2013 07:31 AM, Sachin Kamat wrote:
> Silences the following warnings:
> drivers/pinctrl/pinctrl-ab8505.c:274:28: warning:
> symbol 'ab8505_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8505.c:351:32: warning:
> symbol 'ab8505_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
> ---
> drivers/pinctrl/pinctrl-ab8505.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ab8505.c b/drivers/pinctrl/pinctrl-ab8505.c
> index 3a4238e..2841db7 100644
> --- a/drivers/pinctrl/pinctrl-ab8505.c
> +++ b/drivers/pinctrl/pinctrl-ab8505.c
> @@ -271,7 +271,8 @@ static const struct abx500_function ab8505_functions[] = {
> * alt_A | 1 | 0 | 0
> */
>
> -struct alternate_functions ab8505_alternate_functions[AB8505_GPIO_MAX_NUMBER + 1] = {
> +static struct
> +alternate_functions ab8505_alternate_functions[AB8505_GPIO_MAX_NUMBER + 1] = {
> ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
> ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
> ALTERNATE_FUNCTIONS(2, 1, UNUSED, UNUSED, 0, 0, 0), /* GPIO2, altA controlled by bit 1 */
> @@ -348,7 +349,7 @@ struct alternate_functions ab8505_alternate_functions[AB8505_GPIO_MAX_NUMBER + 1
> * GPIO50
> * GPIO52 to GPIO53
> */
> -struct abx500_gpio_irq_cluster ab8505_gpio_irq_cluster[] = {
> +static struct abx500_gpio_irq_cluster ab8505_gpio_irq_cluster[] = {
> GPIO_IRQ_CLUSTER(10, 11, AB8500_INT_GPIO10R),
> GPIO_IRQ_CLUSTER(13, 13, AB8500_INT_GPIO13R),
> GPIO_IRQ_CLUSTER(40, 41, AB8500_INT_GPIO40R),
Acked-by: Patrice Chotard <patrice.chotard@st.com>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5/5] pinctrl: ab8505: Staticize some symbols
2013-03-19 6:31 ` [PATCH 5/5] pinctrl: ab8505: " Sachin Kamat
2013-03-19 8:43 ` Patrice CHOTARD
@ 2013-04-09 8:00 ` Linus Walleij
1 sibling, 0 replies; 16+ messages in thread
From: Linus Walleij @ 2013-04-09 8:00 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, Patch Tracking, Patrice Chotard
On Tue, Mar 19, 2013 at 7:31 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the following warnings:
> drivers/pinctrl/pinctrl-ab8505.c:274:28: warning:
> symbol 'ab8505_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8505.c:351:32: warning:
> symbol 'ab8505_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
Patch applied with Patrice's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/5] pinctrl: abx500: Staticize some symbols
2013-03-19 6:31 [PATCH 1/5] pinctrl: abx500: Staticize some symbols Sachin Kamat
` (3 preceding siblings ...)
2013-03-19 6:31 ` [PATCH 5/5] pinctrl: ab8505: " Sachin Kamat
@ 2013-03-19 8:28 ` Patrice CHOTARD
2013-04-04 4:25 ` Sachin Kamat
2013-04-09 7:52 ` Linus Walleij
5 siblings, 1 reply; 16+ messages in thread
From: Patrice CHOTARD @ 2013-03-19 8:28 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
patches@linaro.org
On 03/19/2013 07:31 AM, Sachin Kamat wrote:
> These symbols are used only in this file. Without this patch
> we get the following warnings:
> drivers/pinctrl/pinctrl-abx500.c:520:5: warning:
> symbol 'abx500_gpio_request' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-abx500.c:527:6: warning:
> symbol 'abx500_gpio_free' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-abx500.c:614:5: warning:
> symbol 'abx500_gpio_request_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-abx500.c:714:5: warning:
> symbol 'abx500_pin_config_get' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-abx500.c:721:5: warning:
> symbol 'abx500_pin_config_set' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> ---
> This series is compile tested against linux-next tree (20130319).
> ---
> drivers/pinctrl/pinctrl-abx500.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
> index 0cf3fa4..9b8db91 100644
> --- a/drivers/pinctrl/pinctrl-abx500.c
> +++ b/drivers/pinctrl/pinctrl-abx500.c
> @@ -517,14 +517,14 @@ static inline void abx500_gpio_dbg_show_one(struct seq_file *s,
> #define abx500_gpio_dbg_show NULL
> #endif
>
> -int abx500_gpio_request(struct gpio_chip *chip, unsigned offset)
> +static int abx500_gpio_request(struct gpio_chip *chip, unsigned offset)
> {
> int gpio = chip->base + offset;
>
> return pinctrl_request_gpio(gpio);
> }
>
> -void abx500_gpio_free(struct gpio_chip *chip, unsigned offset)
> +static void abx500_gpio_free(struct gpio_chip *chip, unsigned offset)
> {
> int gpio = chip->base + offset;
>
> @@ -611,7 +611,7 @@ static void abx500_pmx_disable(struct pinctrl_dev *pctldev,
> dev_dbg(pct->dev, "disable group %s, %u pins\n", g->name, g->npins);
> }
>
> -int abx500_gpio_request_enable(struct pinctrl_dev *pctldev,
> +static int abx500_gpio_request_enable(struct pinctrl_dev *pctldev,
> struct pinctrl_gpio_range *range,
> unsigned offset)
> {
> @@ -711,14 +711,14 @@ static const struct pinctrl_ops abx500_pinctrl_ops = {
> .pin_dbg_show = abx500_pin_dbg_show,
> };
>
> -int abx500_pin_config_get(struct pinctrl_dev *pctldev,
> +static int abx500_pin_config_get(struct pinctrl_dev *pctldev,
> unsigned pin,
> unsigned long *config)
> {
> return -ENOSYS;
> }
>
> -int abx500_pin_config_set(struct pinctrl_dev *pctldev,
> +static int abx500_pin_config_set(struct pinctrl_dev *pctldev,
> unsigned pin,
> unsigned long config)
> {
Acked-by: Patrice Chotard <patrice.chotard@st.com>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/5] pinctrl: abx500: Staticize some symbols
2013-03-19 8:28 ` [PATCH 1/5] pinctrl: abx500: " Patrice CHOTARD
@ 2013-04-04 4:25 ` Sachin Kamat
0 siblings, 0 replies; 16+ messages in thread
From: Sachin Kamat @ 2013-04-04 4:25 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org; +Cc: linus.walleij@linaro.org
Hi Linus,
On 19 March 2013 13:58, Patrice CHOTARD <patrice.chotard@st.com> wrote:
> On 03/19/2013 07:31 AM, Sachin Kamat wrote:
>
>> These symbols are used only in this file. Without this patch
>> we get the following warnings:
>> drivers/pinctrl/pinctrl-abx500.c:520:5: warning:
>> symbol 'abx500_gpio_request' was not declared. Should it be static?
>> drivers/pinctrl/pinctrl-abx500.c:527:6: warning:
>> symbol 'abx500_gpio_free' was not declared. Should it be static?
>> drivers/pinctrl/pinctrl-abx500.c:614:5: warning:
>> symbol 'abx500_gpio_request_enable' was not declared. Should it be static?
>> drivers/pinctrl/pinctrl-abx500.c:714:5: warning:
>> symbol 'abx500_pin_config_get' was not declared. Should it be static?
>> drivers/pinctrl/pinctrl-abx500.c:721:5: warning:
>> symbol 'abx500_pin_config_set' was not declared. Should it be static?
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Patrice Chotard <patrice.chotard@st.com>
>> ---
>> This series is compile tested against linux-next tree (20130319).
>> ---
>> drivers/pinctrl/pinctrl-abx500.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
>> index 0cf3fa4..9b8db91 100644
>> --- a/drivers/pinctrl/pinctrl-abx500.c
>> +++ b/drivers/pinctrl/pinctrl-abx500.c
>> @@ -517,14 +517,14 @@ static inline void abx500_gpio_dbg_show_one(struct seq_file *s,
>> #define abx500_gpio_dbg_show NULL
>> #endif
>>
>> -int abx500_gpio_request(struct gpio_chip *chip, unsigned offset)
>> +static int abx500_gpio_request(struct gpio_chip *chip, unsigned offset)
>> {
>> int gpio = chip->base + offset;
>>
>> return pinctrl_request_gpio(gpio);
>> }
>>
>> -void abx500_gpio_free(struct gpio_chip *chip, unsigned offset)
>> +static void abx500_gpio_free(struct gpio_chip *chip, unsigned offset)
>> {
>> int gpio = chip->base + offset;
>>
>> @@ -611,7 +611,7 @@ static void abx500_pmx_disable(struct pinctrl_dev *pctldev,
>> dev_dbg(pct->dev, "disable group %s, %u pins\n", g->name, g->npins);
>> }
>>
>> -int abx500_gpio_request_enable(struct pinctrl_dev *pctldev,
>> +static int abx500_gpio_request_enable(struct pinctrl_dev *pctldev,
>> struct pinctrl_gpio_range *range,
>> unsigned offset)
>> {
>> @@ -711,14 +711,14 @@ static const struct pinctrl_ops abx500_pinctrl_ops = {
>> .pin_dbg_show = abx500_pin_dbg_show,
>> };
>>
>> -int abx500_pin_config_get(struct pinctrl_dev *pctldev,
>> +static int abx500_pin_config_get(struct pinctrl_dev *pctldev,
>> unsigned pin,
>> unsigned long *config)
>> {
>> return -ENOSYS;
>> }
>>
>> -int abx500_pin_config_set(struct pinctrl_dev *pctldev,
>> +static int abx500_pin_config_set(struct pinctrl_dev *pctldev,
>> unsigned pin,
>> unsigned long config)
>> {
>
>
> Acked-by: Patrice Chotard <patrice.chotard@st.com>
Gentle ping on this series.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/5] pinctrl: abx500: Staticize some symbols
2013-03-19 6:31 [PATCH 1/5] pinctrl: abx500: Staticize some symbols Sachin Kamat
` (4 preceding siblings ...)
2013-03-19 8:28 ` [PATCH 1/5] pinctrl: abx500: " Patrice CHOTARD
@ 2013-04-09 7:52 ` Linus Walleij
5 siblings, 0 replies; 16+ messages in thread
From: Linus Walleij @ 2013-04-09 7:52 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-kernel@vger.kernel.org, Patch Tracking, Patrice Chotard
On Tue, Mar 19, 2013 at 7:31 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> These symbols are used only in this file. Without this patch
> we get the following warnings:
> drivers/pinctrl/pinctrl-abx500.c:520:5: warning:
> symbol 'abx500_gpio_request' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-abx500.c:527:6: warning:
> symbol 'abx500_gpio_free' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-abx500.c:614:5: warning:
> symbol 'abx500_gpio_request_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-abx500.c:714:5: warning:
> symbol 'abx500_pin_config_get' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-abx500.c:721:5: warning:
> symbol 'abx500_pin_config_set' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> ---
> This series is compile tested against linux-next tree (20130319).
Patch applied with Patrice's ACK, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 16+ messages in thread