From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 3/4] ARM: tegra: dalmore: add dt node for TPS65090's regulators
Date: Wed, 20 Mar 2013 23:36:22 +0530 [thread overview]
Message-ID: <5149FA9E.6010702@nvidia.com> (raw)
In-Reply-To: <5149EA8F.6090806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Wednesday 20 March 2013 10:27 PM, Rhyland Klein wrote:
> On 3/20/2013 9:44 AM, Laxman Dewangan wrote:
> + regulators {
> + dcdc1 {
> + regulator-name = "vdd-sys-5v0";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> You should also add the tps65090_dcdc1_reg label to dcdc1. I believe you
> make use of it in patch 4 and this currently causes build breaks.
>
Actually patch 4 uses this label and I should add on patch 4, not on
patch 3.
I removed from patch3 and when cherrypick the patch 4 from different
branch to make the patches, I missed the change and hence patch 4 is not
getting compiled.
I will fix the issue on next revision.
Sorry for messing up and thins for pointing this.
WARNING: multiple messages have this Message-ID (diff)
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: tegra: dalmore: add dt node for TPS65090's regulators
Date: Wed, 20 Mar 2013 23:36:22 +0530 [thread overview]
Message-ID: <5149FA9E.6010702@nvidia.com> (raw)
In-Reply-To: <5149EA8F.6090806@nvidia.com>
On Wednesday 20 March 2013 10:27 PM, Rhyland Klein wrote:
> On 3/20/2013 9:44 AM, Laxman Dewangan wrote:
> + regulators {
> + dcdc1 {
> + regulator-name = "vdd-sys-5v0";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> You should also add the tps65090_dcdc1_reg label to dcdc1. I believe you
> make use of it in patch 4 and this currently causes build breaks.
>
Actually patch 4 uses this label and I should add on patch 4, not on
patch 3.
I removed from patch3 and when cherrypick the patch 4 from different
branch to make the patches, I missed the change and hence patch 4 is not
getting compiled.
I will fix the issue on next revision.
Sorry for messing up and thins for pointing this.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: "swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/4] ARM: tegra: dalmore: add dt node for TPS65090's regulators
Date: Wed, 20 Mar 2013 23:36:22 +0530 [thread overview]
Message-ID: <5149FA9E.6010702@nvidia.com> (raw)
In-Reply-To: <5149EA8F.6090806@nvidia.com>
On Wednesday 20 March 2013 10:27 PM, Rhyland Klein wrote:
> On 3/20/2013 9:44 AM, Laxman Dewangan wrote:
> + regulators {
> + dcdc1 {
> + regulator-name = "vdd-sys-5v0";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> You should also add the tps65090_dcdc1_reg label to dcdc1. I believe you
> make use of it in patch 4 and this currently causes build breaks.
>
Actually patch 4 uses this label and I should add on patch 4, not on
patch 3.
I removed from patch3 and when cherrypick the patch 4 from different
branch to make the patches, I missed the change and hence patch 4 is not
getting compiled.
I will fix the issue on next revision.
Sorry for messing up and thins for pointing this.
next prev parent reply other threads:[~2013-03-20 18:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 13:44 [PATCH 0/4] ARM: tegra: dalmore: add regulators Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
[not found] ` <1363787070-14801-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 13:44 ` [PATCH 1/4] ARM: tegra: enable Tegra114 based platform PMICs Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
2013-03-20 20:50 ` Stephen Warren
2013-03-20 20:50 ` Stephen Warren
2013-03-20 13:44 ` [PATCH 2/4] ARM: tegra: dalmore: add cpu regulator's node Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
2013-03-20 13:44 ` [PATCH 3/4] ARM: tegra: dalmore: add dt node for TPS65090's regulators Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
[not found] ` <1363787070-14801-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 16:57 ` Rhyland Klein
2013-03-20 16:57 ` Rhyland Klein
2013-03-20 16:57 ` Rhyland Klein
[not found] ` <5149EA8F.6090806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 18:06 ` Laxman Dewangan [this message]
2013-03-20 18:06 ` Laxman Dewangan
2013-03-20 18:06 ` Laxman Dewangan
2013-03-20 20:48 ` Stephen Warren
2013-03-20 20:48 ` Stephen Warren
2013-03-20 13:44 ` [PATCH 4/4] ARM: tegra: dalmore: add fixed regulator's node Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149FA9E.6010702@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.