All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH 3/4] ARM: tegra: dalmore: add dt node for TPS65090's regulators
Date: Wed, 20 Mar 2013 14:48:46 -0600	[thread overview]
Message-ID: <514A20AE.9040604@wwwdotorg.org> (raw)
In-Reply-To: <1363787070-14801-4-git-send-email-ldewangan@nvidia.com>

On 03/20/2013 07:44 AM, Laxman Dewangan wrote:
> NVIDIA's Tegra114 platform, Dalmore, uses the TPS65090 as
> secondary PMICs which mainly act as voltage switch controlled
> by I2C communication.

> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts

> @@ -747,4 +823,18 @@
>  		bus-width = <8>;
>  		status = "okay";
>  	};
> +	regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;

You need a blank line between the nodes there.

There a a number of typos and capitalization issues in the various
commit descriptions.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: tegra: dalmore: add dt node for TPS65090's regulators
Date: Wed, 20 Mar 2013 14:48:46 -0600	[thread overview]
Message-ID: <514A20AE.9040604@wwwdotorg.org> (raw)
In-Reply-To: <1363787070-14801-4-git-send-email-ldewangan@nvidia.com>

On 03/20/2013 07:44 AM, Laxman Dewangan wrote:
> NVIDIA's Tegra114 platform, Dalmore, uses the TPS65090 as
> secondary PMICs which mainly act as voltage switch controlled
> by I2C communication.

> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts

> @@ -747,4 +823,18 @@
>  		bus-width = <8>;
>  		status = "okay";
>  	};
> +	regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;

You need a blank line between the nodes there.

There a a number of typos and capitalization issues in the various
commit descriptions.

  parent reply	other threads:[~2013-03-20 20:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 13:44 [PATCH 0/4] ARM: tegra: dalmore: add regulators Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
2013-03-20 13:44 ` Laxman Dewangan
     [not found] ` <1363787070-14801-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 13:44   ` [PATCH 1/4] ARM: tegra: enable Tegra114 based platform PMICs Laxman Dewangan
2013-03-20 13:44     ` Laxman Dewangan
2013-03-20 13:44     ` Laxman Dewangan
2013-03-20 20:50     ` Stephen Warren
2013-03-20 20:50       ` Stephen Warren
2013-03-20 13:44   ` [PATCH 2/4] ARM: tegra: dalmore: add cpu regulator's node Laxman Dewangan
2013-03-20 13:44     ` Laxman Dewangan
2013-03-20 13:44     ` Laxman Dewangan
2013-03-20 13:44 ` [PATCH 3/4] ARM: tegra: dalmore: add dt node for TPS65090's regulators Laxman Dewangan
2013-03-20 13:44   ` Laxman Dewangan
2013-03-20 13:44   ` Laxman Dewangan
     [not found]   ` <1363787070-14801-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 16:57     ` Rhyland Klein
2013-03-20 16:57       ` Rhyland Klein
2013-03-20 16:57       ` Rhyland Klein
     [not found]       ` <5149EA8F.6090806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 18:06         ` Laxman Dewangan
2013-03-20 18:06           ` Laxman Dewangan
2013-03-20 18:06           ` Laxman Dewangan
2013-03-20 20:48   ` Stephen Warren [this message]
2013-03-20 20:48     ` Stephen Warren
2013-03-20 13:44 ` [PATCH 4/4] ARM: tegra: dalmore: add fixed regulator's node Laxman Dewangan
2013-03-20 13:44   ` Laxman Dewangan
2013-03-20 13:44   ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514A20AE.9040604@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.