All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Jeons <simon.jeons@gmail.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>, Hugh Dickins <hughd@google.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/9] extend hugepage migration
Date: Thu, 21 Mar 2013 07:49:48 +0800	[thread overview]
Message-ID: <514A4B1C.6020201@gmail.com> (raw)
In-Reply-To: <1363815326-urchkyxr-mutt-n-horiguchi@ah.jp.nec.com>

Hi Naoya,
On 03/21/2013 05:35 AM, Naoya Horiguchi wrote:
> On Wed, Mar 20, 2013 at 07:43:44AM +0800, Simon Jeons wrote:
> ...
>>> Easy patch access:
>>>   git@github.com:Naoya-Horiguchi/linux.git
>>>   branch:extend_hugepage_migration
>>>
>>> Test code:
>>>   git@github.com:Naoya-Horiguchi/test_hugepage_migration_extension.git
>> git clone
>> git@github.com:Naoya-Horiguchi/test_hugepage_migration_extension.git
>> Cloning into test_hugepage_migration_extension...
>> Permission denied (publickey).
>> fatal: The remote end hung up unexpectedly
> Sorry, wrong url.
> git://github.com/Naoya-Horiguchi/test_hugepage_migration_extension.git
> or
> https://github.com/Naoya-Horiguchi/test_hugepage_migration_extension.git
> should work.

When I hacking arch/x86/mm/hugetlbpage.c like this,
diff --git a/arch/x86/mm/hugetlbpage.c b/arch/x86/mm/hugetlbpage.c
index ae1aa71..87f34ee 100644
--- a/arch/x86/mm/hugetlbpage.c
+++ b/arch/x86/mm/hugetlbpage.c
@@ -354,14 +354,13 @@ hugetlb_get_unmapped_area(struct file *file,
unsigned long addr,

#endif /*HAVE_ARCH_HUGETLB_UNMAPPED_AREA*/

-#ifdef CONFIG_X86_64
static __init int setup_hugepagesz(char *opt)
{
unsigned long ps = memparse(opt, &opt);
if (ps == PMD_SIZE) {
hugetlb_add_hstate(PMD_SHIFT - PAGE_SHIFT);
- } else if (ps == PUD_SIZE && cpu_has_gbpages) {
- hugetlb_add_hstate(PUD_SHIFT - PAGE_SHIFT);
+ } else if (ps == PUD_SIZE) {
+ hugetlb_add_hstate(PMD_SHIFT - PAGE_SHIFT+4);
} else {
printk(KERN_ERR "hugepagesz: Unsupported page size %lu M\n",
ps >> 20);

I set boot=hugepagesz=1G hugepages=10, then I got 10 32MB huge pages.
What's the difference between these pages which I hacking and normal
huge pages?

>
> Thanks,
> Naoya

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Simon Jeons <simon.jeons@gmail.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>, Hugh Dickins <hughd@google.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/9] extend hugepage migration
Date: Thu, 21 Mar 2013 07:49:48 +0800	[thread overview]
Message-ID: <514A4B1C.6020201@gmail.com> (raw)
In-Reply-To: <1363815326-urchkyxr-mutt-n-horiguchi@ah.jp.nec.com>

Hi Naoya,
On 03/21/2013 05:35 AM, Naoya Horiguchi wrote:
> On Wed, Mar 20, 2013 at 07:43:44AM +0800, Simon Jeons wrote:
> ...
>>> Easy patch access:
>>>   git@github.com:Naoya-Horiguchi/linux.git
>>>   branch:extend_hugepage_migration
>>>
>>> Test code:
>>>   git@github.com:Naoya-Horiguchi/test_hugepage_migration_extension.git
>> git clone
>> git@github.com:Naoya-Horiguchi/test_hugepage_migration_extension.git
>> Cloning into test_hugepage_migration_extension...
>> Permission denied (publickey).
>> fatal: The remote end hung up unexpectedly
> Sorry, wrong url.
> git://github.com/Naoya-Horiguchi/test_hugepage_migration_extension.git
> or
> https://github.com/Naoya-Horiguchi/test_hugepage_migration_extension.git
> should work.

When I hacking arch/x86/mm/hugetlbpage.c like this,
diff --git a/arch/x86/mm/hugetlbpage.c b/arch/x86/mm/hugetlbpage.c
index ae1aa71..87f34ee 100644
--- a/arch/x86/mm/hugetlbpage.c
+++ b/arch/x86/mm/hugetlbpage.c
@@ -354,14 +354,13 @@ hugetlb_get_unmapped_area(struct file *file,
unsigned long addr,

#endif /*HAVE_ARCH_HUGETLB_UNMAPPED_AREA*/

-#ifdef CONFIG_X86_64
static __init int setup_hugepagesz(char *opt)
{
unsigned long ps = memparse(opt, &opt);
if (ps == PMD_SIZE) {
hugetlb_add_hstate(PMD_SHIFT - PAGE_SHIFT);
- } else if (ps == PUD_SIZE && cpu_has_gbpages) {
- hugetlb_add_hstate(PUD_SHIFT - PAGE_SHIFT);
+ } else if (ps == PUD_SIZE) {
+ hugetlb_add_hstate(PMD_SHIFT - PAGE_SHIFT+4);
} else {
printk(KERN_ERR "hugepagesz: Unsupported page size %lu M\n",
ps >> 20);

I set boot=hugepagesz=1G hugepages=10, then I got 10 32MB huge pages.
What's the difference between these pages which I hacking and normal
huge pages?

>
> Thanks,
> Naoya


  reply	other threads:[~2013-03-20 23:49 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-21 19:41 [RFC][PATCH 0/9] extend hugepage migration Naoya Horiguchi
2013-02-21 19:41 ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 1/9] migrate: add migrate_entry_wait_huge() Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-03-18 14:51   ` Michal Hocko
2013-03-18 14:51     ` Michal Hocko
2013-03-19  0:06     ` Naoya Horiguchi
2013-03-19  0:06       ` Naoya Horiguchi
2013-03-19 23:57   ` Simon Jeons
2013-03-19 23:57     ` Simon Jeons
2013-03-20 21:53     ` Naoya Horiguchi
2013-03-20 21:53       ` Naoya Horiguchi
2013-03-20 23:36       ` Simon Jeons
2013-03-20 23:36         ` Simon Jeons
2013-04-04  4:57         ` Simon Jeons
2013-04-04  4:57           ` Simon Jeons
2013-02-21 19:41 ` [PATCH 2/9] migrate: make core migration code aware of hugepage Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-03-18 15:22   ` Michal Hocko
2013-03-18 15:22     ` Michal Hocko
2013-03-18 15:33     ` Michal Hocko
2013-03-18 15:33       ` Michal Hocko
2013-03-19  0:06       ` Naoya Horiguchi
2013-03-19  0:06         ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 3/9] soft-offline: use migrate_pages() instead of migrate_huge_page() Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-27  7:25   ` Chen Gong
2013-02-27 17:06     ` Naoya Horiguchi
2013-02-27 17:06       ` Naoya Horiguchi
2013-02-27 17:57       ` Naoya Horiguchi
2013-02-27 17:57         ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 4/9] migrate: clean up migrate_huge_page() Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 5/9] migrate: enable migrate_pages() to migrate hugepage Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-03-18 15:40   ` Michal Hocko
2013-03-18 15:40     ` Michal Hocko
2013-03-19  0:07     ` Naoya Horiguchi
2013-03-19  0:07       ` Naoya Horiguchi
2013-03-19  7:11       ` Michal Hocko
2013-03-19  7:11         ` Michal Hocko
2013-03-20  6:12         ` Naoya Horiguchi
2013-03-20  6:12           ` Naoya Horiguchi
2013-03-20  7:41           ` Michal Hocko
2013-03-20  7:41             ` Michal Hocko
2013-03-20  0:31       ` Simon Jeons
2013-03-20  0:31         ` Simon Jeons
2013-03-20 21:59         ` Naoya Horiguchi
2013-03-20 21:59           ` Naoya Horiguchi
2013-03-21  0:06           ` Simon Jeons
2013-03-21  0:06             ` Simon Jeons
2013-02-21 19:41 ` [PATCH 6/9] migrate: enable move_pages() " Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 7/9] mbind: enable mbind() " Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 8/9] memory-hotplug: enable memory hotplug to handle hugepage Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-23  7:05   ` Hillf Danton
2013-02-23  7:05     ` Hillf Danton
2013-02-25 16:57     ` Naoya Horiguchi
2013-02-25 16:57       ` Naoya Horiguchi
2013-02-27  7:36   ` Chen Gong
2013-02-27 17:16     ` Naoya Horiguchi
2013-02-27 17:16       ` Naoya Horiguchi
2013-03-18 16:07   ` Michal Hocko
2013-03-18 16:07     ` Michal Hocko
2013-03-20  3:55     ` Naoya Horiguchi
2013-03-20  3:55       ` Naoya Horiguchi
2013-03-20  7:57       ` Michal Hocko
2013-03-20  7:57         ` Michal Hocko
2013-03-20  1:03   ` Simon Jeons
2013-03-20  1:03     ` Simon Jeons
2013-03-20 22:05     ` Naoya Horiguchi
2013-03-20 22:05       ` Naoya Horiguchi
2013-03-20 23:55       ` Simon Jeons
2013-03-20 23:55         ` Simon Jeons
2013-02-21 19:41 ` [PATCH 9/9] remove /proc/sys/vm/hugepages_treat_as_movable Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-28  6:02   ` KOSAKI Motohiro
2013-02-28  6:02     ` KOSAKI Motohiro
2013-02-28 18:16     ` Naoya Horiguchi
2013-02-28 18:16       ` Naoya Horiguchi
2013-03-18 15:51   ` Michal Hocko
2013-03-18 15:51     ` Michal Hocko
2013-03-19  0:07     ` Naoya Horiguchi
2013-03-19  0:07       ` Naoya Horiguchi
2013-03-19 23:43 ` [RFC][PATCH 0/9] extend hugepage migration Simon Jeons
2013-03-19 23:43   ` Simon Jeons
2013-03-20 21:35   ` Naoya Horiguchi
2013-03-20 21:35     ` Naoya Horiguchi
2013-03-20 23:49     ` Simon Jeons [this message]
2013-03-20 23:49       ` Simon Jeons
2013-03-21 12:56       ` Michal Hocko
2013-03-21 12:56         ` Michal Hocko
2013-03-21 23:46         ` Simon Jeons
2013-03-21 23:46           ` Simon Jeons
     [not found]           ` <20130322081532.GC31457@dhcp22.suse.cz>
2013-04-05  1:14             ` Simon Jeons
2013-04-05  1:14               ` Simon Jeons
2013-04-05  8:08               ` Michal Hocko
2013-04-05  8:08                 ` Michal Hocko
2013-04-05  9:00                 ` Simon Jeons
2013-04-05  9:00                   ` Simon Jeons
2013-04-05  9:30                   ` Michal Hocko
2013-04-05  9:30                     ` Michal Hocko
2013-04-07  0:32                     ` Simon Jeons
2013-04-07  0:32                       ` Simon Jeons
2013-04-07 14:05                       ` KOSAKI Motohiro
2013-04-07 14:05                         ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514A4B1C.6020201@gmail.com \
    --to=simon.jeons@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hughd@google.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=n-horiguchi@ah.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.