All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Jeons <simon.jeons@gmail.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>, Hugh Dickins <hughd@google.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] memory-hotplug: enable memory hotplug to handle hugepage
Date: Thu, 21 Mar 2013 07:55:28 +0800	[thread overview]
Message-ID: <514A4C70.2020303@gmail.com> (raw)
In-Reply-To: <1363817148-rlt5mp5n-mutt-n-horiguchi@ah.jp.nec.com>

Hi Naoya,
On 03/21/2013 06:05 AM, Naoya Horiguchi wrote:
> On Wed, Mar 20, 2013 at 09:03:20AM +0800, Simon Jeons wrote:
>> Hi Naoya,
>> On 02/22/2013 03:41 AM, Naoya Horiguchi wrote:
>>> Currently we can't offline memory blocks which contain hugepages because
>>> a hugepage is considered as an unmovable page. But now with this patch
>>> series, a hugepage has become movable, so by using hugepage migration we
>>> can offline such memory blocks.
>>>
>>> What's different from other users of hugepage migration is that we need
>>> to decompose all the hugepages inside the target memory block into free
>> For other hugepage migration users, hugepage should be freed to
>> hugepage_freelists after migration, but why I don't see any codes do
>> this?
> The source hugepages which are migrated by NUMA related system calls
> (migrate_pages(2), move_pages(2), and mbind(2)) are still useable,
> so we simply free them into free hugepage pool.

It seems that you misunderstand why I confuse. I can't find where free
huge pages to hugepage pool, could you point out to me?

> OTOH, the source hugepages migrated by memory hotremove should not be
> reusable, because users of memory hotremove want to remove the memory
> from the system. So we need to free such hugepages forcibly into the
> buddy pages, otherwise memory offining doesn't work.
>
> Thanks,
> Naoya

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Simon Jeons <simon.jeons@gmail.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>, Hugh Dickins <hughd@google.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] memory-hotplug: enable memory hotplug to handle hugepage
Date: Thu, 21 Mar 2013 07:55:28 +0800	[thread overview]
Message-ID: <514A4C70.2020303@gmail.com> (raw)
In-Reply-To: <1363817148-rlt5mp5n-mutt-n-horiguchi@ah.jp.nec.com>

Hi Naoya,
On 03/21/2013 06:05 AM, Naoya Horiguchi wrote:
> On Wed, Mar 20, 2013 at 09:03:20AM +0800, Simon Jeons wrote:
>> Hi Naoya,
>> On 02/22/2013 03:41 AM, Naoya Horiguchi wrote:
>>> Currently we can't offline memory blocks which contain hugepages because
>>> a hugepage is considered as an unmovable page. But now with this patch
>>> series, a hugepage has become movable, so by using hugepage migration we
>>> can offline such memory blocks.
>>>
>>> What's different from other users of hugepage migration is that we need
>>> to decompose all the hugepages inside the target memory block into free
>> For other hugepage migration users, hugepage should be freed to
>> hugepage_freelists after migration, but why I don't see any codes do
>> this?
> The source hugepages which are migrated by NUMA related system calls
> (migrate_pages(2), move_pages(2), and mbind(2)) are still useable,
> so we simply free them into free hugepage pool.

It seems that you misunderstand why I confuse. I can't find where free
huge pages to hugepage pool, could you point out to me?

> OTOH, the source hugepages migrated by memory hotremove should not be
> reusable, because users of memory hotremove want to remove the memory
> from the system. So we need to free such hugepages forcibly into the
> buddy pages, otherwise memory offining doesn't work.
>
> Thanks,
> Naoya


  reply	other threads:[~2013-03-20 23:55 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-21 19:41 [RFC][PATCH 0/9] extend hugepage migration Naoya Horiguchi
2013-02-21 19:41 ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 1/9] migrate: add migrate_entry_wait_huge() Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-03-18 14:51   ` Michal Hocko
2013-03-18 14:51     ` Michal Hocko
2013-03-19  0:06     ` Naoya Horiguchi
2013-03-19  0:06       ` Naoya Horiguchi
2013-03-19 23:57   ` Simon Jeons
2013-03-19 23:57     ` Simon Jeons
2013-03-20 21:53     ` Naoya Horiguchi
2013-03-20 21:53       ` Naoya Horiguchi
2013-03-20 23:36       ` Simon Jeons
2013-03-20 23:36         ` Simon Jeons
2013-04-04  4:57         ` Simon Jeons
2013-04-04  4:57           ` Simon Jeons
2013-02-21 19:41 ` [PATCH 2/9] migrate: make core migration code aware of hugepage Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-03-18 15:22   ` Michal Hocko
2013-03-18 15:22     ` Michal Hocko
2013-03-18 15:33     ` Michal Hocko
2013-03-18 15:33       ` Michal Hocko
2013-03-19  0:06       ` Naoya Horiguchi
2013-03-19  0:06         ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 3/9] soft-offline: use migrate_pages() instead of migrate_huge_page() Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-27  7:25   ` Chen Gong
2013-02-27 17:06     ` Naoya Horiguchi
2013-02-27 17:06       ` Naoya Horiguchi
2013-02-27 17:57       ` Naoya Horiguchi
2013-02-27 17:57         ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 4/9] migrate: clean up migrate_huge_page() Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 5/9] migrate: enable migrate_pages() to migrate hugepage Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-03-18 15:40   ` Michal Hocko
2013-03-18 15:40     ` Michal Hocko
2013-03-19  0:07     ` Naoya Horiguchi
2013-03-19  0:07       ` Naoya Horiguchi
2013-03-19  7:11       ` Michal Hocko
2013-03-19  7:11         ` Michal Hocko
2013-03-20  6:12         ` Naoya Horiguchi
2013-03-20  6:12           ` Naoya Horiguchi
2013-03-20  7:41           ` Michal Hocko
2013-03-20  7:41             ` Michal Hocko
2013-03-20  0:31       ` Simon Jeons
2013-03-20  0:31         ` Simon Jeons
2013-03-20 21:59         ` Naoya Horiguchi
2013-03-20 21:59           ` Naoya Horiguchi
2013-03-21  0:06           ` Simon Jeons
2013-03-21  0:06             ` Simon Jeons
2013-02-21 19:41 ` [PATCH 6/9] migrate: enable move_pages() " Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 7/9] mbind: enable mbind() " Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-21 19:41 ` [PATCH 8/9] memory-hotplug: enable memory hotplug to handle hugepage Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-23  7:05   ` Hillf Danton
2013-02-23  7:05     ` Hillf Danton
2013-02-25 16:57     ` Naoya Horiguchi
2013-02-25 16:57       ` Naoya Horiguchi
2013-02-27  7:36   ` Chen Gong
2013-02-27 17:16     ` Naoya Horiguchi
2013-02-27 17:16       ` Naoya Horiguchi
2013-03-18 16:07   ` Michal Hocko
2013-03-18 16:07     ` Michal Hocko
2013-03-20  3:55     ` Naoya Horiguchi
2013-03-20  3:55       ` Naoya Horiguchi
2013-03-20  7:57       ` Michal Hocko
2013-03-20  7:57         ` Michal Hocko
2013-03-20  1:03   ` Simon Jeons
2013-03-20  1:03     ` Simon Jeons
2013-03-20 22:05     ` Naoya Horiguchi
2013-03-20 22:05       ` Naoya Horiguchi
2013-03-20 23:55       ` Simon Jeons [this message]
2013-03-20 23:55         ` Simon Jeons
2013-02-21 19:41 ` [PATCH 9/9] remove /proc/sys/vm/hugepages_treat_as_movable Naoya Horiguchi
2013-02-21 19:41   ` Naoya Horiguchi
2013-02-28  6:02   ` KOSAKI Motohiro
2013-02-28  6:02     ` KOSAKI Motohiro
2013-02-28 18:16     ` Naoya Horiguchi
2013-02-28 18:16       ` Naoya Horiguchi
2013-03-18 15:51   ` Michal Hocko
2013-03-18 15:51     ` Michal Hocko
2013-03-19  0:07     ` Naoya Horiguchi
2013-03-19  0:07       ` Naoya Horiguchi
2013-03-19 23:43 ` [RFC][PATCH 0/9] extend hugepage migration Simon Jeons
2013-03-19 23:43   ` Simon Jeons
2013-03-20 21:35   ` Naoya Horiguchi
2013-03-20 21:35     ` Naoya Horiguchi
2013-03-20 23:49     ` Simon Jeons
2013-03-20 23:49       ` Simon Jeons
2013-03-21 12:56       ` Michal Hocko
2013-03-21 12:56         ` Michal Hocko
2013-03-21 23:46         ` Simon Jeons
2013-03-21 23:46           ` Simon Jeons
     [not found]           ` <20130322081532.GC31457@dhcp22.suse.cz>
2013-04-05  1:14             ` Simon Jeons
2013-04-05  1:14               ` Simon Jeons
2013-04-05  8:08               ` Michal Hocko
2013-04-05  8:08                 ` Michal Hocko
2013-04-05  9:00                 ` Simon Jeons
2013-04-05  9:00                   ` Simon Jeons
2013-04-05  9:30                   ` Michal Hocko
2013-04-05  9:30                     ` Michal Hocko
2013-04-07  0:32                     ` Simon Jeons
2013-04-07  0:32                       ` Simon Jeons
2013-04-07 14:05                       ` KOSAKI Motohiro
2013-04-07 14:05                         ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514A4C70.2020303@gmail.com \
    --to=simon.jeons@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hughd@google.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=n-horiguchi@ah.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.