* [PATCH] irqchip: gic: fix irq_trigger return
@ 2013-03-19 23:05 ` Stephen Boyd
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2013-03-19 23:05 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Abhijeet Dharmapurikar, linux-kernel, linux-arm-msm,
linux-arm-kernel
From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
The genirq layer expects a 0 in case of failure but the code is
returning -ENXIO. Fix it.
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/irqchip/irq-gic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 644d724..2ebf28a 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
if (gic_arch_extn.irq_retrigger)
return gic_arch_extn.irq_retrigger(d);
- return -ENXIO;
+ /* the genirq layer expects 0 for a failure */
+ return 0;
}
#ifdef CONFIG_SMP
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] irqchip: gic: fix irq_trigger return
@ 2013-03-19 23:05 ` Stephen Boyd
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2013-03-19 23:05 UTC (permalink / raw)
To: linux-arm-kernel
From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
The genirq layer expects a 0 in case of failure but the code is
returning -ENXIO. Fix it.
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/irqchip/irq-gic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 644d724..2ebf28a 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
if (gic_arch_extn.irq_retrigger)
return gic_arch_extn.irq_retrigger(d);
- return -ENXIO;
+ /* the genirq layer expects 0 for a failure */
+ return 0;
}
#ifdef CONFIG_SMP
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] irqchip: gic: fix irq_trigger return
2013-03-19 23:05 ` Stephen Boyd
@ 2013-03-26 17:33 ` Stephen Boyd
-1 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2013-03-26 17:33 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Abhijeet Dharmapurikar, linux-kernel, linux-arm-msm,
linux-arm-kernel
On 03/19/13 16:05, Stephen Boyd wrote:
> From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
>
> The genirq layer expects a 0 in case of failure but the code is
> returning -ENXIO. Fix it.
>
> Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/irqchip/irq-gic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index 644d724..2ebf28a 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
> if (gic_arch_extn.irq_retrigger)
> return gic_arch_extn.irq_retrigger(d);
>
> - return -ENXIO;
> + /* the genirq layer expects 0 for a failure */
> + return 0;
> }
>
> #ifdef CONFIG_SMP
Ping.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] irqchip: gic: fix irq_trigger return
@ 2013-03-26 17:33 ` Stephen Boyd
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2013-03-26 17:33 UTC (permalink / raw)
To: linux-arm-kernel
On 03/19/13 16:05, Stephen Boyd wrote:
> From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
>
> The genirq layer expects a 0 in case of failure but the code is
> returning -ENXIO. Fix it.
>
> Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/irqchip/irq-gic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index 644d724..2ebf28a 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
> if (gic_arch_extn.irq_retrigger)
> return gic_arch_extn.irq_retrigger(d);
>
> - return -ENXIO;
> + /* the genirq layer expects 0 for a failure */
> + return 0;
> }
>
> #ifdef CONFIG_SMP
Ping.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:irq/urgent] irqchip: gic: fix irq_trigger return
2013-03-19 23:05 ` Stephen Boyd
(?)
(?)
@ 2013-03-26 20:08 ` tip-bot for Abhijeet Dharmapurikar
-1 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Abhijeet Dharmapurikar @ 2013-03-26 20:08 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, adharmap, tglx, sboyd
Commit-ID: bad9a43a20372a3b41e15e8aa03b918c76f360f0
Gitweb: http://git.kernel.org/tip/bad9a43a20372a3b41e15e8aa03b918c76f360f0
Author: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
AuthorDate: Tue, 19 Mar 2013 16:05:49 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 26 Mar 2013 20:52:25 +0100
irqchip: gic: fix irq_trigger return
The genirq layer expects a 0 in case that the retrigger function is
not able to resend the irq in hardware, but the code is returning
-ENXIO. Fix it.
[ tglx: Reworked comment and changelog ]
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/1363734349-32635-1-git-send-email-sboyd@codeaurora.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-gic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index a32e0d5..fc6aebf 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
if (gic_arch_extn.irq_retrigger)
return gic_arch_extn.irq_retrigger(d);
- return -ENXIO;
+ /* the genirq layer expects 0 if we can't retrigger in hardware */
+ return 0;
}
#ifdef CONFIG_SMP
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-03-26 20:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-19 23:05 [PATCH] irqchip: gic: fix irq_trigger return Stephen Boyd
2013-03-19 23:05 ` Stephen Boyd
2013-03-26 17:33 ` Stephen Boyd
2013-03-26 17:33 ` Stephen Boyd
2013-03-26 20:08 ` [tip:irq/urgent] " tip-bot for Abhijeet Dharmapurikar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.