From: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
To: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: rjw-KKrjLPT3xs0@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
rnayak-l0cyMroinI0@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
nsekhar-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH 4/9] ARM: OMAP4: cpuidle: fix wrong driver initialization
Date: Fri, 29 Mar 2013 16:08:21 +0530 [thread overview]
Message-ID: <51556F1D.5030208@ti.com> (raw)
In-Reply-To: <1364553095-25110-4-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Friday 29 March 2013 04:01 PM, Daniel Lezcano wrote:
> The driver is initialized several times. This is wrong and if the
> return code of the function was checked, it will return -EINVAL.
>
> Move this initialization out of the loop.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
Fix for this is already and v2 of the patch is here [1]
Regards,
Santosh
[1] https://patchwork.kernel.org/patch/2329861/
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] ARM: OMAP4: cpuidle: fix wrong driver initialization
Date: Fri, 29 Mar 2013 16:08:21 +0530 [thread overview]
Message-ID: <51556F1D.5030208@ti.com> (raw)
In-Reply-To: <1364553095-25110-4-git-send-email-daniel.lezcano@linaro.org>
On Friday 29 March 2013 04:01 PM, Daniel Lezcano wrote:
> The driver is initialized several times. This is wrong and if the
> return code of the function was checked, it will return -EINVAL.
>
> Move this initialization out of the loop.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
Fix for this is already and v2 of the patch is here [1]
Regards,
Santosh
[1] https://patchwork.kernel.org/patch/2329861/
next prev parent reply other threads:[~2013-03-29 10:38 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 10:31 [PATCH 1/9] ARM: cpuidle: remove useless declaration Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
2013-03-29 10:31 ` [PATCH 2/9] ARM: shmobile: pm: fix init sections Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
2013-03-29 10:31 ` [PATCH 3/9] ARM: shmobile: cpuidle: remove useless WFI function Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
2013-03-29 10:31 ` [PATCH 5/9] ARM: tegra2: cpuidle: change driver initialization Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
2013-03-29 16:02 ` Stephen Warren
2013-03-29 16:02 ` Stephen Warren
2013-04-03 11:18 ` Daniel Lezcano
2013-04-03 11:18 ` Daniel Lezcano
[not found] ` <515C101F.1020801-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 11:23 ` Joseph Lo
2013-04-03 11:23 ` Joseph Lo
[not found] ` <1364988239.16957.78.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2013-04-03 12:09 ` Daniel Lezcano
2013-04-03 12:09 ` Daniel Lezcano
[not found] ` <1364553095-25110-5-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-30 2:22 ` Joseph Lo
2013-03-30 2:22 ` Joseph Lo
2013-04-03 16:51 ` Stephen Warren
2013-04-03 16:51 ` Stephen Warren
[not found] ` <1364553095-25110-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-29 10:31 ` [PATCH 4/9] ARM: OMAP4: cpuidle: fix wrong " Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
[not found] ` <1364553095-25110-4-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-29 10:38 ` Santosh Shilimkar [this message]
2013-03-29 10:38 ` Santosh Shilimkar
[not found] ` <51556F1D.5030208-l0cyMroinI0@public.gmane.org>
2013-03-29 10:45 ` Daniel Lezcano
2013-03-29 10:45 ` Daniel Lezcano
[not found] ` <515570DF.5010608-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-29 10:53 ` Santosh Shilimkar
2013-03-29 10:53 ` Santosh Shilimkar
[not found] ` <515572C7.1030309-l0cyMroinI0@public.gmane.org>
2013-03-29 11:23 ` Daniel Lezcano
2013-03-29 11:23 ` Daniel Lezcano
[not found] ` <515579C6.1090602-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-29 11:31 ` Santosh Shilimkar
2013-03-29 11:31 ` Santosh Shilimkar
2013-03-29 11:56 ` Amit Kucheria
2013-03-29 11:56 ` Amit Kucheria
2013-03-29 12:20 ` Santosh Shilimkar
2013-03-29 12:20 ` Santosh Shilimkar
2013-03-29 12:50 ` Amit Kucheria
2013-03-29 12:50 ` Amit Kucheria
[not found] ` <CAP245DWAAgQ4co34mdkFgepC5kP9v0n6B954ej2X_y20LE9kSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-29 15:10 ` Santosh Shilimkar
2013-03-29 15:10 ` Santosh Shilimkar
2013-03-29 15:50 ` How to facilitate the cpuidle drivers to go to the same direction (Was: Re: [PATCH 4/9] ARM: OMAP4: cpuidle: fix wrong driver initialization) Daniel Lezcano
2013-03-29 15:50 ` Daniel Lezcano
2013-03-31 11:14 ` Rafael J. Wysocki
2013-03-31 11:14 ` Rafael J. Wysocki
[not found] ` <5155B85F.6030808-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-01 6:05 ` Deepthi Dharwar
2013-04-01 6:05 ` Deepthi Dharwar
[not found] ` <515923C7.8040408-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2013-04-01 8:26 ` Daniel Lezcano
2013-04-01 8:26 ` Daniel Lezcano
2013-04-01 8:29 ` Benjamin Herrenschmidt
2013-04-01 8:29 ` Benjamin Herrenschmidt
2013-04-02 18:37 ` Olof Johansson
2013-04-02 18:37 ` Olof Johansson
2013-03-29 10:31 ` [PATCH 6/9] ARM: tegra: cpuidle: remove useless initialization Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
2013-03-29 10:31 ` [PATCH 7/9] ARM: davinci: cpuidle: fix wrong enter function Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
[not found] ` <1364553095-25110-7-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-29 11:36 ` Santosh Shilimkar
2013-03-29 11:36 ` Santosh Shilimkar
2013-03-29 10:31 ` [PATCH 8/9] intel: cpuidle: remove stop/start critical timings Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
2013-03-29 10:31 ` [PATCH 9/9] ARM: omap3: cpuidle: enable time keeping Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
2013-03-29 11:35 ` Santosh Shilimkar
2013-03-29 11:35 ` Santosh Shilimkar
2013-03-29 11:40 ` [PATCH 1/9] ARM: cpuidle: remove useless declaration Santosh Shilimkar
2013-03-29 11:40 ` Santosh Shilimkar
[not found] ` <51557DC6.5060104-l0cyMroinI0@public.gmane.org>
2013-03-29 11:53 ` Daniel Lezcano
2013-03-29 11:53 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51556F1D.5030208@ti.com \
--to=santosh.shilimkar-l0cymroini0@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=rnayak-l0cyMroinI0@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.