All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure
Date: Mon, 01 Apr 2013 19:40:39 +0200	[thread overview]
Message-ID: <5159C697.4040609@openwrt.org> (raw)
In-Reply-To: <CAMgrJ3b0EUUae8k1Z2RR92eLbFyPGpqA5px1J_gALDTJ+rmAnA@mail.gmail.com>

On 2013-04-01 4:22 PM, Robert Shade wrote:
> Re-enable interrupts after a channel change failure, since
> ath_complete_reset will not be called.  Also schedule a reset as a
> best effort method to recover the chip from whatever state caused the
> channel change failure.
> 
> Signed-off-by: Robert Shade <robert.shade@gmail.com>
Your patch is badly whitespace damaged.

> ---
>  drivers/net/wireless/ath/ath9k/main.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/main.c
> b/drivers/net/wireless/ath/ath9k/main.c
> index 24650fd..0567ac9 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -280,6 +280,12 @@ static int ath_reset_internal(struct ath_softc
> *sc, struct ath9k_channel *hchan)
>   if (r) {
>   ath_err(common,
>   "Unable to reset channel, reset status %d\n", r);
> +
> + ath9k_hw_set_interrupts(ah);
Why the call to ath9k_hw_set_interrupts here?

> + ath9k_hw_enable_interrupts(ah);
> +
> + ath9k_queue_reset(sc, RESET_TYPE_BB_HANG);
> +
>   goto out;
>   }

WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Robert Shade <robert.shade@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
	Adrian Chadd <adrian@freebsd.org>
Subject: Re: [PATCH] ath9k: Re-enable interrupts after a channel change failure
Date: Mon, 01 Apr 2013 19:40:39 +0200	[thread overview]
Message-ID: <5159C697.4040609@openwrt.org> (raw)
In-Reply-To: <CAMgrJ3b0EUUae8k1Z2RR92eLbFyPGpqA5px1J_gALDTJ+rmAnA@mail.gmail.com>

On 2013-04-01 4:22 PM, Robert Shade wrote:
> Re-enable interrupts after a channel change failure, since
> ath_complete_reset will not be called.  Also schedule a reset as a
> best effort method to recover the chip from whatever state caused the
> channel change failure.
> 
> Signed-off-by: Robert Shade <robert.shade@gmail.com>
Your patch is badly whitespace damaged.

> ---
>  drivers/net/wireless/ath/ath9k/main.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/main.c
> b/drivers/net/wireless/ath/ath9k/main.c
> index 24650fd..0567ac9 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -280,6 +280,12 @@ static int ath_reset_internal(struct ath_softc
> *sc, struct ath9k_channel *hchan)
>   if (r) {
>   ath_err(common,
>   "Unable to reset channel, reset status %d\n", r);
> +
> + ath9k_hw_set_interrupts(ah);
Why the call to ath9k_hw_set_interrupts here?

> + ath9k_hw_enable_interrupts(ah);
> +
> + ath9k_queue_reset(sc, RESET_TYPE_BB_HANG);
> +
>   goto out;
>   }


  parent reply	other threads:[~2013-04-01 17:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 14:22 [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure Robert Shade
2013-04-01 14:22 ` Robert Shade
2013-04-01 16:25 ` [ath9k-devel] " Adrian Chadd
2013-04-01 16:25   ` Adrian Chadd
2013-04-01 16:53   ` [ath9k-devel] " Robert Shade
2013-04-01 17:43   ` John W. Linville
2013-04-01 17:43     ` John W. Linville
2013-04-01 17:40 ` Felix Fietkau [this message]
2013-04-01 17:40   ` Felix Fietkau
2013-04-02 12:03   ` [ath9k-devel] " Robert Shade
2013-04-02 12:03     ` Robert Shade
2013-04-02 12:24     ` [ath9k-devel] " Felix Fietkau
2013-04-02 12:24       ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5159C697.4040609@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.