From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure
Date: Tue, 02 Apr 2013 14:24:32 +0200 [thread overview]
Message-ID: <515ACE00.7020103@openwrt.org> (raw)
In-Reply-To: <CAMgrJ3YFCY1gFp6sT5HJw-KVpvGpx82_HiZkWBDQj1Me96Bw=w@mail.gmail.com>
On 2013-04-02 2:03 PM, Robert Shade wrote:
> On Mon, Apr 1, 2013 at 1:40 PM, Felix Fietkau <nbd@openwrt.org> wrote:
>> Your patch is badly whitespace damaged.
>
> Ouch, must be the gmail web client. I'll resubmit a fixed one.
>
>> Why the call to ath9k_hw_set_interrupts here?
>
> Simply because that's what ath_complete_reset does
OK. You can leave it out, because it's not required for
interrupt-disable refcounting, and it will be called again after a
successful reset.
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Robert Shade <robert.shade@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
Adrian Chadd <adrian@freebsd.org>
Subject: Re: [PATCH] ath9k: Re-enable interrupts after a channel change failure
Date: Tue, 02 Apr 2013 14:24:32 +0200 [thread overview]
Message-ID: <515ACE00.7020103@openwrt.org> (raw)
In-Reply-To: <CAMgrJ3YFCY1gFp6sT5HJw-KVpvGpx82_HiZkWBDQj1Me96Bw=w@mail.gmail.com>
On 2013-04-02 2:03 PM, Robert Shade wrote:
> On Mon, Apr 1, 2013 at 1:40 PM, Felix Fietkau <nbd@openwrt.org> wrote:
>> Your patch is badly whitespace damaged.
>
> Ouch, must be the gmail web client. I'll resubmit a fixed one.
>
>> Why the call to ath9k_hw_set_interrupts here?
>
> Simply because that's what ath_complete_reset does
OK. You can leave it out, because it's not required for
interrupt-disable refcounting, and it will be called again after a
successful reset.
- Felix
next prev parent reply other threads:[~2013-04-02 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 14:22 [ath9k-devel] [PATCH] ath9k: Re-enable interrupts after a channel change failure Robert Shade
2013-04-01 14:22 ` Robert Shade
2013-04-01 16:25 ` [ath9k-devel] " Adrian Chadd
2013-04-01 16:25 ` Adrian Chadd
2013-04-01 16:53 ` [ath9k-devel] " Robert Shade
2013-04-01 17:43 ` John W. Linville
2013-04-01 17:43 ` John W. Linville
2013-04-01 17:40 ` [ath9k-devel] " Felix Fietkau
2013-04-01 17:40 ` Felix Fietkau
2013-04-02 12:03 ` [ath9k-devel] " Robert Shade
2013-04-02 12:03 ` Robert Shade
2013-04-02 12:24 ` Felix Fietkau [this message]
2013-04-02 12:24 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515ACE00.7020103@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.